postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-14 09:37:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use non-orderby compressed metadata in compressed DML

Browse Source 
Currently the additional metadata derived from index columns are
only used for the qualifier pushdown in querying but not the
decompression during compressed DML. This patch makes use of this
metadata for compressed DML as well.
This will lead to considerable speedup when deleting or updating
compressed chunks with filters on non-segmentby columns.
This commit is contained in:
Sven Klemm 2024-04-23 06:42:43 +02:00 committed by Sven Klemm
parent 95b4e246eb
commit 1a3c2cbd17
4 changed files with 69 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.unreleased/pr_6849 Normal file
View File

@ -0,0 +1 @@
Fixes: #6849 Use non-orderby compressed metadata in compressed DML

32
tsl/src/compression/compression.c
View File

@ -2607,17 +2607,31 @@ fill_predicate_context(Chunk *ch, CompressionSettings *settings, List *predicate
false)); /* is_null */
}
}
continue;
}
else if (ts_array_is_member(settings->fd.orderby, column_name))
int min_attno = compressed_column_metadata_attno(settings,
ch->table_id,
var->varattno,
settings->fd.relid,
"min");
int max_attno = compressed_column_metadata_attno(settings,
ch->table_id,
var->varattno,
settings->fd.relid,
"max");
if (min_attno != InvalidAttrNumber && max_attno != InvalidAttrNumber)
{
int16 index = ts_array_position(settings->fd.orderby, column_name);
switch (op_strategy)
{
case BTEqualStrategyNumber:
{
/* orderby col = value implies min <= value and max >= value */
*heap_filters = lappend(*heap_filters,
make_batchfilter(column_segment_min_name(index),
make_batchfilter(get_attname(settings->fd.relid,
min_attno,
false),
BTLessEqualStrategyNumber,
collation,
opcode,
@ -2625,7 +2639,9 @@ fill_predicate_context(Chunk *ch, CompressionSettings *settings, List *predicate
false, /* is_null_check */
false)); /* is_null */
*heap_filters = lappend(*heap_filters,
make_batchfilter(column_segment_max_name(index),
make_batchfilter(get_attname(settings->fd.relid,
max_attno,
false),
BTGreaterEqualStrategyNumber,
collation,
opcode,
@ -2639,7 +2655,9 @@ fill_predicate_context(Chunk *ch, CompressionSettings *settings, List *predicate
{
/* orderby col <[=] value implies min <[=] value */
*heap_filters = lappend(*heap_filters,
make_batchfilter(column_segment_min_name(index),
make_batchfilter(get_attname(settings->fd.relid,
min_attno,
false),
op_strategy,
collation,
opcode,
@ -2653,7 +2671,9 @@ fill_predicate_context(Chunk *ch, CompressionSettings *settings, List *predicate
{
/* orderby col >[=] value implies max >[=] value */
*heap_filters = lappend(*heap_filters,
make_batchfilter(column_segment_max_name(index),
make_batchfilter(get_attname(settings->fd.relid,
max_attno,
false),
op_strategy,
collation,
opcode,

29
tsl/test/expected/compression_update_delete.out
View File

@ -2915,3 +2915,32 @@ EXPLAIN (costs off) SELECT * FROM test_partials ORDER BY time;
(14 rows)
DROP TABLE test_partials;
CREATE TABLE test_meta_filters(time timestamptz NOT NULL, device text, metric text, v1 float, v2 float);
CREATE INDEX ON test_meta_filters(device, metric, v1);
SELECT create_hypertable('test_meta_filters', 'time');
create_hypertable
---------------------------------
(37,public,test_meta_filters,t)
(1 row)
ALTER TABLE test_meta_filters SET (timescaledb.compress, timescaledb.compress_segmentby='device', timescaledb.compress_orderby='metric,time');
INSERT INTO test_meta_filters SELECT '2020-01-01'::timestamptz,'d1','m' || metric::text,v1,v2 FROM generate_series(1,3,1) metric, generate_series(1,1000,1) v1, generate_series(1,10,1) v2 ORDER BY 1,2,3,4,5;
SELECT compress_chunk(show_chunks('test_meta_filters'));
compress_chunk
------------------------------------------
_timescaledb_internal._hyper_37_77_chunk
(1 row)
EXPLAIN (analyze, timing off, costs off, summary off) DELETE FROM test_meta_filters WHERE device = 'd1' AND metric = 'm1' AND v1 < 100;
QUERY PLAN
------------------------------------------------------------------------------------------------------------
Custom Scan (HypertableModify) (actual rows=0 loops=1)
Batches decompressed: 1
Tuples decompressed: 1000
-> Delete on test_meta_filters (actual rows=0 loops=1)
Delete on _hyper_37_77_chunk test_meta_filters_1
-> Seq Scan on _hyper_37_77_chunk test_meta_filters_1 (actual rows=990 loops=1)
Filter: ((v1 < '100'::double precision) AND (device = 'd1'::text) AND (metric = 'm1'::text))
Rows Removed by Filter: 10
(8 rows)

13
tsl/test/sql/compression_update_delete.sql
View File

@ -1480,3 +1480,16 @@ SELECT compress_chunk(show_chunks('test_partials'));
-- fully compressed
EXPLAIN (costs off) SELECT * FROM test_partials ORDER BY time;
DROP TABLE test_partials;
CREATE TABLE test_meta_filters(time timestamptz NOT NULL, device text, metric text, v1 float, v2 float);
CREATE INDEX ON test_meta_filters(device, metric, v1);
SELECT create_hypertable('test_meta_filters', 'time');
ALTER TABLE test_meta_filters SET (timescaledb.compress, timescaledb.compress_segmentby='device', timescaledb.compress_orderby='metric,time');
INSERT INTO test_meta_filters SELECT '2020-01-01'::timestamptz,'d1','m' || metric::text,v1,v2 FROM generate_series(1,3,1) metric, generate_series(1,1000,1) v1, generate_series(1,10,1) v2 ORDER BY 1,2,3,4,5;
SELECT compress_chunk(show_chunks('test_meta_filters'));
EXPLAIN (analyze, timing off, costs off, summary off) DELETE FROM test_meta_filters WHERE device = 'd1' AND metric = 'm1' AND v1 < 100;