postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 19:13:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Treat clang-tidy warnings as errors

Browse Source 
This change makes the build fail on macos-* if clang-tidy detects any bugs.
This improves our process in two ways.

Firstly, currently we execute clang-tidy on macos-* but ignore the warnings.
As a result we waste CPU resources. Also, somebody who uses MacOS has to fix
the warnings manually while this could be done by the person who introduced
corresponding changes.

Secondly, running clang-tidy on a laptop is relatively expensive. This change
allows to disable clang-tidy locally and speed up the development process.
This commit is contained in:
Aleksander Alekseev 2021-11-17 18:30:12 +03:00 committed by Aleksander Alekseev
parent 9a4c4ca992
commit 0de4955ca5
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/linux-build-and-test.yaml vendored
View File

@ -108,7 +108,7 @@ jobs:
- name: Build TimescaleDB - name: Build TimescaleDB
run: | run: |
./bootstrap -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DPG_SOURCE_DIR=~/$PG_SRC_DIR -DPG_PATH=~/$PG_INSTALL_DIR ${{ matrix.tsdb_build_args }} -DREQUIRE_ALL_TESTS=ON ./bootstrap -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DPG_SOURCE_DIR=~/$PG_SRC_DIR -DPG_PATH=~/$PG_INSTALL_DIR ${{ matrix.tsdb_build_args }} -DREQUIRE_ALL_TESTS=ON -DLINTER_STRICT=ON
make -j $MAKE_JOBS -C build make -j $MAKE_JOBS -C build
make -C build install make -C build install

11
CMakeLists.txt
View File

@ -507,6 +507,9 @@ endif()
option(LINTER "Enable linter support using clang-tidy (ON when using clang)" option(LINTER "Enable linter support using clang-tidy (ON when using clang)"
${LINTER_DEFAULT}) ${LINTER_DEFAULT})
set(LINTER_STRICT_DEFAULT OFF)
option(LINTER_STRICT "Treat linter warnings as errors" ${LINTER_STRICT_DEFAULT})
if(LINTER) if(LINTER)
find_program( find_program(
CLANG_TIDY clang-tidy CLANG_TIDY clang-tidy
@ -516,7 +519,13 @@ if(LINTER)
if(CLANG_TIDY) if(CLANG_TIDY)
message(STATUS "Linter support (clang-tidy) enabled") message(STATUS "Linter support (clang-tidy) enabled")
set(CMAKE_C_CLANG_TIDY "${CLANG_TIDY};--quiet") if(LINTER_STRICT)
set(CMAKE_C_CLANG_TIDY
"${CLANG_TIDY};--warnings-as-errors=clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-core.*,clang-diagnostic-*"
)
else()
set(CMAKE_C_CLANG_TIDY "${CLANG_TIDY};--quiet")
endif(LINTER_STRICT)
else() else()
message(STATUS "Install clang-tidy to enable code linting") message(STATUS "Install clang-tidy to enable code linting")
endif(CLANG_TIDY) endif(CLANG_TIDY)