postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 19:13:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add beta NOTICE when using adaptive chunking

Browse Source 
Adaptive chunking is in beta, and we don't want users enabling it in
production by accident. This commit adds a warning to that effect.
This commit is contained in:
Joshua Lockerman 2018-10-26 14:15:31 -04:00 committed by JLockerman
parent b7a4851cd0
commit 08bac40021
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/hypertable.c
View File

@ -1425,7 +1425,14 @@ ts_hypertable_create(PG_FUNCTION_ARGS)
chunk_adaptive_sizing_info_validate(&chunk_sizing_info); chunk_adaptive_sizing_info_validate(&chunk_sizing_info);
if (chunk_sizing_info.target_size_bytes > 0) if (chunk_sizing_info.target_size_bytes > 0)
{
ereport(NOTICE,
(errcode(ERRCODE_WARNING),
errmsg("adaptive chunking is a BETA feature and is not recommended for production deployments")));
time_dim_info.adaptive_chunking = true; time_dim_info.adaptive_chunking = true;
}
} }
/* Validate that the dimensions are OK */ /* Validate that the dimensions are OK */

7
test/expected/chunk_adaptive.out
View File

@ -43,6 +43,7 @@ SELECT create_hypertable('test_adaptive', 'time',
chunk_target_size => '1MB', chunk_target_size => '1MB',
chunk_sizing_func => 'calculate_chunk_interval'); chunk_sizing_func => 'calculate_chunk_interval');
WARNING: target chunk size for adaptive chunking is less than 10 MB WARNING: target chunk size for adaptive chunking is less than 10 MB
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
---------------------------- ----------------------------
@ -56,6 +57,7 @@ SELECT create_hypertable('test_adaptive', 'time',
chunk_target_size => '1MB', chunk_target_size => '1MB',
create_default_indexes => true); create_default_indexes => true);
WARNING: target chunk size for adaptive chunking is less than 10 MB WARNING: target chunk size for adaptive chunking is less than 10 MB
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
---------------------------- ----------------------------
@ -261,6 +263,7 @@ SELECT create_hypertable('test_adaptive_no_index', 'time',
create_default_indexes => false); create_default_indexes => false);
WARNING: target chunk size for adaptive chunking is less than 10 MB WARNING: target chunk size for adaptive chunking is less than 10 MB
WARNING: no index on "time" found for adaptive chunking on hypertable "test_adaptive_no_index" WARNING: no index on "time" found for adaptive chunking on hypertable "test_adaptive_no_index"
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
------------------------------------- -------------------------------------
@ -360,6 +363,7 @@ SELECT create_hypertable('test_adaptive_correct_index', 'time',
chunk_time_interval => 86400000000, chunk_time_interval => 86400000000,
create_default_indexes => false); create_default_indexes => false);
WARNING: no index on "time" found for adaptive chunking on hypertable "test_adaptive_correct_index" WARNING: no index on "time" found for adaptive chunking on hypertable "test_adaptive_correct_index"
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
------------------------------------------ ------------------------------------------
@ -456,6 +460,7 @@ SELECT create_hypertable('test_adaptive_space', 'time', 'location', 2,
chunk_target_size => '1MB', chunk_target_size => '1MB',
create_default_indexes => true); create_default_indexes => true);
WARNING: target chunk size for adaptive chunking is less than 10 MB WARNING: target chunk size for adaptive chunking is less than 10 MB
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
---------------------------------- ----------------------------------
@ -536,6 +541,7 @@ CREATE TABLE test_adaptive_after_multiple_dims(time timestamptz, temp float, loc
SELECT create_hypertable('test_adaptive_after_multiple_dims', 'time', SELECT create_hypertable('test_adaptive_after_multiple_dims', 'time',
chunk_target_size => '100MB', chunk_target_size => '100MB',
create_default_indexes => true); create_default_indexes => true);
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
------------------------------------------------ ------------------------------------------------
@ -564,6 +570,7 @@ SELECT create_hypertable('test_adaptive', 'time',
chunk_target_size => '1MB', chunk_target_size => '1MB',
chunk_sizing_func => 'my_chunk_func_schema.calculate_chunk_interval'); chunk_sizing_func => 'my_chunk_func_schema.calculate_chunk_interval');
WARNING: target chunk size for adaptive chunking is less than 10 MB WARNING: target chunk size for adaptive chunking is less than 10 MB
NOTICE: adaptive chunking is a BETA feature and is not recommended for production deployments
NOTICE: adding not-null constraint to column "time" NOTICE: adding not-null constraint to column "time"
create_hypertable create_hypertable
---------------------------- ----------------------------