Merge ebe144b5adc23a6ac69b0907618c09d9af7f4a92 into 3a0a4dd220e074d4c3af1006b02c10defd828122

rtcp: fix FIR parsing (#3528 )
FIR RTCP packets sent by GStreamer were not handled by Janus but PLI ones are. According to https://www.rfc-editor.org/rfc/rfc5104#section-4.3.1 FIR are PSFB packets with FMT=4 so I'm now parsing them as we do with PLI.
2025-05-15 18:42:27 +08:00 · 2025-03-15 22:28:16 +03:00 · 2025-03-15 03:16:34 +01:00 · 2025-02-19 10:59:49 +01:00 · 2025-02-12 16:44:20 +01:00
3 changed files with 1676 additions and 2184 deletions
--- a/src/plugins/janus_nosip.c
+++ b/src/plugins/janus_nosip.c
--- a/src/plugins/janus_sip.c
+++ b/src/plugins/janus_sip.c
--- a/src/rtcp.c
+++ b/src/rtcp.c
@ -1154,6 +1154,12 @@ gboolean janus_rtcp_has_fir(char *packet, int len) {
 		switch(rtcp->type) {
 			case RTCP_FIR:
 				return TRUE;
+			case RTCP_PSFB: {
+				gint fmt = rtcp->rc;
+				if(fmt == 4)
+					return TRUE;
+				break;
+			}
 			default:
 				break;
 		}
Author	SHA1	Message	Date
Lorenzo Miniero	c7419fc398	Merge ebe144b5adc23a6ac69b0907618c09d9af7f4a92 into 3a0a4dd220e074d4c3af1006b02c10defd828122	2025-03-15 22:28:16 +03:00
Guillaume Desmottes	3a0a4dd220	rtcp: fix FIR parsing (#3528 ) FIR RTCP packets sent by GStreamer were not handled by Janus but PLI ones are. According to https://www.rfc-editor.org/rfc/rfc5104#section-4.3.1 FIR are PSFB packets with FMT=4 so I'm now parsing them as we do with PLI.	2025-03-15 03:16:34 +01:00
Lorenzo Miniero	ebe144b5ad	Aligned to latest changes in master	2025-02-19 10:59:49 +01:00
Lorenzo Miniero	08bb07bab8	New experimental multistream support in SIP and NoSIP plugins	2025-02-12 16:44:20 +01:00