book/rocksdb
1
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2025-06-02 18:41:22 +08:00
Code Issues Packages Projects Releases Wiki Activity
9882652b0e
rocksdb/db
History
Changyu Bi 9882652b0e Verify write batch checksum before WAL () 
Summary:
Context: WriteBatch can have key-value checksums when it was created `with protection_bytes_per_key > 0`.
This PR added checksum verification for write batches before they are written to WAL.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10114

Test Plan:
- Added new unit tests to db_kv_checksum_test.cc: `make check -j32`
- benchmark on performance regression: `./db_bench --benchmarks=fillrandom[-X20] -db=/dev/shm/test_rocksdb -write_batch_protection_bytes_per_key=8`
  - Pre-PR:
`
fillrandom [AVG    20 runs] : 198875 (± 3006) ops/sec;   22.0 (± 0.3) MB/sec
`
  - Post-PR:
`
fillrandom [AVG    20 runs] : 196487 (± 2279) ops/sec;   21.7 (± 0.3) MB/sec
`
  Mean regressed about 1% (198875 -> 196487 ops/sec).

Reviewed By: ajkr

Differential Revision: D36917464

Pulled By: cbi42

fbshipit-source-id: 29beb74edf65f04b1a890b4f650d873dc7ed790d
2022-06-15 13:43:58 -07:00
..
blob
Fix LITE build ()
2022-06-02 23:42:41 -07:00
compaction
Add unit test to verify that the dynamic priority can be passed from compaction to FS ()
2022-06-07 11:57:12 -07:00
db_impl
Verify write batch checksum before WAL ()
2022-06-15 13:43:58 -07:00
wide
Add wide column serialization primitives ()
2022-06-03 20:54:48 -07:00
arena_wrapped_db_iter.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
arena_wrapped_db_iter.h
Cleanup includes in dbformat.h ()
2021-09-29 04:04:40 -07:00
builder.cc
Consolidate manual_compaction_paused_ check ()
2022-06-06 18:32:26 -07:00
builder.h
CompactionIterator sees consistent view of which keys are committed ()
2022-04-14 11:11:04 -07:00
c_test.c
Make it possible to enable blob files starting from a certain LSM tree level ()
2022-06-02 20:04:33 -07:00
c.cc
Add blob cache option in the column family options ()
2022-06-14 14:19:26 -07:00
column_family_test.cc
Deflake column_family_test to avoid hang ()
2022-05-30 12:31:46 -07:00
column_family.cc
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
column_family.h
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
compact_files_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
comparator_db_test.cc
Document design/specification bugs with auto_prefix_mode ()
2022-06-13 11:08:50 -07:00
convenience.cc
Specify largest_seqno in VerifyChecksum ()
2022-05-02 10:22:08 -07:00
corruption_test.cc
Persist the new MANIFEST after successfully syncing the new WAL during recovery ()
2022-06-01 10:52:26 -07:00
cuckoo_table_db_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_basic_test.cc
Fix a bug in WAL tracking ()
2022-06-03 16:33:00 -07:00
db_block_cache_test.cc
Make the per-shard hash table fixed-size. ()
2022-06-13 20:29:00 -07:00
db_bloom_filter_test.cc
Rewrite memory-charging feature's option API ()
2022-05-17 15:01:51 -07:00
db_compaction_filter_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_compaction_test.cc
Support specifying blob garbage collection parameters when CompactRange() ()
2022-06-01 19:40:26 -07:00
db_dynamic_level_test.cc
Remove deprecated API AdvancedColumnFamilyOptions::soft_rate_limit/hard_rate_limit ()
2022-01-27 13:01:09 -08:00
db_encryption_test.cc
Fix a minor issue with initializing the test path ()
2021-07-23 08:38:45 -07:00
db_filesnapshot.cc
Reduce risk of backup or checkpoint missing a WAL file ()
2022-06-01 11:02:27 -07:00
db_flush_test.cc
Use std::numeric_limits<> ()
2022-05-05 13:08:21 -07:00
db_info_dumper.cc
Printing IO Error in DumpDBFileSummary ()
2022-05-04 10:19:53 -07:00
db_info_dumper.h
…
db_inplace_update_test.cc
fix a bug, c api, if enable inplace_update_support, and use create sn… ()
2022-03-21 12:04:33 -07:00
db_io_failure_test.cc
Enable a few unit tests to use custom Env objects ()
2021-11-08 11:05:59 -08:00
db_iter_stress_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_iter_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_iter.cc
Remove dead code ()
2022-04-11 10:26:55 -07:00
db_iter.h
Remove dead code ()
2022-04-11 10:26:55 -07:00
db_iterator_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_kv_checksum_test.cc
Verify write batch checksum before WAL ()
2022-06-15 13:43:58 -07:00
db_log_iter_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_logical_block_size_cache_test.cc
Attempt to deflake DBLogicalBlockSizeCacheTest.CreateColumnFamilies ()
2022-03-04 11:35:28 -08:00
db_memtable_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_merge_operand_test.cc
Fix GetMergeOperands() heap-use-after-free on flushed memtable ()
2022-04-05 12:26:36 -07:00
db_merge_operator_test.cc
Fix a minor issue with initializing the test path ()
2021-07-23 08:38:45 -07:00
db_options_test.cc
Add blob cache option in the column family options ()
2022-06-14 14:19:26 -07:00
db_properties_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_range_del_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_rate_limiter_test.cc
Address comments for PR and ()
2022-05-19 15:23:53 -07:00
db_readonly_with_timestamp_test.cc
Add timestamp support to CompactedDBImpl ()
2022-05-24 12:14:10 -07:00
db_secondary_test.cc
Fail DB::Open() if logger cannot be created ()
2022-05-27 07:23:31 -07:00
db_sst_test.cc
Pass the size of blob files to SstFileManager during DB open ()
2022-05-27 05:58:43 -07:00
db_statistics_test.cc
Bytes read stat for VerifyChecksum() and VerifyFileChecksums() APIs ()
2021-09-07 13:28:29 -07:00
db_table_properties_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_tailing_iter_test.cc
Fix a minor issue with initializing the test path ()
2021-07-23 08:38:45 -07:00
db_test2.cc
Document design/specification bugs with auto_prefix_mode ()
2022-06-13 11:08:50 -07:00
db_test_util.cc
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
db_test_util.h
Explicitly closing all directory file descriptors ()
2022-06-01 18:03:34 -07:00
db_test.cc
Fix potential leak when reusing PinnableSlice instances. ()
2022-06-14 21:29:52 -07:00
db_universal_compaction_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
db_wal_test.cc
Bypass tests instead of skipping to resolve internal failure ()
2022-06-12 12:05:11 -07:00
db_with_timestamp_basic_test.cc
Return try again when full_history_ts_low is higher than requested ts ()
2022-06-10 08:21:08 -07:00
db_with_timestamp_compaction_test.cc
Use the comparator from the sst file table properties in sst_dump_tool ()
2022-02-08 12:15:35 -08:00
db_with_timestamp_test_util.cc
Add timestamp support to DBImplReadOnly ()
2022-05-19 18:39:41 -07:00
db_with_timestamp_test_util.h
Add timestamp support to DBImplReadOnly ()
2022-05-19 18:39:41 -07:00
db_write_buffer_manager_test.cc
Enable a few unit tests to use custom Env objects ()
2021-11-08 11:05:59 -08:00
db_write_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
dbformat_test.cc
Enable a few unit tests to use custom Env objects ()
2021-11-08 11:05:59 -08:00
dbformat.cc
Track per-SST user-defined timestamp information in MANIFEST ()
2021-11-10 10:49:04 -08:00
dbformat.h
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
deletefile_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
error_handler_fs_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
error_handler.cc
Expand auto recovery to background read errors ()
2022-03-15 14:45:34 -07:00
error_handler.h
Expand auto recovery to background read errors ()
2022-03-15 14:45:34 -07:00
event_helpers.cc
Fix a race condition in WAL tracking causing DB open failure ()
2022-03-23 19:41:31 -07:00
event_helpers.h
Add a listener callback for end of auto error recovery ()
2021-12-08 14:30:57 -08:00
experimental.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
external_sst_file_basic_test.cc
Fix unittest ExternalSSTFileBasicTest.StableSnapshotWhileLoggingToManifest ()
2022-05-31 08:48:57 -07:00
external_sst_file_ingestion_job.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
external_sst_file_ingestion_job.h
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
external_sst_file_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
fault_injection_test.cc
Fix a bug causing duplicate trailing entries in WritableFile (buffered IO) ()
2021-12-13 09:00:36 -08:00
file_indexer_test.cc
…
file_indexer.cc
…
file_indexer.h
Use std::numeric_limits<> ()
2022-05-05 13:08:21 -07:00
filename_test.cc
fixing issue RocksDB does not work when using UNC network paths ()
2022-03-30 15:55:31 -07:00
flush_job_test.cc
Set Write rate limiter priority dynamically and pass it to FS ()
2022-05-18 00:41:41 -07:00
flush_job.cc
Consolidate manual_compaction_paused_ check ()
2022-06-06 18:32:26 -07:00
flush_job.h
Set Write rate limiter priority dynamically and pass it to FS ()
2022-05-18 00:41:41 -07:00
flush_scheduler.cc
…
flush_scheduler.h
…
forward_iterator_bench.cc
Remove using namespace ()
2022-01-12 09:31:12 -08:00
forward_iterator.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
forward_iterator.h
Fast path for detecting unchanged prefix_extractor ()
2022-01-21 11:37:46 -08:00
history_trimming_iterator.h
Add OpenAndTrimHistory API to support trimming data with specified timestamp ()
2022-03-11 16:13:23 -08:00
import_column_family_job.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
import_column_family_job.h
New stable, fixed-length cache keys ()
2021-12-16 17:15:13 -08:00
import_column_family_test.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
internal_stats.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
internal_stats.h
Expose the amount of garbage in live blob files as a dedicated DB property ()
2022-04-13 13:36:30 -07:00
job_context.h
CompactionIterator sees consistent view of which keys are committed ()
2022-04-14 11:11:04 -07:00
kv_checksum.h
fix compile errors in db/kv_checksum.h ()
2021-11-16 10:20:50 -08:00
listener_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
log_format.h
Add record to set WAL compression type if enabled ()
2022-02-17 16:19:31 -08:00
log_reader.cc
Support read rate-limiting in SequentialFileReader ()
2022-05-24 10:28:57 -07:00
log_reader.h
Fix bug for WalManager with compressed WAL ()
2022-06-08 14:16:43 -07:00
log_test.cc
Integrate WAL compression into log reader/writer. ()
2022-03-09 15:49:53 -08:00
log_writer.cc
Integrate WAL compression into log reader/writer. ()
2022-03-09 15:49:53 -08:00
log_writer.h
Integrate WAL compression into log reader/writer. ()
2022-03-09 15:49:53 -08:00
logs_with_prep_tracker.cc
…
logs_with_prep_tracker.h
…
lookup_key.h
Cleanup includes in dbformat.h ()
2021-09-29 04:04:40 -07:00
malloc_stats.cc
Replace most typedef with using= ()
2021-09-07 11:31:59 -07:00
malloc_stats.h
…
manual_compaction_test.cc
Remove using namespace ()
2022-01-12 09:31:12 -08:00
memtable_list_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
memtable_list.cc
Encode min_log_number_to_keep and delete_wals_before in one version edit ()
2022-03-31 20:00:52 -07:00
memtable_list.h
Fix various spelling errors still found in code ()
2022-05-05 19:45:32 -07:00
memtable.cc
Point-lookup returns timestamps of Delete and SingleDelete ()
2022-06-03 20:00:42 -07:00
memtable.h
Meta-internal folly integration with F14FastMap ()
2022-04-13 07:34:01 -07:00
merge_context.h
…
merge_helper_test.cc
Support readahead during compaction for blob files ()
2021-11-19 17:53:47 -08:00
merge_helper.cc
Support readahead during compaction for blob files ()
2021-11-19 17:53:47 -08:00
merge_helper.h
Support readahead during compaction for blob files ()
2021-11-19 17:53:47 -08:00
merge_operator.cc
…
merge_test.cc
Make the Env class Customizable ()
2022-01-04 16:45:49 -08:00
obsolete_files_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
options_file_test.cc
…
output_validator.cc
Cleanup includes in dbformat.h ()
2021-09-29 04:04:40 -07:00
output_validator.h
Cleanup includes in dbformat.h ()
2021-09-29 04:04:40 -07:00
perf_context_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
periodic_work_scheduler_test.cc
Fix a minor issue with initializing the test path ()
2021-07-23 08:38:45 -07:00
periodic_work_scheduler.cc
Fix a timer crash caused by invalid memory management ()
2022-03-12 11:45:56 -08:00
periodic_work_scheduler.h
Fix a timer crash caused by invalid memory management ()
2022-03-12 11:45:56 -08:00
pinned_iterators_manager.h
Replace most typedef with using= ()
2021-09-07 11:31:59 -07:00
plain_table_db_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
post_memtable_callback.h
Snapshots with user-specified timestamps ()
2022-06-10 16:07:03 -07:00
pre_release_callback.h
Fix and detect headers with missing dependencies ()
2021-09-10 10:00:26 -07:00
prefix_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
range_del_aggregator_bench.cc
Cleanup multiple implementations of VectorIterator ()
2021-10-06 07:48:31 -07:00
range_del_aggregator_test.cc
Cleanup multiple implementations of VectorIterator ()
2021-10-06 07:48:31 -07:00
range_del_aggregator.cc
…
range_del_aggregator.h
…
range_tombstone_fragmenter_test.cc
Cleanup multiple implementations of VectorIterator ()
2021-10-06 07:48:31 -07:00
range_tombstone_fragmenter.cc
…
range_tombstone_fragmenter.h
…
read_callback.h
Fix and detect headers with missing dependencies ()
2021-09-10 10:00:26 -07:00
repair_test.cc
Fix failed VerifySstUniqueIds unittests ()
2022-05-24 09:00:06 -07:00
repair.cc
Support read rate-limiting in SequentialFileReader ()
2022-05-24 10:28:57 -07:00
snapshot_checker.h
Use STATIC_AVOID_DESTRUCTION for static objects with non-trivial destructors ()
2022-05-17 09:39:22 -07:00
snapshot_impl.cc
…
snapshot_impl.h
Snapshots with user-specified timestamps ()
2022-06-10 16:07:03 -07:00
table_cache_sync_and_async.h
Multi file concurrency in MultiGet using coroutines and async IO ()
2022-05-19 15:36:27 -07:00
table_cache.cc
Fix crash due to MultiGet async IO and direct IO ()
2022-05-20 12:38:21 -07:00
table_cache.h
Multi file concurrency in MultiGet using coroutines and async IO ()
2022-05-19 15:36:27 -07:00
table_properties_collector_test.cc
Improve / clean up meta block code & integrity ()
2021-11-18 11:43:44 -08:00
table_properties_collector.cc
…
table_properties_collector.h
Track each SST's timestamp information as user properties ()
2021-11-19 11:37:06 -08:00
transaction_log_impl.cc
Support read rate-limiting in SequentialFileReader ()
2022-05-24 10:28:57 -07:00
transaction_log_impl.h
Add checks to GetUpdatesSince ()
2022-04-14 17:12:16 -07:00
trim_history_scheduler.cc
…
trim_history_scheduler.h
…
version_builder_test.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
version_builder.cc
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_builder.h
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_edit_handler.cc
Fix a race condition in WAL tracking causing DB open failure ()
2022-03-23 19:41:31 -07:00
version_edit_handler.h
…
version_edit_test.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
version_edit.cc
Track SST unique id in MANIFEST and verify ()
2022-05-19 11:04:21 -07:00
version_edit.h
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_set_sync_and_async.h
Multi file concurrency in MultiGet using coroutines and async IO ()
2022-05-19 15:36:27 -07:00
version_set_test.cc
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_set.cc
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_set.h
Account memory of FileMetaData in global memory limit ()
2022-06-14 13:06:40 -07:00
version_util.h
Add manifest fix-up utility for file temperatures ()
2022-03-18 16:35:51 -07:00
wal_edit_test.cc
…
wal_edit.cc
…
wal_edit.h
Use std::numeric_limits<> ()
2022-05-05 13:08:21 -07:00
wal_manager_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
wal_manager.cc
Fix bug for WalManager with compressed WAL ()
2022-06-08 14:16:43 -07:00
wal_manager.h
Fix bug for WalManager with compressed WAL ()
2022-06-08 14:16:43 -07:00
write_batch_base.cc
…
write_batch_internal.h
Verify write batch checksum before WAL ()
2022-06-15 13:43:58 -07:00
write_batch_test.cc
Remove own ToString() ()
2022-05-06 13:03:58 -07:00
write_batch.cc
Verify write batch checksum before WAL ()
2022-06-15 13:43:58 -07:00
write_callback_test.cc
…
write_callback.h
…
write_controller_test.cc
…
write_controller.cc
…
write_controller.h
Set Write rate limiter priority dynamically and pass it to FS ()
2022-05-18 00:41:41 -07:00
write_thread.cc
Verify write batch checksum before WAL ()
2022-06-15 13:43:58 -07:00
write_thread.h
Snapshots with user-specified timestamps ()
2022-06-10 16:07:03 -07:00