apple/swift-nio-extras
1
0
Fork 0
mirror of https://github.com/apple/swift-nio-extras.git synced 2025-05-14 08:52:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change to units tests for LengthFieldPrepender class to raise exceptions when errors are thrown.

Browse Source 
Motivation:
To ensure that failing tests flag more accurately.

Modifications:
Added AssetNoThrow around calls in tests that can throw.

Result:
Tests flag more accurately and at the source of the problem.
This commit is contained in:
Liam 2018-12-13 19:49:35 +00:00
parent 343428c4e0
commit f8be8ea534
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
Tests/NIOExtrasTests/LengthFieldPrependerTest.swift
View File

@ -33,14 +33,14 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .one,
lengthFieldEndianness: .little)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
let dataBytes: [UInt8] = [10, 20, 30, 40]
var buffer = self.channel.allocator.buffer(capacity: dataBytes.count)
buffer.write(bytes: dataBytes)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var headerBuffer)) = self.channel.readOutbound() {
@ -71,12 +71,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .two,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -113,12 +113,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .four,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -155,12 +155,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -194,12 +194,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -236,12 +236,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -275,12 +275,12 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
var buffer = self.channel.allocator.buffer(capacity: standardDataStringCount)
buffer.write(string: standardDataString)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -317,11 +317,11 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
let buffer = self.channel.allocator.buffer(capacity: 0)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -351,14 +351,14 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .eight,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
let contents = Array<UInt8>(repeating: 200, count: 514)
var buffer = self.channel.allocator.buffer(capacity: contents.count)
buffer.write(bytes: contents)
try self.channel.writeAndFlush(buffer).wait()
XCTAssertNoThrow(try self.channel.writeAndFlush(buffer).wait())
if case .some(.byteBuffer(var outputBuffer)) = self.channel.readOutbound() {
@ -393,7 +393,7 @@ class LengthFieldPrependerTest: XCTestCase {
self.encoderUnderTest = LengthFieldPrepender(lengthFieldLength: .one,
lengthFieldEndianness: endianness)
try? self.channel.pipeline.add(handler: self.encoderUnderTest).wait()
XCTAssertNoThrow(try self.channel.pipeline.add(handler: self.encoderUnderTest).wait())
let contents = Array<UInt8>(repeating: 200, count: 300)