mirror of
https://github.com/apple/swift-foundation.git
synced 2025-05-22 21:40:04 +08:00
* rdar://108152217 Start using Rope for attribute run storage - Replace `Array<_InternalRun>` with `Rope<_InternalRun>`. - Fix semantics of AttributeRunBoundaries.character. It no longer pretends that attributes can be tied to grapheme clusters — that never actually worked properly, and it cannot be supported without breaking the intended use case. - Remove cache of latest run position; log(n) might be fast enough that we don’t need to worry about that. - Switch AttributedString.Guts members to take/return BigString.Index values, not AttributedString indices. This cuts down on constant back-and-forth conversions. - Discard unused Guts members; update remaining mutation methods to follow Swift naming conventions. - Stop using the `public extension` language misfeature. * rdar://108152217 Apply notes from code review AttributedString.CharacterView and AttributedString.UnicodeScalarView did not use the right semantics in the case when the underlying text was not touched. It’s okay in that case to not mutate text storage, but we still want to override the attributes within the subrange as if the client actually did replace text — as in, we want to use precisely the same attribute storage for the range on both paths. Also, make sure we correctly enforce attribute constraints in the `!hasStringChanges` case, in both views. * rdar://108152217 Fix logic error in AttributedString.Runs.subscript (Discovered during code review.) * rdar://108152217 Clean up CharacterView/UnicodeScalarView mutations & update failing test * rdar://108152217 Apply review notes
262 lines
9.2 KiB
Swift
262 lines
9.2 KiB
Swift
//===----------------------------------------------------------------------===//
|
||
//
|
||
// This source file is part of the Swift.org open source project
|
||
//
|
||
// Copyright (c) 2020 Apple Inc. and the Swift project authors
|
||
// Licensed under Apache License v2.0 with Runtime Library Exception
|
||
//
|
||
// See https://swift.org/LICENSE.txt for license information
|
||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
||
//
|
||
//===----------------------------------------------------------------------===//
|
||
|
||
#if FOUNDATION_FRAMEWORK
|
||
@_implementationOnly @_spi(Unstable) import CollectionsInternal
|
||
#else
|
||
package import _RopeModule
|
||
#endif
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString {
|
||
internal struct _AttributeValue : Hashable, CustomStringConvertible, Sendable {
|
||
typealias RawValue = any Sendable & Hashable
|
||
let rawValue: RawValue
|
||
|
||
// FIXME: If these are always tied to keys, then why are we caching these
|
||
// FIXME: on each individual value? Move them to a separate
|
||
// FIXME: dictionary inside each attributed string -- or even a
|
||
// FIXME: global one.
|
||
let runBoundaries: AttributeRunBoundaries?
|
||
let inheritedByAddedText: Bool
|
||
let invalidationConditions: Set<AttributeInvalidationCondition>?
|
||
|
||
var description: String { String(describing: rawValue) }
|
||
|
||
init<K: AttributedStringKey>(_ value: K.Value, for key: K.Type) where K.Value : Sendable {
|
||
rawValue = value
|
||
runBoundaries = K.runBoundaries
|
||
inheritedByAddedText = K.inheritedByAddedText
|
||
invalidationConditions = K.invalidationConditions
|
||
}
|
||
|
||
private init<K: AttributedStringKey>(checkingValue value: RawValue, for key: K.Type) where K.Value : Sendable {
|
||
guard let trueValue = value as? K.Value else {
|
||
fatalError("\(#function) called with non-matching attribute value type")
|
||
}
|
||
self.init(trueValue, for: K.self)
|
||
}
|
||
|
||
var isInvalidatedOnTextChange: Bool {
|
||
invalidationConditions?.contains(.textChanged) ?? false
|
||
}
|
||
|
||
var isInvalidatedOnAttributeChange: Bool {
|
||
invalidationConditions?.contains { $0.isAttribute } ?? false
|
||
}
|
||
|
||
func isInvalidatedOnChange(of attributeKey: String) -> Bool {
|
||
let condition: AttributeInvalidationCondition = .attributeChanged(attributeKey)
|
||
return invalidationConditions?.contains { $0 == condition } ?? false
|
||
}
|
||
|
||
static func wrapIfPresent<K: AttributedStringKey>(_ value: K.Value?, for key: K.Type) -> Self? where K.Value : Sendable {
|
||
guard let value = value else { return nil }
|
||
return Self(value, for: K.self)
|
||
}
|
||
|
||
func rawValue<K: AttributedStringKey>(
|
||
as key: K.Type
|
||
) -> K.Value where K.Value: Sendable {
|
||
rawValue as! K.Value
|
||
}
|
||
|
||
static func ==(lhs: Self, rhs: Self) -> Bool {
|
||
Self.__equalAttributes(lhs.rawValue, rhs.rawValue)
|
||
}
|
||
|
||
func hash(into hasher: inout Hasher) {
|
||
rawValue.hash(into: &hasher)
|
||
}
|
||
|
||
private static func __equalAttributes(_ lhs: RawValue?, _ rhs: RawValue?) -> Bool {
|
||
switch (lhs, rhs) {
|
||
case (.none, .none):
|
||
return true
|
||
case (.none, .some(_)):
|
||
return false
|
||
case (.some(_), .none):
|
||
return false
|
||
case (.some(let lhs), .some(let rhs)):
|
||
func openEquatable<LHS: Equatable>(_ equatableLHS: LHS) -> Bool {
|
||
if let equatableRHS = rhs as? LHS {
|
||
return equatableLHS == equatableRHS
|
||
} else {
|
||
return false
|
||
}
|
||
}
|
||
return openEquatable(lhs)
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
internal extension Dictionary where Key == String, Value == AttributedString._AttributeValue {
|
||
var _attrStrDescription : String {
|
||
let keyvals = self.reduce(into: "") { (res, entry) in
|
||
res += "\t\(entry.key) = \(entry.value)\n"
|
||
}
|
||
return "{\n\(keyvals)}"
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString {
|
||
internal struct _AttributeStorage: Hashable, Sendable {
|
||
internal typealias AttributeMergePolicy = AttributedString.AttributeMergePolicy
|
||
internal typealias _AttributeValue = AttributedString._AttributeValue
|
||
|
||
private(set) var contents : [String : _AttributeValue]
|
||
|
||
/// The set of keys in this container that need to invalidated
|
||
/// when some particular key changes.
|
||
///
|
||
/// FIXME: We do not need to cache this. Remove it.
|
||
private var invalidatableKeys : Set<String>
|
||
|
||
init() {
|
||
self.contents = [:]
|
||
self.invalidatableKeys = []
|
||
}
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString._AttributeStorage: CustomStringConvertible {
|
||
var description: String {
|
||
contents._attrStrDescription
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString._AttributeStorage {
|
||
var isEmpty: Bool {
|
||
contents.isEmpty
|
||
}
|
||
|
||
var keys: Dictionary<String, _AttributeValue>.Keys {
|
||
contents.keys
|
||
}
|
||
|
||
func matches(_ other: Self) -> Bool {
|
||
for (key, value) in other.contents {
|
||
if self[key] != value {
|
||
return false
|
||
}
|
||
}
|
||
return true
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString._AttributeStorage {
|
||
internal func isEqual(to other: Self, comparing attributes: [String]) -> Bool {
|
||
assert(!attributes.isEmpty)
|
||
for name in attributes {
|
||
if self[name] != other[name] {
|
||
return false
|
||
}
|
||
}
|
||
return true
|
||
}
|
||
}
|
||
|
||
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
|
||
extension AttributedString._AttributeStorage {
|
||
func attributesForAddedText() -> Self {
|
||
var storage = Self()
|
||
storage.contents = contents.filter {
|
||
$0.value.inheritedByAddedText && !$0.value.isInvalidatedOnTextChange
|
||
}
|
||
// FIXME: Why not set `invalidatableKeys` here?
|
||
return storage
|
||
}
|
||
|
||
private mutating func _attributeModified(_ key: String, old: _AttributeValue?, new: _AttributeValue?) {
|
||
guard old != nil || new != nil else { return } // Shortcut for nil -> nil modification
|
||
|
||
// Update invalidatableKeys list
|
||
if new?.isInvalidatedOnAttributeChange ?? false {
|
||
invalidatableKeys.insert(key)
|
||
} else {
|
||
invalidatableKeys.remove(key)
|
||
}
|
||
|
||
guard old != new else { return }
|
||
|
||
for k in invalidatableKeys {
|
||
guard k != key else { continue }
|
||
guard let value = contents[k] else { continue }
|
||
guard value.isInvalidatedOnChange(of: key) else { continue }
|
||
// FIXME: ☠️ This subscript assignment is recursively calling this same method.
|
||
// FIXME: Collect invalidated keys into a temporary set instead, and progressively
|
||
// FIXME: extend that set until all its keys are gone.
|
||
self[k] = nil
|
||
}
|
||
}
|
||
|
||
subscript <T: AttributedStringKey>(_ attribute: T.Type) -> T.Value? where T.Value : Sendable {
|
||
get { self[T.name]?.rawValue(as: T.self) }
|
||
set { self[T.name] = .wrapIfPresent(newValue, for: T.self) }
|
||
}
|
||
|
||
subscript (_ attributeName: String) -> _AttributeValue? {
|
||
get { self.contents[attributeName] }
|
||
set {
|
||
let oldValue: _AttributeValue?
|
||
if let newValue {
|
||
oldValue = self.contents.updateValue(newValue, forKey: attributeName)
|
||
} else {
|
||
oldValue = self.contents.removeValue(forKey: attributeName)
|
||
}
|
||
_attributeModified(attributeName, old: oldValue, new: newValue)
|
||
}
|
||
}
|
||
|
||
internal mutating func mergeIn(_ other: Self, mergePolicy: AttributeMergePolicy = .keepNew) {
|
||
for (key, value) in other.contents {
|
||
switch mergePolicy {
|
||
case .keepNew:
|
||
self[key] = value
|
||
case .keepCurrent:
|
||
if !contents.keys.contains(key) {
|
||
self[key] = value
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
internal mutating func mergeIn(_ other: AttributeContainer, mergePolicy: AttributeMergePolicy = .keepNew) {
|
||
self.mergeIn(other.storage, mergePolicy: mergePolicy)
|
||
}
|
||
|
||
/// Note: This is intentionally not doing recursive removal of attributes that have a
|
||
/// `attributeChanged` constrained on one of the filtered out keys.
|
||
func filterWithoutInvalidatingDependents(
|
||
_ isIncluded: (Dictionary<String, _AttributeValue>.Element) -> Bool
|
||
) -> Self {
|
||
var storage = Self()
|
||
storage.contents = self.contents.filter(isIncluded)
|
||
storage.invalidatableKeys = self.invalidatableKeys
|
||
return storage
|
||
}
|
||
|
||
func contains(_ attributeName: String) -> Bool {
|
||
contents.keys.contains(attributeName)
|
||
}
|
||
|
||
func contains<K: AttributedStringKey>(_ key: K.Type) -> Bool {
|
||
contains(K.name)
|
||
}
|
||
}
|