7696 Commits

Author SHA1 Message Date
Evan Tschannen
93b87e37a7 updated documentation for 6.1.13 2020-04-24 11:47:35 -07:00
Evan Tschannen
c0d549511a
Merge pull request #3014 from etschannen/post-release-cleanup-6.2.20
Post release cleanup 6.2.20
2020-04-23 13:22:01 -07:00
Evan Tschannen
44cf59ca81 update installer WIX GUID following release 2020-04-23 13:16:46 -07:00
Evan Tschannen
8eef766546 update version to 6.2.21 2020-04-23 13:16:46 -07:00
Evan Tschannen
77b5171e81
Merge pull request #3012 from etschannen/release-6.2
updated documentation for 6.2.20
6.2.20
2020-04-23 11:20:44 -07:00
Evan Tschannen
010592a415 updated documentation for 6.2.20 2020-04-23 10:59:28 -07:00
Evan Tschannen
76d4570d5d
Merge pull request #3008 from etschannen/release-6.2
Added logging for parallel peeks from TLogs
2020-04-23 10:27:49 -07:00
Evan Tschannen
a835123680 exit fdbserver after a ReceiverError, because a packet which should be delivered will never be received 2020-04-22 23:38:46 -07:00
Evan Tschannen
37f9456010 added logging when encountering an inverted range 2020-04-22 23:37:29 -07:00
Evan Tschannen
810bba2067 cleanup calls to FlowTransport::isClient() 2020-04-22 23:36:40 -07:00
Evan Tschannen
91fba9106d ported peek metrics to old tlog 6.0 2020-04-22 23:35:48 -07:00
A.J. Beamon
90d29dd432
Merge pull request #2993 from alexmiller-apple/tls-permission-errors
Match 6.2.15's behavior in how invalid/unreadable/non-existent certs are handled.
2020-04-22 16:54:18 -07:00
Evan Tschannen
0a1b2a572f more compile fixes 2020-04-22 14:41:17 -07:00
A.J. Beamon
ed54913973
Merge pull request #2976 from atn34/atn34/thread-local
Prevent main thread from destroying flatbuffers globals
2020-04-22 14:36:51 -07:00
Evan Tschannen
68906bf3c3 fix compile errors 2020-04-22 14:36:41 -07:00
Alex Miller
22fc77480f Merge remote-tracking branch 'upstream/release-6.2' into tls-permission-errors 2020-04-22 14:33:33 -07:00
Evan Tschannen
dfb0593ae6 increases priority of status requests 2020-04-22 14:24:59 -07:00
Evan Tschannen
d0cc2a1ee4 added logging for parallel peeks on TLogs 2020-04-22 14:24:45 -07:00
A.J. Beamon
58fbd0e3a1
Merge pull request #2980 from alexmiller-apple/tls-background-eio-thread
Stop background eio threads on Net2::stop()
2020-04-22 08:17:59 -07:00
Alex Miller
c6df20a179
Use nullptr instead of NULL 2020-04-21 20:39:45 -07:00
Alex Miller
8b004fe8e3 Move stop callbacks to be called after run() in sim2. 2020-04-21 20:22:16 -07:00
Alex Miller
a51746b307 Match 6.2.15's behavior in how invalid/unreadable/non-existent certs are handled.
Which is to proceed past Net2 creation, and allow certificate refresh to
try and eventually load valid certs.  Additionally, fix certificate
refeshing dieing if the certificate is not readable when first called.

In testing, I also found and fixed an issue where if a cert went from
unreadable to readable, we wouldn't reload the TLS context, due to not
considering it as a file change.
2020-04-20 21:38:04 -07:00
Alex Miller
20fe068863 Merge branch 'tls-background-eio-thread' into tls-permission-errors 2020-04-20 20:51:05 -07:00
Xin Dong
49c6bb90ef
Merge pull request #2982 from alexmiller-apple/tls-log-settings
Log Net2TLSConfig with paths and settings when using TLS.
2020-04-20 15:46:26 -07:00
Alex Miller
75a4f3b7c9 Remove comment about ignoring runOnMainThread errors.
If we got an exception, it wouldn't be of type `Error` anyway, so
it seems like things would crash regardless.
2020-04-20 13:19:42 -07:00
Alex Miller
e51d0365cf Cleanup: Use the shutdown callback for destroying TLS state. 2020-04-20 13:16:16 -07:00
Alex Miller
da8e47ea25 Merge remote-tracking branch 'upstream/release-6.2' into tls-background-eio-thread 2020-04-20 13:15:05 -07:00
Alex Miller
5c399bf725 Move the callbacks into ::run() right before it exits.
stopped=true doesn't cause the run loop to immediately exit.
2020-04-20 13:14:19 -07:00
A.J. Beamon
c28a843251
Merge pull request #2977 from alexmiller-apple/tls-no-atexit
Fix clients crashing in TLS code on exit.
2020-04-20 08:40:16 -07:00
Alex Miller
2ce539ef6d Respect flow<->fdbrpc module boundaries.
Which fixes a compilation error due to a circular dependency between
flow.a and fdbrpc.a.  However, this is now done at the cost of newNet2
users have to remember to add Net2FileSystem::stop() as a callback.
2020-04-20 02:53:07 -07:00
Xin Dong
c09f659fd5
Merge pull request #2983 from alexmiller-apple/tls-whichmeans-on-tls-error
Only log OpenSSL error strings for OpenSSL errors.
2020-04-19 12:57:11 -07:00
Alex Miller
cbb6ffb431 Only log OpenSSL error strings for OpenSSL errors.
Normal "connection refused" messages would show up with a long verbose
string that doesn't really provide any useful information otherwise.
2020-04-18 20:39:02 -07:00
Alex Miller
11eebc4a48 Log Net2TLSConfig with paths and settings when using TLS.
There were similar TraceEvents in the FDBLibTLS/LibreSSL TLS
implementaiton that were accidentally dropped in the TLS rewrite.

This makes it so that one does not have to use magic to figure out if a
process was configued with TLS correctly when some of the settings come
from environment variables.
2020-04-18 20:21:10 -07:00
Alex Miller
1398e9a82e Stop background eio threads on Net2::stop().
This will stop eio threads for both the client (`fdb_stop_network()`)
and the server.  This change is being done more for the former, but I
don't see any harm in doing the latter as well.
2020-04-18 19:40:55 -07:00
Alex Miller
94b4f78ea9 Fix clients crashing in TLS code on exit.
If client code initiates an FDB operation to a TLS cluster, and then
immediately exits the main thread, then OpenSSL's atexit handler would
potentially run while the network thread is attempting to do TLS
operations, and thus crash.

This commit removes the OpenSSL atexit hander, and instead relies on a
client intentionally ending the network thread to do TLS cleanup.  If
the client code exits without stopping the network thread, then we'll
never free OpenSSL data structures, which is the safer thing to do.
2020-04-18 15:48:02 -07:00
Andrew Noyes
cb6389d42d Prevent main thread from destroying flatbuffers globals
We recently witnessed (using tsan) the main thread exiting without first
joining the network thread, and this caused data races and
heap-use-after-free's

Now the lifetime of these globals will be tied to the network thread
itself (and I guess every thread, but the one that actually uses memory
will be owned by the network thread.)
2020-04-17 23:34:28 +00:00
Evan Tschannen
b5d7780293
Merge pull request #2849 from ajbeamon/remove-internal-tools-from-client-list
Don't include internal tools in the status client list
2020-04-14 16:49:30 -07:00
Balachandar Namasivayam
8b0f1813d4
Merge pull request #2920 from ajbeamon/backport-api-version-630-change
Including port in addresses option is deprecated in 630 rather than 700
2020-04-08 21:03:40 -07:00
A.J. Beamon
c11b9d0721 Including port in addresses option is deprecated in 630 rather than 700. Includes other latent generated go changes to the documentation. 2020-04-07 08:51:15 -07:00
Alex Miller
4d5b8ac5cb
Merge pull request #2894 from ajbeamon/fix-trace-event-message-types
Fix boost error trace event fields to match other trace events by the same name
2020-04-01 11:35:22 -07:00
A.J. Beamon
903128a36f Fix boost error trace event fields to match other trace events by the same name. 2020-04-01 08:18:50 -07:00
A.J. Beamon
69382e2442
Merge pull request #2889 from jzhou77/doc-6.2
Add documentation of get_approximate_size for Python, Ruby, and Go
2020-03-31 13:45:46 -07:00
Jingyu Zhou
ae480c14a3 Add documentation of get_approximate_size for Python, Ruby, and Go
This was missed from original PR #1756, where only C API was documented.
2020-03-31 13:42:02 -07:00
A.J. Beamon
197f866824 Don't include internal tools such as fdbcli, backup, and DR in the status client list. 2020-03-23 14:44:04 -07:00
A.J. Beamon
a484cc97f4
Merge pull request #2830 from atn34/atn34/dump-core
Dump core from custom signal handler
2020-03-23 08:52:08 -07:00
Andrew Noyes
c0bae64105 Use sigaction, _exit if anything fails 2020-03-20 12:50:31 -07:00
Andrew Noyes
bed5d4733a Fix syntax 2020-03-18 11:00:02 -07:00
Andrew Noyes
0d4f49f02f Run default signal handler after custom signal handler 2020-03-18 10:54:47 -07:00
Evan Tschannen
2853c5963f
Merge pull request #2825 from etschannen/post-release-cleanup-6.2.19
Post release cleanup 6.2.19
2020-03-18 10:18:00 -07:00
Evan Tschannen
29f16630f5 update installer WIX GUID following release 2020-03-17 11:47:51 -07:00