43 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard
a71099471b Update copyright header dates 2022-03-21 13:36:23 -07:00
sfc-gh-tclinkenbeard
b9a22a61ef Fix many -Wreorder-ctor warnings 2021-07-23 17:33:18 -07:00
FDB Formatster
df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Young Liu
8cc3e4d3c6 Merge release-6.3 into master 2020-10-19 22:51:56 -07:00
Jingyu Zhou
8f17a1a5d6 Merge branch 'release-6.2' into release-6.3 2020-10-16 15:25:39 -07:00
sfc-gh-tclinkenbeard
91a8367acb Avoid slow task in ~DataDistributionTracker 2020-10-01 11:44:55 -07:00
Andrew Noyes
f470ba8316 Remove using namespace std::rel_ops
This causes the following to not compile anymore

\#include <utility>
\#include <vector>

using namespace std::rel_ops;

int main() {
    std::vector<int> xs;
    return xs.rbegin() != xs.rend();
}

See https://godbolt.org/z/s1977n
2020-07-10 22:58:15 +00:00
sfc-gh-tclinkenbeard
7a28ace7eb Mark IKeyValueContainer::getElementBytes constexpr 2020-06-17 18:20:44 -07:00
sfc-gh-tclinkenbeard
99bf993815 Replace BOOST_NOEXCEPT with noexcept 2020-06-09 22:39:19 -07:00
tclinken
9d1d83640c Update return type for const_iterator::getKey and const_iterator::getValue 2020-05-17 17:30:07 -07:00
tclinken
3399f566db Fixed MacOS build 2020-05-17 17:29:59 -07:00
tclinken
c054b47150 Fixed IndexedSet::getMetric 2020-05-17 12:13:49 -07:00
tclinken
e16ec8beca Added cbegin and cend to IndexedSet
Also fixed/improved /flow/IndexedSet/const_iterator test
2020-05-16 18:50:00 -07:00
tclinken
e58698d6f7 Added IndexedSet::previous(iterator) const 2020-05-16 18:38:04 -07:00
tclinken
cbfe380b1d s/NULL/nullptr in IndexedSet.h 2020-05-16 18:38:03 -07:00
tclinken
8f883591d4 Renamed _moveIterator to moveIteratorImpl 2020-05-16 18:38:03 -07:00
tclinken
dc11fb6b01 Removed IndexedSet::Impl::end 2020-05-16 18:38:03 -07:00
tclinken
52cb766b17 Renamed IndexedSet::IteratorImpl::i to IndexedSet::IteratorImpl::node 2020-05-16 18:38:02 -07:00
tclinken
d9124abb02 Avoid implicit conversion from iterator to const_iterator 2020-05-16 18:38:02 -07:00
tclinken
9c9b56b8b1 Avoid implicit conversion from Node* to iterator 2020-05-16 18:38:02 -07:00
tclinken
864ddd316f Removed duplicate IndexedSet::moveIterator code 2020-05-16 18:38:02 -07:00
tclinken
e11ba12da7 Added IndexedSet::ConstImpl and IndexedSet::NonConstImpl 2020-05-16 18:38:02 -07:00
tclinken
84cfafe164 Added IndexedSet::const_iterator 2020-05-16 18:38:01 -07:00
Russell Sears
4098f3f48e pr comment 2020-05-07 17:22:04 -07:00
Russell Sears
42950eba91 fix two correctness bugs in the comparison logic 2020-05-07 15:50:40 -07:00
Russell Sears
945daf980d fix clang build 2020-05-07 12:09:40 -07:00
Russell Sears
1f102f7e16 pr comment: restore assert 2020-05-07 12:09:09 -07:00
Russell Sears
5e1c43f87b replace double invocations of operator<() with three way compare(). 2020-05-07 12:08:29 -07:00
Russell Sears
99a805517e reduce the number of calls to operator< made by lower_bound and upper_bound #2877 2020-05-07 12:08:21 -07:00
A.J. Beamon
8125096e9b
Revert "reduce the number of calls to operator< made by lower_bound and upper…" 2020-05-05 08:17:10 -07:00
Russell Sears
7459fad141 pr comment: restore assert 2020-04-29 10:10:30 -07:00
Russell Sears
dcdda88794 replace double invocations of operator<() with three way compare(). 2020-04-29 10:10:30 -07:00
Russell Sears
0115d94e7b reduce the number of calls to operator< made by lower_bound and upper_bound #2877 2020-04-29 10:10:30 -07:00
mengranwo
115ff8bf65 change getKey() interface, pass in uint8_t * only 2020-01-15 13:49:45 -08:00
mengranwo
f597aa7e18 WIP : deployable/stable version since Nov 3. Start rebase to master branch 2020-01-15 13:49:45 -08:00
Alex Miller
c6a65389ae Remove noexcept macro and replace with BOOST_NOEXCEPT.
BOOST_NOEXCEPT does what the noexcept macro was supposed to do, but in a
way that is correctly maintained over time.
2019-03-05 22:06:12 -08:00
Evan Tschannen
171d119d95 another attempt to fix compiler errors 2019-02-20 18:35:08 -08:00
Robert Escriva
268093a96d Adjust all includes to be relative to the root.
Remove the use of relative paths.  A header at foo/bar.h could be included by
files under foo/ with "bar.h", but would be included everywhere else as
"foo/bar.h".  Adjust so that every include references such a header with the
latter form.

Signed-off-by: Robert Escriva <rescriva@dropbox.com>
2018-10-19 17:35:33 +00:00
Alec Grieser
0bae9880f1 remove trailing whitespace from our copyright headers ; fixed formatting of python setup.py 2018-02-21 10:25:11 -08:00
Alex Miller
9648f96200 Also fix unforwarded Metric in IndexedSet.
This is simply an exceedingly minor performance fix rather than a correctness issue.
2017-10-11 17:40:48 -07:00
Alex Miller
c24b941485 Fix erroneous std::move in indexed set, and clean up addMetric users.
This is a follow-on to c4eb73d0.  Thanks to Bala for pointing out the unchanged
std::move usage, and there appeared to not be many existing users of addMetric
anyway.
2017-10-11 17:36:51 -07:00
Alex Miller
0ac868ad5d "Simplify" IndexedSet's insert and addMetric API.
The existing code tried to work around the complexities of optionally using
rvalue references' move capabilities if they exist.  As seen in the previous
MapPair, there's a combinatorial explosion of prototypes to declare as the
parameter length increases.  Because of this, addMetric ended up with a strange
API, and there was a wrapper to make a copy for insert.

Instead, we can apply the idiom of using universal/forwarding references and
std::forward to allow the compiler to instantiate the combinations that are
needed.  There's a TagData struct with no copy constructor that validates that
move constructors can be properly called still.

I measured a 12-byte difference between before and after this change, so no
template bloat was introduced.
2017-10-03 20:15:12 -07:00
FDB Dev Team
a674cb4ef4 Initial repository commit 2017-05-25 13:48:44 -07:00