615 Commits

Author SHA1 Message Date
Suraj Gupta
4530e746d6 Address PR comments.
Adds comment for constant and changes method name for `setonDb`.
2021-09-22 16:56:49 -05:00
Suraj Gupta
4a71f3d0f8 Fix recruitment bug. 2021-09-22 16:56:44 -05:00
Suraj Gupta
72edcd8d73 Address PR comments.
Revert knob name change, fix comparison between new and old
recruitments, and get rid of empty `if` block.
2021-09-22 16:56:34 -05:00
Suraj Gupta
10807ddebc Rename function to be more clear. 2021-09-22 16:56:27 -05:00
Suraj Gupta
0b6fecddbc Refactor logic for recruiting singletons.
This commit refactors the logic for recruiting singletons,
which is done by the ClusterController. This allows for far
easier additions of new singletons in the future, and also
cleans up the code.

Also, the logic for recruiting DD was changed to mirror
the logic for recruiting RK. Although the logic for RK
allows there to be many RKs existing at once, the moveKeysLock
mechanism used by DD still prevents multiple DDs existing at once.
2021-09-22 16:56:18 -05:00
Suraj Gupta
90e102cfd2 Add missing namespace qualifier to vector. 2021-09-20 16:43:08 -05:00
Suraj Gupta
0f898fe138 Simplify count increments. 2021-09-20 14:26:42 -05:00
Suraj Gupta
bac9d4cca8 Address PR comments.
Adds comment for constant and changes method name for `setonDb`.
2021-09-20 14:26:42 -05:00
Suraj Gupta
1420106d8f Fix recruitment bug. 2021-09-20 14:26:42 -05:00
Suraj Gupta
6533678f0d Address PR comments.
Revert knob name change, fix comparison between new and old
recruitments, and get rid of empty `if` block.
2021-09-20 14:26:42 -05:00
Suraj Gupta
6b4eb06201 Rename function to be more clear. 2021-09-20 14:26:42 -05:00
Suraj Gupta
fe098b3b11 Refactor logic for recruiting singletons.
This commit refactors the logic for recruiting singletons,
which is done by the ClusterController. This allows for far
easier additions of new singletons in the future, and also
cleans up the code.

Also, the logic for recruiting DD was changed to mirror
the logic for recruiting RK. Although the logic for RK
allows there to be many RKs existing at once, the moveKeysLock
mechanism used by DD still prevents multiple DDs existing at once.
2021-09-20 14:26:42 -05:00
Xiaoge Su
abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Zhe Wu
51920ffa16 RecruitFromConfigurationRetry should wait for goodRecruitmentTime to be ready 2021-09-02 09:32:08 -07:00
Zhe Wu
6e4f74c9b3 Remove checkRegions in shouldTriggerRecoveryDueToDegradedServers 2021-08-30 13:03:14 -07:00
FDB Formatster
2c788c233d apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-08-27 17:07:47 -07:00
Zhe Wang
7f595f4925 add_trace_event_for_role_recruitment_by_CC 2021-08-23 20:23:55 -05:00
Zhe Wu
a8655e5f4e Allow CC health monitor to handle cancellation 2021-08-19 16:32:18 -07:00
yao-xiao-github
0afb63c13f
Update fdbserver/ClusterController.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-08-18 15:29:13 -07:00
Yao Xiao
7f0a09d1e2 Enable debugTransaction before getReadVersion. 2021-08-18 15:22:58 -07:00
Yao Xiao
4b8dadfdfb Use Time instead of Timestamp. 2021-08-18 11:53:52 -07:00
Yao Xiao
977f8f494e Add version and timestamp to TimeKeeperCommit event. 2021-08-18 01:27:38 -07:00
Jingyu Zhou
bccb09f9dd
Merge pull request #5387 from sfc-gh-tclinkenbeard/improve-worker-const-correctness
Add const qualifiers to several parameters in `worker.actor.cpp`
2021-08-16 13:32:07 -07:00
sfc-gh-tclinkenbeard
3418c20867 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-16 10:49:47 -07:00
sfc-gh-tclinkenbeard
ceb83f7f5e Make ccInterface a const reference in workerServer 2021-08-14 23:41:39 -07:00
Lukas Joswiak
305a17c811 Improve config broadcaster logic, fix unit tests 2021-08-10 11:39:29 -07:00
Lukas Joswiak
72e63db856 Send ConfigBroadcastInterface to ConfigBroadcaster instead of entire worker interface 2021-08-10 11:39:29 -07:00
Lukas Joswiak
3946cf94ff Push updates to workers (clang-formatted files) 2021-08-10 11:39:29 -07:00
Lukas Joswiak
092ab4302b Push updates to workers 2021-08-10 11:39:29 -07:00
sfc-gh-tclinkenbeard
82546853c0 Rename UseConfigDB to ConfigDBType 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard
c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
A.J. Beamon
9f571255bd
Merge pull request #5271 from sfc-gh-ajbeamon/do-not-reset-committed-transaction
Do not partially reset a transaction when it is committed or fails to commit with an error
2021-07-28 09:02:54 -07:00
Steve Atherton
507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
A.J. Beamon
febc26a1ea Fix some cases where we were reusing a committed transaction without resetting it. 2021-07-26 11:43:07 -07:00
Zhe Wu
e39cfd48c3 Ignore goodRecruitmentTime and populate default PEER_LATENCY_CHECK_MIN_POPULATION 2021-07-26 10:24:26 -07:00
sfc-gh-tclinkenbeard
3442ebd3b7 Fix more -Wreorder-ctor warnings across many files 2021-07-24 11:20:51 -07:00
Steve Atherton
f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Markus Pilman
3169f8d25b
Merge pull request #5104 from sfc-gh-ljoswiak/fixes/remote-satellite-determinism
Disable recruitment determinism check for configurations with remote satellites
2021-07-13 10:57:38 -06:00
Xiaoxi Wang
f8a21f4f6c fix invalid trace detail name 2021-07-12 17:44:26 +00:00
Zhe Wu
8773cb1a42
Merge pull request #5088 from halfprice/zhewu/cc-health-triggered-recovery
Implement the main logic of gray network triggered recovery in Cluster Controller
2021-07-11 20:50:34 -07:00
sfc-gh-tclinkenbeard
79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
Lukas Joswiak
e828a498cd Pass vector by const reference 2021-07-01 11:01:52 -07:00
Lukas Joswiak
0bd6ac2a8e Disable recruitment determinism check for configurations with remote satellites 2021-07-01 09:30:46 -07:00
Zhe Wu
5a325aded9 Implement the core logic of gray network triggered recovery in cluster controller 2021-06-30 11:27:05 -07:00
Zhe Wu
865367fb72 Add updateWorkerHealth interface in cluster controller 2021-06-24 19:42:28 -07:00
sfc-gh-tclinkenbeard
41c790b299 Merge remote-tracking branch 'origin/master' into config-db 2021-06-10 22:31:23 -07:00
sfc-gh-tclinkenbeard
13ee24f464 Add UseConfigDB class 2021-06-10 20:57:50 -07:00
Jingyu Zhou
e34df983ee
Merge pull request #4800 from sfc-gh-tclinkenbeard/remove-extra-copies
Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>>
2021-06-07 13:23:50 -07:00
A.J. Beamon
e02ef3b8d8
Merge pull request #4842 from RenxuanW/config
Improve logging on the current view of the database configuration that the cluster controller is using.
2021-06-07 11:28:40 -07:00
sfc-gh-tclinkenbeard
371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00