Evan Tschannen
5695a1816f
fix: requiredFitness was being set to one higher than the actual requirement
2021-04-07 21:31:14 -07:00
Evan Tschannen
1b1f73ea16
added comments
2021-04-07 20:40:42 -07:00
Evan Tschannen
4d8dd0b0a0
fix: desired must be greater than or equal to required
2021-04-07 20:32:45 -07:00
Evan Tschannen
14213b0151
code cleanup
2021-04-07 20:06:30 -07:00
Evan Tschannen
15e8b43961
rewrote getWorkersForTLogs to do a much better job of avoiding degraded processes and processes in the same DC as the cluster controller
2021-04-07 19:57:24 -07:00
Evan Tschannen
c27d82cecd
tlog recruitment used a degraded LogClass process over a non-degraded TransactionClass process
...
tlog recruitment would not use TransactionClass processes if it fulfulled the required amount with LogClass processes
Better master exists did not account for how many times a process had been used when comparing recruitments
Better master exists did not account for the fact that tlogs prefer to be in a different dc than the cluster controller
RoleFitness comparison did not properly order count before degraded or bestFit
betterCount was returning worstFit when worstIsDegraded did not match
backupWorker recruitment did not attempt to avoid sharing processes with other roles
If any of the commit_proxy, grv_proxy, or resolver are forced to share a process, allow the recruitment for all of them to share to an equal degree, this change allows BetterMasterExists to be refactors as a tuple comparison
2021-04-07 16:04:08 -07:00
Markus Pilman
50342b5082
fix a second low-latency bug
2021-03-29 13:31:26 -06:00
Markus Pilman
8555723b98
removing testing case
2021-03-26 15:46:54 -06:00
Markus Pilman
43bed1d9dd
Fix bug where betterMasterExist and recruitment disagree
2021-03-26 15:06:59 -06:00
Evan Tschannen
10b6b5d710
If the current configuration does not have a satellite fallback policy we do not care if the old configuration is in fallback mode
2021-03-23 13:02:31 -07:00
A.J. Beamon
99f3bb6d7d
Merge pull request #4509 from sfc-gh-etschannen/feature-bme-count
...
Do not trigger BetterMasterExists if it lowers the number of processes
2021-03-22 13:43:24 -07:00
Zhe Wu
15f3699e22
Add targeting DC ids in the tlog recruitment event trace.
2021-03-19 14:10:38 -07:00
Meng Xu
0cedef123b
Merge pull request #4518 from halfprice/zhewu/log-tlog-recruitment-failure-reason
...
Logging more detailed information during Tlog recruitment
2021-03-19 11:36:05 -07:00
Zhe Wu
58d9f47782
log fitness for excluded workers as well
2021-03-19 11:04:53 -07:00
Zhe Wu
4c00361f1c
Add comment for 'getWorkersForTlogs' method, and addressed TraceEvent formatting comments.
2021-03-18 21:33:43 -07:00
Zhe Wu
9419387295
Update logging field.
2021-03-18 14:53:43 -07:00
Evan Tschannen
2ff63f544e
Update fdbserver/ClusterController.actor.cpp
...
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-03-18 13:45:51 -07:00
Zhe Wu
451b14af09
Log detailed information when a worker is considered as unavailable by the cluster controller for TLog recruitment.
2021-03-18 12:18:03 -07:00
Zhe Wu
6468c5aed6
Fix string join
2021-03-17 23:46:11 -07:00
Zhe Wu
1205650a69
Log the dcid during TLog recruitment, so that we can tell in which DC the recruitment is happening
2021-03-17 23:22:42 -07:00
Evan Tschannen
9aeb69ca1c
added a comment
2021-03-16 14:19:23 -07:00
Evan Tschannen
d0f134c20e
added a comment
2021-03-16 13:17:56 -07:00
Evan Tschannen
2a272e525f
fix compile error
2021-03-16 12:21:21 -07:00
Evan Tschannen
10fd094920
Better master exists should not trigger if it will lower the total number of processes being recruited
2021-03-16 12:14:19 -07:00
FDB Formatster
df90cc89de
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-10 10:18:07 -08:00
Evan Tschannen
346a4e3ecd
Merge branch 'release-6.3'
...
# Conflicts:
# fdbcli/fdbcli.actor.cpp
# fdbrpc/LoadBalance.actor.h
# fdbrpc/MultiInterface.h
# fdbserver/ClusterController.actor.cpp
# fdbserver/MasterProxyServer.actor.cpp
# fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
Meng Xu
33eb1de00e
Add some comment to log system
...
and resolve review comment by deleting my questions.
2021-02-19 21:44:13 -08:00
Meng Xu
9122be4d81
Add comments to HA code and loadBalance code
2021-02-10 13:51:36 -08:00
Richard Chen
c77d9e4abe
merge conflicts
2020-12-02 21:53:19 +00:00
Markus Pilman
bdd3dbfa7d
remove duplicates
2020-11-10 14:01:07 -07:00
sfc-gh-tclinkenbeard
4669f837fa
Add uses of makeReference
2020-11-07 22:10:18 -08:00
Xin Dong
99d31391ca
Fixed a crash found by nightly correctness.
2020-11-03 09:28:04 -08:00
Richard Chen
bbf5bdf6da
fix stable interfaces test and corresponding changes in simulator
2020-10-12 18:25:12 +00:00
Richard Chen
5488ff1d81
draft diff protocol
2020-10-12 18:24:03 +00:00
Richard Chen
41843f07e6
add simulator support for different process versions and ProtocolVersion test
2020-10-12 18:19:31 +00:00
Xin Dong
175d52312a
Prevent segmentation fault.
2020-10-08 13:36:15 -07:00
Young Liu
cc5bc16bd8
Rename more places from proxy to commit proxy
2020-09-15 22:29:49 -07:00
Young Liu
35bef73a1c
Rename proxy to commit proxy
2020-09-10 17:44:15 -07:00
Young Liu
87693cae81
merge master branch and resolve conflicts
2020-09-02 13:44:33 -07:00
Evan Tschannen
12edadd059
Merge branch 'release-6.3'
...
# Conflicts:
# CMakeLists.txt
# fdbclient/Knobs.cpp
# fdbclient/MasterProxyInterface.h
# fdbrpc/simulator.h
# fdbserver/MasterProxyServer.actor.cpp
# tests/fast/CycleAndLock.txt
# tests/fast/TxnStateStoreCycleTest.txt
# tests/fast/VersionStamp.txt
# tests/slow/ParallelRestoreOldBackupApiCorrectnessAtomicRestore.txt
# tests/slow/ParallelRestoreOldBackupCorrectnessCycle.txt
# versions.target
2020-08-31 19:33:34 -07:00
Evan Tschannen
d42a6b6ea7
remove spammy trace event
2020-08-31 10:37:00 -07:00
Young Liu
19df032aec
Change some formatting issues
2020-08-13 15:30:21 -07:00
Young Liu
4a30492186
Remove debug trace
2020-08-13 14:42:00 -07:00
Young Liu
79ce16650d
merge master branch
2020-08-11 19:22:10 -07:00
Young Liu
ba803a5ea3
Fixed formatting issues and removed GRV related code in MasterProxy
2020-08-11 18:54:54 -07:00
Young Liu
104bac3cbd
Add trace to debug
2020-08-07 13:02:41 -07:00
Young Liu
56cc15ee71
Add trace to debug
2020-08-07 01:02:07 -07:00
Young Liu
d6a23a4d6b
Resolve comments to make GRV proxy a separate process class
2020-08-06 00:01:57 -07:00
Young Liu
30ea639666
Remove debug traces
2020-07-29 07:55:05 -07:00
Young Liu
f7b76a92af
pass joshua
2020-07-29 07:26:55 -07:00