23721 Commits

Author SHA1 Message Date
Ankita Kejriwal
6fa5059521 Tweak where TenantInfo is initialized in metrics functions in NativeAPI
Also clean up debug trace events
2022-10-31 16:48:06 -07:00
Ankita Kejriwal
b1a2239612 Increase the value of UNKNOWN_TENANT_RETRY_DELAY 2022-10-31 16:46:38 -07:00
Josh Slocum
fa80d7bfde
Blobbifiyng tenants in mako so that blob granule reads in tenant mode work (#8587)
* Blobbifiyng tenants in mako so that blob granule reads in tenant mode work

* removing unecessary comment
2022-10-31 18:08:29 -05:00
Jingyu Zhou
8cb2d5e73c
Merge pull request #8594 from yao-xiao-github/fix-deadline
Use a different error code for KV timeout and add timeout to ReadRange.
2022-10-31 15:54:39 -07:00
Trevor Clinkenbeard
fdd2f24174
Fix comment in NativeAPI.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2022-10-31 14:48:13 -07:00
Dennis Zhou
27f9bc1fbc
Merge pull request #8638 from sfc-gh-dzhou/blob-2
blob: fix transaction reset in getBlobRanges() and refactor blob get tenant code
2022-10-31 14:22:22 -07:00
Yao Xiao
e7e8c7ea19 Merge branch 'main' of github.com:apple/foundationdb into fix-deadline 2022-10-31 13:26:31 -07:00
Steve Atherton
70e078718c Bug fix in items processed count, changed delay/yield test to be a template. 2022-10-31 12:49:38 -07:00
Ankita Kejriwal
fcdf1ed6ff
Merge pull request #8603 from sfc-gh-tclinkenbeard/ignore-worst-zone
Make `GlobalTagThrottler` ignore worst zone
2022-10-31 12:46:44 -07:00
A.J. Beamon
e44a7a105b
Merge pull request #8636 from LukasMoll/pep-8-tests
Applied flake8
2022-10-31 12:31:09 -07:00
He Liu
8d76636a7f
Don't unassign ranges from dest servers if they are skipped. (#8611)
Co-authored-by: He Liu <heliu@apple.com>
2022-10-31 12:07:42 -07:00
Yao Xiao
891a5bee10
Add timeout for long running test. (#8634) 2022-10-31 11:19:58 -07:00
Lukas Molleman
76197540dc Applied flake8 2022-10-31 19:19:17 +01:00
Dennis Zhou
f7b608e53f blob: refactor blob get tenant code 2022-10-31 10:37:36 -07:00
Dennis Zhou
1ab432e49d blob: fix error propagation in getBlobRanges()
Fixes: 48d6e725c2d ("blob: convert listBlobbifiedRangesActor() to take a Transaction")
2022-10-31 10:37:36 -07:00
A.J. Beamon
0091abd02b
Merge pull request #8491 from LukasMoll/pep-8
Applied flake8 rules to 2 python files
2022-10-31 09:53:08 -07:00
Jingyu Zhou
766d7a6159
Merge pull request #8581 from sfc-gh-tclinkenbeard/add-tag-throttling-latency-bands
Add latency bands for proxy-enforced tag throttling
2022-10-31 09:23:46 -07:00
Jingyu Zhou
af7b434e51
Merge pull request #8593 from sfc-gh-jshim/fix-tls-circular-reference
Fix circular reference in SSLConnection
2022-10-31 09:21:43 -07:00
Vaidas Gasiunas
0802bbfbb0 Avoid local_cluster.py creating zombie fdbmonitor processes 2022-10-31 15:59:02 +01:00
Steve Atherton
34c61580a0 Added benchmark for delay(0) and yield(). 2022-10-30 20:50:58 -07:00
Steve Atherton
af8934f213 Update PML comments and variable names to rename "launch limits" to "weights" to reflect the new scheduling logic. No logic changes, only renames. 2022-10-30 20:19:53 -07:00
sfc-gh-tclinkenbeard
317f17df89 Added fdb_transaction_get_total_cost test 2022-10-30 14:32:58 -07:00
sfc-gh-tclinkenbeard
0eb1598afa Merge remote-tracking branch 'origin/main' into expose-txn-cost 2022-10-30 09:36:37 -07:00
sfc-gh-tclinkenbeard
1d6bd0057b Merge remote-tracking branch 'origin/main' into add-tag-throttling-latency-bands 2022-10-29 09:49:37 -07:00
sfc-gh-tclinkenbeard
c3c2435228 Addressed review comments 2022-10-28 20:48:18 -07:00
Chaoguang Lin
65aeeff2a2
Update long running tests configs and add more debugging info in the summary (#8615)
* Disable simulation speedup knob and increase the trace limit for long running tests; Add some debugging info for the summary of long running tests

* Solve comments
2022-10-28 18:03:22 -07:00
Jingyu Zhou
22293ebac5
Merge pull request #8614 from neethuhaneesha/clearRanges
Enable clear range eager reads knob for rocksdb.
2022-10-28 17:03:39 -07:00
Steve Atherton
b3017ae330
Merge pull request #8577 from sfc-gh-satherton/storageserver-pml
Unrevert #7578 - new PriorityMultiLock and StorageServer read prioritization.
2022-10-28 16:04:44 -07:00
Ankita Kejriwal
82ab299788 Merge branch 'main' of github.com:apple/foundationdb into monitorusage 2022-10-28 15:42:27 -07:00
He Liu
7bb823edbe
Replace KeyRange with std::vector<KeyRange> in DataMoveMetaData and (#8591)
* Replace KeyRange with std::vector<KeyRange> in DataMoveMetaData and
CheckpointMetaData.

* Checked if ranges.empty().

* fmt.

* Resolved some comments.

Co-authored-by: He Liu <heliu@apple.com>
2022-10-28 15:22:55 -07:00
neethuhaneesha
55fc0c1a0b Enable clear range eager reads knob for rocksdb. 2022-10-28 14:30:05 -07:00
Steve Atherton
f4e8854e8c
Merge pull request #8517 from sfc-gh-etschannen/feature-disk-queue-perf
added a disk queue load generator
2022-10-28 14:15:55 -07:00
Steve Atherton
326d45819e Merge branch 'main' into storageserver-pml 2022-10-28 14:14:44 -07:00
Ankita Kejriwal
ba382169d1 Handle unknown_tenant error in metrics functions in NativeAPI 2022-10-28 13:37:40 -07:00
sfc-gh-tclinkenbeard
948773bab4 Merge remote-tracking branch 'origin/main' into ignore-worst-zone 2022-10-28 13:36:21 -07:00
sfc-gh-tclinkenbeard
07e80f7398 Fixed bug in /GlobalTagThrottler/WriteThrottling unit test 2022-10-28 13:35:30 -07:00
Ankita Kejriwal
38e2fe54b1 Handle tenant_not_found error returned by getEstimatedRangeSizeBytes 2022-10-28 13:09:44 -07:00
Ankita Kejriwal
138d763063 Forward errors from StorageServer if getting tenant entry fails.
Also, fix the version used for the `getTenantEntry()` call.
2022-10-28 13:07:52 -07:00
Jingyu Zhou
d672b1cbce
Merge pull request #8613 from sfc-gh-etschannen/fix-specific-unit-test
Specific unit test should only run one tests instead of all tests
2022-10-28 11:02:12 -07:00
Evan Tschannen
dd970a5c99 Specific unit test should only run one tests instead of all tests 2022-10-28 10:55:20 -07:00
Evan Tschannen
51e2f8e74b made the test clean up after itself 2022-10-28 09:26:48 -07:00
Andrew Noyes
0a15f081a1
Proactively clean up idempotency ids for successful commits (#8578)
* Proactively clean up idempotency ids for successful commits

This change also includes some minor changes from my branch working on
an idempotency ids cleaner, that I'd like to get merged sooner rather
than later.

- Adding a timestamp to idempotency values
- Making IdempotencyId an actor file
- Adding commit_unknown_result_fatal
- Checking idempotencyIdsExpiredVersion in determineCommitStatus
- Some testing QOL changes

* Factor out decodeIdempotencyKey logic

* Fix formatting

* Update flow/include/flow/error_definitions.h

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* Use KeyBackedObjectProperty for idempotencyIdsExpiredVersion

* Add IDEMPOTENCY_ID_IN_MEMORY_LIFETIME knob

* Rename ExpireIdempotencyKeyValuePairRequest

Also add a code probe for the case where an ExpireIdempotencyIdRequest is
received before the count is known, and add an assert

* Fix formatting and add TODO for nwijetunga

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2022-10-28 09:07:54 -07:00
Junhyun Shim
b41879138f Merge remote-tracking branch 'origin/main' into fix-tls-circular-reference 2022-10-28 15:11:03 +02:00
Steve Atherton
d53ed6acae Merge branch 'main' into storageserver-pml 2022-10-28 00:14:01 -07:00
Yao Xiao
05a1497d8a resolve comments 2022-10-27 22:54:20 -07:00
sfc-gh-tclinkenbeard
83bfa95921 Added /GlobalTagThrottler/IgnoreWorstZone unit test 2022-10-27 21:18:39 -07:00
sfc-gh-tclinkenbeard
c0fcf59a8c Fix bug in GlobalTagThrottler::getLimitingTps.
Also add comments to GlobalTagThrottler unit tests
2022-10-27 21:18:39 -07:00
sfc-gh-tclinkenbeard
4b9c21ed8b Ignore worst zones in GlobalTagThrottler::getLimitingTps 2022-10-27 21:18:39 -07:00
sfc-gh-tclinkenbeard
e4836a47a9 Replace GlobalTagThrottlerTesting namespace with anonymous namespace 2022-10-27 21:18:39 -07:00
sfc-gh-tclinkenbeard
6a8c6e83e4 Rename StorageQueueInfo::getTagThrottlingRatio 2022-10-27 21:18:39 -07:00