162 Commits

Author SHA1 Message Date
Markus Pilman
2d84e5e1f1
Merge pull request #4254 from sfc-gh-tclinkenbeard/capture-forked-process-output
Capture forked process output in traces
2021-02-24 14:34:24 -07:00
Steve Atherton
76a4293d1d Merge branch 'release-6.3'
# Conflicts:
#	fdbserver/fdbserver.actor.cpp
2021-02-15 02:13:06 -08:00
Steve Atherton
f4c9b88908 Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	cmake/CompileBoost.cmake
#	fdbserver/DataDistribution.actor.cpp
#	fdbserver/fdbserver.actor.cpp
#	flow/Error.cpp
2021-02-15 02:05:03 -08:00
Andrew Noyes
4e184fe236 Fix memory errors 2021-02-11 02:58:21 +00:00
sfc-gh-tclinkenbeard
acac02587d Trace output from forked processes 2021-01-29 01:31:26 -08:00
sfc-gh-tclinkenbeard
5059228e9e Use unique_ptr for TraceEvent::tmpEventMetric 2020-12-08 09:09:32 -08:00
Andrew Noyes
7fbc4d7391 Resolve conflicts 2020-12-04 23:58:42 +00:00
Andrew Noyes
877997632d Merge branch 'release-6.3' into anoyes/merge-release-6.3-master
Include conflict markers for review purposes
2020-12-04 01:38:07 +00:00
Andrew Noyes
dc2bac5670 Resolve conflicts 2020-11-24 19:09:42 +00:00
Andrew Noyes
1f541f02be Merge branch 'anoyes/merge-6.2-to-6.3' into anoyes/release-6.3-merge
Merge, leaving conflict markers for now
2020-11-24 16:55:34 +00:00
David Youngworth
b1256b5dcd Address review comments, simplify DateTime 2020-11-18 16:55:47 -08:00
David Youngworth
5ade54f767 Fix windows build, DateTime to use UTC 2020-11-18 16:55:12 -08:00
David Youngworth
490fe61032 Fix bug in rolled Trace code 2020-11-18 16:55:06 -08:00
David Youngworth
50e515c29a Add DateTime to trace, initial commit 2020-11-18 16:54:49 -08:00
David Youngworth
d64cf8b9e3 Merge branch 6.3 into master 2020-11-17 11:22:45 -08:00
David Youngworth
d0391db862 Merge branch 'release-6.2' into release-6.3 2020-11-16 10:15:23 -08:00
sfc-gh-tclinkenbeard
392f18a2de Fix retrieveTraceLogIssues function name 2020-11-04 22:39:56 -08:00
Russell Sears
32c87bbb33 Lightweight, power of two spaced histogram implementation + automatic reporting 2020-11-02 11:13:16 -08:00
Xiaoge Su
ac4bebbfad Remove magic number 5 in severity eventsCount 2020-11-01 22:13:55 -08:00
A.J. Beamon
0a1478949a
Merge pull request #3892 from TheBenCollins/log-batch-priority-filter
Add a check against the current minimum priority for TraceBatch logging
2020-10-19 13:02:35 -07:00
Ben Collins
6166f7c99c Add a check against the current minimum priority for TraceBatch logging 2020-10-12 09:57:57 -04:00
sfc-gh-tclinkenbeard
a9607bdcec Explicitly seal classes that inherit but aren't inherited from 2020-10-07 21:58:24 -07:00
sfc-gh-tclinkenbeard
8571dcfe28 Use override where applicable in fdbserver 2020-10-07 18:41:19 -07:00
sfc-gh-tclinkenbeard
0ac08f6a9b Replace NULL with nullptr in flow 2020-09-20 11:31:49 -07:00
Markus Pilman
0fbe7101c3 Revert "Revert "Request tracing""
This reverts commit 327cc31e354d80ca00003a2673bd19a6760285d4.
2020-07-07 10:06:13 -06:00
Jingyu Zhou
327cc31e35
Revert "Request tracing" 2020-06-16 12:32:42 -07:00
Meng Xu
8595813b7d
Merge pull request #3355 from apple/release-6.3
Merge Release 6.3 into master branch
2020-06-12 20:08:47 -07:00
Daniel Smith
2243ee0033
s/NULL/nullptr/
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-06-11 12:06:16 -04:00
Daniel Smith
8088bf7212 Move flush call onto main thread to make TraceBatch not thread hostile 2020-06-11 15:53:29 +00:00
Markus Pilman
09c136e434 Framework for transaction tracing 2020-06-08 16:09:37 -07:00
Markus Pilman
8a7d98ab21 Started instrumentation 2020-05-27 15:36:04 -07:00
Markus Pilman
d748166ed3 Merge branch 'master' of github.com:apple/foundationdb into features/flatbuffers-debugtx 2020-05-18 10:15:58 -07:00
Alex Miller
27da91ab9e Merge remote-tracking branch 'upstream/master' into mutation-debugging 2020-05-13 12:51:44 -07:00
A.J. Beamon
47477382b1 Fix invalid trace event detail named "Type" 2020-05-07 11:22:32 -07:00
Markus Pilman
1c8db89ad4 Implement missing destructor 2020-05-06 14:18:53 -07:00
Markus Pilman
1453ca6303 Added log writer 2020-05-05 17:58:41 -07:00
Markus Pilman
2f0339334f moved dummy pool - started implementation of backend 2020-04-28 20:52:23 +00:00
Markus Pilman
ca5946dd29 Implemented a chunk allocator for FB messages 2020-04-22 11:51:31 -07:00
Markus Pilman
9f114d96c1 Merge branch 'master' of github.com:apple/foundationdb into features/flatbuffers-debugtx 2020-04-16 12:32:19 -07:00
Evan Tschannen
a3598a7616
Merge pull request #2738 from ajbeamon/fix-assertion-failure-on-io-error
Fix assertion failure in SQLite thread pools on io_error
2020-04-14 16:48:22 -07:00
A.J. Beamon
c851ee4031
Merge pull request #2897 from tclinken/fix-trace-batch-loggroup-and-role
Annotate trace batch events before dumping
2020-04-13 11:22:51 -07:00
tclinken
8ef5a04896 Guard all of annotateEvent with mutex 2020-04-10 13:03:15 -07:00
tclinken
01285f3374 Delay annotation of trace batch events created before trace file is opened 2020-04-09 14:09:00 -07:00
Markus Pilman
9beb191932 Merge branch 'master' of github.com:apple/foundationdb into features/flatbuffers-debugtx 2020-04-06 09:38:58 -07:00
tclinken
10fee8fafc Annotate trace batch events before dumping 2020-04-02 19:34:02 -07:00
Markus Pilman
3e3ac9f67d Added interface 2020-04-01 14:41:16 -07:00
Xin Dong
6820167d77
Merge branch 'master' into feature/1689/allow-custome-trace-log-file-identifier 2020-03-31 16:50:46 -07:00
Xin Dong
2805111a32 When provided with a custome identifier, use that string instead of the port/PID as the last part of the baseName. 2020-03-31 11:02:02 -07:00
Alex Miller
cd65f301dd Merge remote-tracking branch 'upstream/master' into mutation-debugging 2020-03-27 03:47:24 -07:00
Alex Miller
72e5891058 Clean up and rework the debugMutation API.
As a relatively unknown debugging tool for simulation tests, one could
have simulation print when a particular key is handled in various stages
of the commit process.  This functionality was enabled by changing a 0
to a 1 in an #if, and changing a constant to the key in question.

As a proxy and storage server handle mutations, they call debugMutation
or debugKeyRange, which then checks against the mutation against the key
in question, and logs if they match.  A mixture of printfs and
TraceEvents would then be emitted, and for this to actually be usable,
one also needs to comment out some particularly spammy debugKeyRange()
calls.

This PR reworks the API of debugMutation/debugKeyRange, pulls it out
into its own file, and trims what is logged by default into something
useful and understandable:
* debugMutation() now returns a TraceEvent, that one can add more details to before it is logged.
* Data distribution and storage server cleanup operations are no longer logged by default
2020-03-27 03:30:28 -07:00