628 Commits

Author SHA1 Message Date
Xiaoxi Wang
61a1f7683b fix dd command line read special key space error 2022-04-11 22:49:21 -07:00
Xiaoxi Wang
6c841cd32b merge readaware-better 2022-04-11 17:09:39 -07:00
Xiaoxi Wang
82e5859e03 allow safeThreadFutureToFuture 2022-04-11 14:35:12 -07:00
Xiaoxi Wang
5113277e9a Merge branch 'main' into readaware 2022-04-08 11:50:01 -07:00
Xiaoxi Wang
411550580e merge 2022-04-08 11:49:33 -07:00
Xiaoxi Wang
150b4318aa refactor datadistribution command; try dual-mode code 2022-04-06 22:10:23 -07:00
Yi Wu
994b8c92f8
Add option to limit resident memory and remove default memory limit (#6719)
Changing `memory` option to limit resident memory instead of virtual memory, in config file and fdbserver/fdbbackup/fdbcli command-line argument. Since `rlimit` doesn't support limiting virtual memory, the current implementation have both of fdbmonitor and the fdbserver/fdbbackup process checking process RSS periodically and kill and restart the process if the limit is exceeded.

Adding a new `memory_vsize` option to limit virtual memory, if backward-compatible behavior is desired.

closes #6671, closes #6672
2022-04-06 20:06:24 -07:00
Xiaoxi Wang
aba9d85560 merge main 2022-04-06 09:57:52 -07:00
Jingyu Zhou
f68fd28d73 Refactor duplicated code into IKnobCollection::setupKnobs() 2022-04-05 02:06:38 -07:00
Xiaoxi Wang
d6d4596c35
Merge pull request #6709 from sfc-gh-ajbeamon/fix-fdbcli-bugs
Fix issues with command completion for exclude and storage_migration_type
2022-03-30 19:53:49 -07:00
Andrew Noyes
d727e7648e Fix a few memory issues found by ASAN 2022-03-29 12:39:12 -07:00
A.J. Beamon
23fcd8c076 Fix issues with command completion for exclude and storage_migration_type. Add missing documentation for tenant_mode in one spot. 2022-03-29 09:07:33 -07:00
Xiaoxi Wang
d93b57dd88 conflict solving 2022-03-24 20:45:51 -07:00
Xiaoxi Wang
1b631a9263 solve conflict with main 2022-03-24 16:29:11 -07:00
Josh Slocum
f27475e2f4 Merge branch 'main' into blob_integration 2022-03-22 11:41:58 -05:00
sfc-gh-tclinkenbeard
a71099471b Update copyright header dates 2022-03-21 13:36:23 -07:00
A.J. Beamon
fd81ef99c0
Merge pull request #6561 from sfc-gh-ajbeamon/fdb-tenant-fdbcli
Add fdbcli support for tenants
2022-03-21 11:26:10 -07:00
sfc-gh-tclinkenbeard
be875e040d Prevent infinite loop on invalid input to 'throttle off' command 2022-03-18 20:22:49 -07:00
sfc-gh-tclinkenbeard
004e73b2f1 Add TagSet::toString method 2022-03-18 20:10:56 -07:00
sfc-gh-tclinkenbeard
fdab73d7b3 Rename TagSet variables in throttleCommandActor.
Previously these were named "tags", conflicting with a state variable,
and creating confusing issues when they go out of scope after a wait
statement.
2022-03-18 19:20:25 -07:00
sfc-gh-tclinkenbeard
6eaa20078f Add ContainsRecommended boolean parameter 2022-03-18 18:12:50 -07:00
sfc-gh-tclinkenbeard
63ec6d5f5b Add static defaultThrottleListLimit in ThrottleCommand.actor.cpp 2022-03-18 17:14:34 -07:00
Josh Slocum
37e7c80f26 Merge branch 'main' into blob_integration 2022-03-17 18:45:42 -05:00
A.J. Beamon
a23add6bc4 Add fdbcli test for tenants. Add documentation for new fdbcli tenant commands. Various output cleanup. Fix limit parsing bug in listtenants command. Update gettenant output format. 2022-03-17 12:10:39 -07:00
A.J. Beamon
bd64781ad9 Use special keys to manage tenants 2022-03-17 12:10:39 -07:00
A.J. Beamon
4aa053d342 Update tenant mode options in fdbcli 2022-03-17 12:10:39 -07:00
A.J. Beamon
f8cddd3842 Add fdbcli support for tenants 2022-03-17 12:10:39 -07:00
Xiaoxi Wang
d38b827906 fix DD ignore bug 2022-03-13 23:47:07 -07:00
sfc-gh-tclinkenbeard
8dcac2f76d Fix typos 2022-03-13 10:02:11 -03:00
Renxuan Wang
92ce0de404 When storing coordinators string, we should concatenate by comma.
We are splitting by comma (402fa4dd9e/fdbclient/SpecialKeySpace.actor.cpp (L1686)). So when we concatenating, if we use ", ", there will be an extra space, causing hostname parsing error. NetworkAddress happens not to have the same issue because it uses sscanf (402fa4dd9e/flow/network.cpp (L119)).
2022-03-09 14:28:22 -08:00
Josh Slocum
e71b3533f9 Merge branch 'main' into blob_integration 2022-03-09 08:59:56 -06:00
Jingyu Zhou
1a5bf25b5c Update code base to use fmt 8.1.1 2022-03-04 15:52:06 -08:00
Xiaoxi Wang
01c347d45c format code; special key space notice update 2022-03-03 15:38:28 -08:00
Xiaoxi Wang
a28b0f4361 Merge branch 'main' of https://github.com/apple/foundationdb into readaware 2022-03-03 11:15:18 -08:00
Xiaoxi Wang
887d5a25cb add storage wiggle to status 2022-03-02 11:31:55 -08:00
Xiaoxi Wang
e73c0a31e6 add wiggle_server_ids and wiggle_server_addresses in status json 2022-03-02 10:03:23 -08:00
Renxuan Wang
fa2eee8279 Use PRId64 and PRIu64 to replace lld and llu.
This fixes https://github.com/apple/foundationdb/pull/6148#issuecomment-1054575608.
2022-02-28 21:30:14 -08:00
Renxuan Wang
233c918ffb Replace printf() and fprintf() with fmt::print(). 2022-02-25 19:06:57 -08:00
Renxuan Wang
f7eb66441d Try eliminating warnings in macOS and Windows CI builds.
MacOS warnings are format warnings, e.g., `format specifies type 'long' but the argument has type 'Version' (aka 'long long')`.
Windows warnings are `ACTOR does not contain a wait() statement`.
2022-02-25 19:06:57 -08:00
Xiaoxi Wang
40a1f562a7 temporary change special key for data distributor 2022-02-25 11:01:23 -08:00
Renxuan Wang
06b1d06d38 Support hostname in coordinators commands. 2022-02-24 23:02:29 -08:00
A.J. Beamon
250a88e682 Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement. 2022-02-24 12:25:52 -08:00
Renxuan Wang
622d89b552 Rebase on main.
Since we changed ClusterConnectionString's status flag from boolean to enum in #6422, we need to update this PR correspondingly.
2022-02-22 16:29:59 -08:00
Renxuan Wang
481587a8c6 Turn on hostname logic. 2022-02-22 16:29:59 -08:00
Xiaoxi Wang
59ac1dffb4 change storage_migration_mode to storage_migration_type 2022-02-22 09:36:30 -08:00
Josh Slocum
38a75a8b89 Merge branch 'main' into blob_integration 2022-02-17 17:47:38 -06:00
A.J. Beamon
5e7982fdd7
Merge pull request #6350 from sfc-gh-ajbeamon/improve-exclude-help
Improve the help for fdbcli exclude
2022-02-11 13:41:59 -08:00
Renxuan Wang
e962d8184c Remove the deprecated code.
They were deleted in #5593 but accidentally added back in #5589.
2022-02-08 17:01:29 -08:00
A.J. Beamon
2973130443 Improve the help for fdbcli exclude. 2022-02-07 10:14:42 -08:00
Xiaoxi Wang
6dc5921575
createdTime based storage wiggler (#6219)
* add storagemetadata

* add StorageWiggler;

* fix serverMetadataKey bug

* add metadata tracker in storage tracker

* finish StorageWiggler

* update next storage ID

* change pid to server id

* write metadata when seed SS

* add status json fields

* remove pid based ppw iteration

* fix time expression

* fix tss metadata nonexistence; fix transaction retry when retrieving metadata

* fix checkMetadata bug when store type is wrong

* fix remove storage status json

* format code

* refactor updateNextWigglingStoragePID

* seperate storage metadata tracker and store type tracker

* rename pid

* wiggler stats

* fix completion between waitServerListChange and storageRecruiter

* solve review comments

* rename system key

* fix database lock timeout by adding lock_aware

* format code

* status json

* resolve code format/naming comments

* delete expireNow; change PerpetualStorageWiggleID's value to KeyBackedObjectMap<UID, StorageWiggleValue>

* fix omit start rount

* format code

* status json reset

* solve status json format

* improve status json latency; replace binarywriter/reader to objectwriter/reader; refactor storagewigglerstats transactions

* status timestamp
2022-02-04 15:04:30 -08:00