Andrew Noyes
4ee97c0784
Use clang-tidy to automatically fix missing overrides
...
Use `clang-tidy -p . $file -checks='-*,modernize-use-override' -header-filter='.*' -fix`
to fix missing overrides, and then use git clang-format to reformat just
those changes. This went pretty well for most files.
Formatting the following files went off the rails, so I'm going to
follow up with a commit that's just clang-tidy and no clang-format.
- fdbclient/DatabaseBackupAgent.actor.cpp
- fdbclient/FileBackupAgent.actor.cpp
- fdbserver/OldTLogServer_4_6.actor.cpp
- fdbmonitor/SimpleIni.h
- fdbserver/workloads/ClientTransactionProfileCorrectness.actor.cpp
2021-01-26 02:04:12 +00:00
Andrew Noyes
0ef44739ea
Fix OPEN_FOR_IDE build in preparation for using clang-tidy
2021-01-26 02:04:11 +00:00
Markus Pilman
d346c4955d
Merge pull request #4235 from sfc-gh-kmakino/kaomakino/aarch64_update
...
Fix minor issues for aarch64
2021-01-25 15:20:08 -07:00
Kao Makino
29976f0b41
Fix minor issues for aarch64
2021-01-25 12:10:57 -08:00
Trevor Clinkenbeard
c9b7013560
Merge pull request #4234 from sfc-gh-jfu/jfu-add-override-keyword
...
Add override keyword properly to squash compiler warnings
2021-01-25 11:33:24 -08:00
Jon Fu
c3775ede37
add override keyword properly to squash compiler warnings
2021-01-25 13:24:15 -05:00
Xiaoge Su
311459f2a3
Merge pull request #4221 from jzhou77/master
...
Proxy rejects long enqueued transactions
2021-01-22 15:08:10 -08:00
Andrew Noyes
bd52ef7cb4
Merge pull request #4225 from sfc-gh-tclinkenbeard/add-override-dummythreadpool
...
Add override keyword to DummyThreadPool methods
2021-01-22 14:18:24 -08:00
Steve Atherton
e74fa1238b
Merge pull request #4181 from sfc-gh-tclinkenbeard/azure-read-remove-copy
...
Remove unnecessary copy from BackupContainerAzureBlobStoreImpl::read
2021-01-22 14:13:23 -08:00
Andrew Noyes
f4cb1b9ad8
Merge pull request #4224 from sfc-gh-tclinkenbeard/fix-wreturn-type-warning
...
Fix -Wreturn-type warning
2021-01-22 13:19:34 -08:00
sfc-gh-tclinkenbeard
5f96c4b721
Add override keyword to DummyThreadPool methods
2021-01-22 13:19:29 -08:00
sfc-gh-tclinkenbeard
82a8f1c763
Fix -Wreturn-type warning
2021-01-22 12:13:29 -08:00
Russell Sears
8d0f9e1ac8
Merge pull request #4102 from sfc-gh-tclinkenbeard/misc-changes
...
Miscellaneous changes
2021-01-22 10:21:22 -08:00
sfc-gh-tclinkenbeard
52ac8e853b
Mark logRangeMutations const in addBackupMutations
2021-01-21 16:27:21 -08:00
sfc-gh-tclinkenbeard
bdf58d0b2f
Add assertion to DDTeamCollection::overlappingMembers
2021-01-21 14:39:39 -08:00
sfc-gh-tclinkenbeard
4dd9c4889e
Revert "Make Profiler::active_profiler a unique pointer" and add comment
2021-01-21 14:32:46 -08:00
sfc-gh-tclinkenbeard
065c7e570c
Revert "Make g_net2 a unique_ptr" and add comment
2021-01-21 14:31:03 -08:00
Jingyu Zhou
bbf51d33e4
Fix early rejection to exit commitBatch
2021-01-21 14:10:48 -08:00
Jingyu Zhou
3bfa1019ab
Fix compiling errors.
2021-01-21 11:11:21 -08:00
sfc-gh-tclinkenbeard
fb9b4b7626
Merge remote-tracking branch 'origin/master' into misc-changes
2021-01-21 10:45:50 -08:00
Markus Pilman
5c44d24874
Merge pull request #4048 from sfc-gh-ljoswiak/features/fluentd
...
Trace serialization
2021-01-21 11:42:01 -07:00
Jingyu Zhou
2fc0b22fe2
Proxy rejects long enqueued transactions
...
The original PR 4113 is lost when merging 6.3 to master.
2021-01-21 10:27:36 -08:00
sfc-gh-tclinkenbeard
3e72163374
Fix compile issues
2021-01-21 10:22:48 -08:00
sfc-gh-tclinkenbeard
ad99bf0471
Merge remote-tracking branch 'origin' into misc-changes
2021-01-21 10:03:07 -08:00
Lukas Joswiak
fd20011276
Remove tags
2021-01-20 17:05:58 -08:00
Lukas Joswiak
4d6fbf099c
Use StringRef for span tags
2021-01-20 13:57:36 -08:00
Lukas Joswiak
34ad4b617b
Add support for longer strings
2021-01-20 13:57:36 -08:00
Lukas Joswiak
5f5f487967
Allow zero length strings
2021-01-20 13:57:36 -08:00
Lukas Joswiak
7ae5e98c5a
Add metadata to a few spans
2021-01-20 13:57:36 -08:00
Lukas Joswiak
e27f2ca3fb
Remove some tracers from Windows
2021-01-20 13:57:36 -08:00
Lukas Joswiak
b9c6ca2481
Fix Windows compilation
2021-01-20 13:57:36 -08:00
Lukas Joswiak
3f7e19a182
Add tags to spans to provide additional metadata
2021-01-20 13:57:36 -08:00
Lukas Joswiak
f6f53c7a73
Style updates
2021-01-20 13:57:36 -08:00
Lukas Joswiak
e8397b3812
Move UDP listen port to knob
2021-01-20 13:57:36 -08:00
Lukas Joswiak
8cc55a3ed5
Fix merge issues
2021-01-20 13:57:36 -08:00
Lukas Joswiak
e8038cd2c1
Remove debug code
2021-01-20 13:57:36 -08:00
Lukas Joswiak
de8bf9f6cf
Write span context as separate 64-bit ints
2021-01-20 13:57:36 -08:00
Lukas Joswiak
ecdb96a7b9
Add IP address and port to serialized spans
2021-01-20 13:57:36 -08:00
Lukas Joswiak
98e6ba6962
Add POSIX send functionality
2021-01-20 13:57:36 -08:00
Lukas Joswiak
13858a853c
Backoff future send attempts if a send failure occurs
2021-01-20 13:57:36 -08:00
Lukas Joswiak
d2143f184a
Add fast UDP tracer
2021-01-20 13:57:36 -08:00
Lukas Joswiak
4ea5267bfd
Add TEST macro
2021-01-20 13:57:36 -08:00
Lukas Joswiak
6800a4dcb3
Fix incorrect simulation check for first byte
...
The array representing fields of the Span can be size 4 or 5, depending
on whether the Span has any parents or not.
2021-01-20 13:57:36 -08:00
Lukas Joswiak
3c11b4b1bd
Cleanup
2021-01-20 13:57:36 -08:00
Lukas Joswiak
3132c38bff
Rename fluentd -> UDP
2021-01-20 13:57:36 -08:00
Lukas Joswiak
069d75b6f2
Update format of serialized spans
...
Write span context as a string instead of as two 64-bit integers. Also
removes some debug code.
2021-01-20 13:57:36 -08:00
Lukas Joswiak
abedd7a147
Fix msgpack array size format
...
Was being written in little-endian, should be written in big-endian.
2021-01-20 13:57:36 -08:00
Lukas Joswiak
e2f57b0845
Modify trace calls
2021-01-20 13:57:36 -08:00
Lukas Joswiak
45699f82be
Abandon sending traces after first failed attempt
2021-01-20 13:57:36 -08:00
Lukas Joswiak
cfba197302
Catch errors around async_send
2021-01-20 13:57:36 -08:00
