Chaoguang Lin
4cc2042783
Update debugging logs
2021-08-13 15:00:52 -07:00
Chaoguang Lin
9553427619
try to fix exlcude fdbcli test
2021-08-13 11:36:49 -07:00
Steve Atherton
303449f82f
Merge pull request #5378 from FuhengZhao/RedwoodMetricsLevelFix
...
Redwood Metric Level
2021-08-12 20:29:08 -07:00
Fuheng Zhao
4282911ce2
level off by 1 fixed
2021-08-12 20:06:46 -07:00
Andrew Noyes
b864b8b3b9
Merge pull request #5377 from sfc-gh-anoyes/anoyes/fix-mystery-debug-mode-crash
...
Fix a crash in debug mode
2021-08-12 17:30:46 -07:00
Andrew Noyes
28f3ffd2ec
Fix a crash in debug mode
...
For unknown reasons, The previous implementation crashed while
(according to valgrind and ubsan) trying to interpret uninitialized memory as a
shared_ptr. This only happened when CMAKE_BUILD_TYPE=Debug. This change
works for debug mode and also still addresses this TSAN issue the
original change addressed.
2021-08-12 16:19:20 -07:00
Daniel Smith
0cc317124e
Merge pull request #5354 from liquid-helium/thread-safe-promis-stream
...
Introduced ThreadReturnPromiseStream
2021-08-12 12:19:13 -04:00
Andrew Noyes
b39a903af0
Merge pull request #5371 from sfc-gh-anoyes/anoyes/fix-heap-use-after-free
...
Fix heap use after free
2021-08-12 07:27:05 -07:00
helium
f445d94baf
Comments resolved.
2021-08-11 17:01:12 -07:00
helium
e988ac53d9
clang-format
2021-08-11 16:21:06 -07:00
Andrew Noyes
ca9f60baef
Fix heap use after free
2021-08-11 15:42:01 -07:00
Zhe Wu
dbd2c636b5
Merge pull request #5283 from sfc-gh-qhoang/qhoang-enable-mako-to-work-with-mvc
...
Enable mako to work with mvc
2021-08-11 14:23:31 -07:00
Lukas Joswiak
a605fb3852
Merge pull request #5026 from sfc-gh-ljoswiak/fixes/alp6
...
Actor sampling
2021-08-11 13:44:17 -07:00
Lukas Joswiak
f295d31e02
Merge pull request #5368 from sfc-gh-ljoswiak/fixes/broadcaster-push-snapshots
...
Push snapshot changes to local configuration on refresh
2021-08-11 13:01:19 -07:00
helium
c043b21974
Added test for sending error
2021-08-11 11:37:12 -07:00
Lukas Joswiak
1faec36bc6
Wait for all snapshot replies before sending incremental changes
2021-08-11 11:17:51 -07:00
helium
f8edf6e1f2
Switched to a separate test ThreadPoolReceiver
2021-08-11 10:47:51 -07:00
QA Hoang
c8ae43fc7c
Merge branch 'master' into qhoang-enable-mako-to-work-with-mvc
2021-08-11 10:11:34 -07:00
Lukas Joswiak
c098a1128d
Push snapshot changes to local configuration on refresh
2021-08-11 09:13:22 -07:00
Josh Slocum
389b71ba72
Merge pull request #5365 from sfc-gh-satherton/debugging-cleanup
...
Added Label field for keys and ranges in MutationTracking.
2021-08-11 07:07:36 -07:00
Trevor Clinkenbeard
bd0a04d4bc
Merge pull request #5345 from sfc-gh-ljoswiak/features/broadcaster-push
...
Refactor config broadcaster to push updates to workers
2021-08-10 19:56:35 -07:00
QA Hoang
a32de81cd2
implemented a timeout for FDB_ERROR_RETRY
2021-08-10 19:54:06 -07:00
Steve Atherton
09a41ff61b
Fix duplicate trace event fields on MutationTracking event.
2021-08-10 17:56:28 -07:00
Steve Atherton
3922fa8cdd
Fix duplicate TraceEvent detail name.
2021-08-10 17:41:31 -07:00
Steve Atherton
eb5c8eb78d
Added Label field for keys and ranges in MutationTracking.
2021-08-10 17:32:32 -07:00
Lukas Joswiak
7fe863c2a0
Temporarily remove failing unit test
2021-08-10 16:20:51 -07:00
Steve Atherton
2de47a9792
Merge pull request #5364 from sfc-gh-satherton/debugging-cleanup
...
Added range tracking support to MutationTracking.
2021-08-10 15:20:32 -07:00
Lukas Joswiak
b112560c94
Reorder registerWorker to prevent potential conflict
2021-08-10 15:09:35 -07:00
Steve Atherton
5482c86d31
Added range tracking support to MutationTracking.
2021-08-10 14:38:02 -07:00
Lukas Joswiak
f018af6ee4
Update fdbserver/ConfigBroadcaster.actor.cpp
...
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-08-10 13:24:41 -07:00
Lukas Joswiak
d27c9e2520
Revert error check
2021-08-10 12:41:41 -07:00
Lukas Joswiak
a838a47b0b
Use ActorCollection for consumer future
2021-08-10 12:27:19 -07:00
Lukas Joswiak
9f4ea02784
Reremove old TODO
2021-08-10 12:14:50 -07:00
Lukas Joswiak
598b23f8d4
Merge branch 'features/broadcaster-push' of github.com:sfc-gh-ljoswiak/foundationdb into features/broadcaster-push
2021-08-10 12:08:16 -07:00
Lukas Joswiak
2ed2294ccb
Remove old TODO
2021-08-10 12:00:43 -07:00
Lukas Joswiak
5dfd7c4b1a
Remove redundant dead worker check
2021-08-10 11:56:58 -07:00
Lukas Joswiak
cf81b0650d
Only register consumer once on the broadcaster
2021-08-10 11:56:16 -07:00
Lukas Joswiak
72e55ef72e
Add broadcaster error check to unit tests
2021-08-10 11:39:29 -07:00
Lukas Joswiak
564a3d69b7
Rename config broadcast interface messages
2021-08-10 11:39:29 -07:00
Lukas Joswiak
833e53f8f0
Add tests back
2021-08-10 11:39:29 -07:00
Lukas Joswiak
85fa264a16
Remove move constructor and assignment operator
2021-08-10 11:39:29 -07:00
Lukas Joswiak
305a17c811
Improve config broadcaster logic, fix unit tests
2021-08-10 11:39:29 -07:00
Lukas Joswiak
72e63db856
Send ConfigBroadcastInterface to ConfigBroadcaster instead of entire worker interface
2021-08-10 11:39:29 -07:00
Lukas Joswiak
3946cf94ff
Push updates to workers (clang-formatted files)
2021-08-10 11:39:29 -07:00
Lukas Joswiak
092ab4302b
Push updates to workers
2021-08-10 11:39:29 -07:00
Lukas Joswiak
3a607d9a38
Update fdbserver/ConfigBroadcaster.actor.cpp
...
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-08-10 09:36:39 -07:00
Josh Slocum
dcef866e18
Merge pull request #5360 from sfc-gh-satherton/debugging-cleanup
...
TraceEvent detail formatting cleanup and MutationTracking improvements
2021-08-10 07:13:50 -07:00
Steve Atherton
54c7036eaf
Move role UIDs for MutationTracking TraceEvents from various inconsistent detail fields into the TraceEvent UID field.
2021-08-10 01:52:36 -07:00
Steve Atherton
e5e8a56b66
Merge branch 'master' of https://github.com/apple/foundationdb into debugging-cleanup
...
# Conflicts:
# fdbbackup/FileDecoder.actor.cpp
2021-08-09 23:36:57 -07:00
Steve Atherton
faa4154a56
MutationTracking now uses a vector of keys to track. Removed "Mutation" detail from DEBUG_MUTATION() events because they are duplicates of the fields already logged in the returned MutationTracking event, which are now renamed and combined into "Mutation". Removed more toString() calls in TraceEvent detail values.
2021-08-09 23:30:45 -07:00
