235 Commits

Author SHA1 Message Date
A.J. Beamon
250a88e682 Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement. 2022-02-24 12:25:52 -08:00
sfc-gh-tclinkenbeard
0f4c808f37 Remove TagThrottler::ratekeeper field 2022-02-14 19:08:23 -08:00
sfc-gh-tclinkenbeard
58669717f1 Move tryAutoThrottleTag method to TagThrottler 2022-02-14 18:54:12 -08:00
sfc-gh-tclinkenbeard
796249e99d Move lastBusiestCommitTagPick field back to Ratekeeper 2022-02-14 16:15:51 -08:00
sfc-gh-tclinkenbeard
00f12687c6 Add TagThrottler class 2022-02-14 16:03:37 -08:00
sfc-gh-tclinkenbeard
49ba96e0bb Clean up ratekeeper includes 2022-02-14 13:02:09 -08:00
sfc-gh-tclinkenbeard
8074630530 Rename class RatekeeperData to Ratekeeper 2022-02-14 12:42:25 -08:00
sfc-gh-tclinkenbeard
d6c5239080 Fix copyright headers 2022-02-14 12:36:44 -08:00
sfc-gh-tclinkenbeard
d4b4479399 Rename RatekeeperData.actor.cpp to Ratekeeper.actor.cpp 2022-02-14 12:35:50 -08:00
sfc-gh-tclinkenbeard
687df447ce Move all code from Ratekeeper.actor.cpp into RatekeeperData.actor.cpp 2022-02-14 12:32:34 -08:00
Zhe Wang
d684508540 Add RatekeeperLimitReasonDetails traceevent for RK 2022-02-10 13:59:47 -08:00
Chang Liu
bdfae966e4 Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu
462781cd07 Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu
abc828f8ef Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu
af03d18cc1 Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu
1817f2ea02 Stop roll trace events for instances that are no longer running
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu
be363f4d81 Stop roll trace events for instances that are no longer running
Description

Testing
2021-09-24 09:53:32 -07:00
Xiaoge Su
abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Chaoguang Lin
fbed117b21 Solve comments; Add a method to return DatabaseContext Reference 2021-08-19 19:34:25 +00:00
Chaoguang Lin
7ac1d17bcb Add a local namespace in Ratekeeper.actor.cpp to differenitate name GrvProxyInfo 2021-08-17 21:05:57 +00:00
Chaoguang Lin
179c313e08 Use DatabaseContext instead of Database in template functions 2021-08-17 20:02:25 +00:00
Chaoguang Lin
bf0d0598dc Refactor all ThrottleAPI functions using template and remove duplicate copies 2021-08-11 23:59:25 +00:00
Chaoguang Lin
618c72f7e2 Draft to use template to rewrite ThrottleApi 2021-08-11 01:07:36 +00:00
sfc-gh-tclinkenbeard
c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
Steve Atherton
507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
sfc-gh-tclinkenbeard
3442ebd3b7 Fix more -Wreorder-ctor warnings across many files 2021-07-24 11:20:51 -07:00
sfc-gh-tclinkenbeard
6f81155784 Merge remote-tracking branch 'origin/master' into const-serverdbinfo 2021-07-20 10:18:40 -07:00
Steve Atherton
f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
sfc-gh-tclinkenbeard
ca3f015272 Prevent ratekeeper from modifying ServerDBInfo object 2021-07-11 23:29:36 -07:00
sfc-gh-tclinkenbeard
79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
Neethu Haneesha Bingi
73752f441b exclude locality:clang-format, ranged loops, documentation, tracking addStoragesever for exclusion. 2021-06-23 18:03:27 -07:00
Josh Slocum
4257ac2b4d More TSS Changes/Fixes 2021-05-25 20:37:48 +00:00
Josh Slocum
ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00
sfc-gh-tclinkenbeard
5c2d7b6080 Create RangeResult type alias 2021-05-03 13:14:16 -07:00
Renxuan Wang
c9cb96b59f
Merge pull request #4661 from RenxuanW/rk
Add TraceEvent to see whether RateKeeper is too busy to get SS list or fails to get SS list.
2021-04-27 10:46:47 -07:00
RenxuanW
384c0b48ea Fix suppressFor order error. 2021-04-25 22:53:52 -07:00
RenxuanW
c06da4704c Revert unrelated clang format. 2021-04-25 17:35:23 -07:00
RenxuanW
22d0426673 Log when RatekeeperGetSSListLongLatency. 2021-04-25 17:34:12 -07:00
RenxuanW
650b052284 Log each time RateKeeper enters monitorServerListChange(). 2021-04-14 13:55:46 -07:00
RenxuanW
28c92aa945
Supress TraceEvent.
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-04-14 12:01:41 -07:00
RenxuanW
08c82050ac Add TraceEvent to see whether RateKeeper is too busy to get SS list, or fails to get SS list. 2021-04-14 11:05:21 -07:00
A.J. Beamon
feede1d2f6 Fix line length of test macro + comments to be within the 120 character limit 2021-04-13 10:48:52 -07:00
Vishesh Yadav
d7252da951 clang-format: Fix the TEST() macros which require comments in line 2021-03-10 16:50:53 -08:00
FDB Formatster
df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Andrew Noyes
79cec09255 Apply clang-tidy's performance-inefficient-vector-operation fix
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.

    $ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
sfc-gh-tclinkenbeard
5b2e88b187 Use structured bindings in for loops 2020-12-27 01:46:20 -04:00
sfc-gh-tclinkenbeard
45c9a0abc7 Revert "Revert "Add limiting health metrics""
This reverts commit 209ebcc5950fe246ee0a6b995dcbe9ecc2688c68.
2020-11-13 17:24:57 -08:00
Trevor Clinkenbeard
209ebcc595
Revert "Add limiting health metrics" 2020-11-13 17:08:46 -08:00
sfc-gh-tclinkenbeard
6c4493166f Add limiting storage queue and durability lag to health metrics 2020-11-12 20:14:41 -08:00
Evan Tschannen
12b07d024f
Merge pull request #3775 from sfc-gh-xwang/fdbtest
add knob MIN_TAG_WRITE_PAGES_RATE for write tag-throttling
2020-09-18 10:40:28 -07:00