apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-25 17:00:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused "readQueueSizeMetric"

Browse Source
This commit is contained in:
Jingyu Zhou 2022-07-19 14:37:30 -07:00
parent dea775ad0d
commit fde5aeeb62
2 changed files with 1 additions and 17 deletions

3
fdbserver/StorageCache.actor.cpp

@ -472,7 +472,6 @@ ACTOR Future<Void> getValueQ(StorageCacheData* data, GetValueRequest req) {
try { try {
++data->counters.getValueQueries; ++data->counters.getValueQueries;
++data->counters.allQueries; ++data->counters.allQueries;
//++data->readQueueSizeMetric;
// TODO later // TODO later
// data->maxQueryQueue = std::max<int>( data->maxQueryQueue, data->counters.allQueries.getValue() - // data->maxQueryQueue = std::max<int>( data->maxQueryQueue, data->counters.allQueries.getValue() -
// data->counters.finishedQueries.getValue()); // data->counters.finishedQueries.getValue());
@ -544,7 +543,6 @@ ACTOR Future<Void> getValueQ(StorageCacheData* data, GetValueRequest req) {
} }
++data->counters.finishedQueries; ++data->counters.finishedQueries;
//--data->readQueueSizeMetric;
// if(data->latencyBandConfig.present()) { // if(data->latencyBandConfig.present()) {
// int maxReadBytes = // int maxReadBytes =
// data->latencyBandConfig.get().readConfig.maxReadBytes.orDefault(std::numeric_limits<int>::max()); // data->latencyBandConfig.get().readConfig.maxReadBytes.orDefault(std::numeric_limits<int>::max());
@ -728,7 +726,6 @@ ACTOR Future<Void> getKeyValues(StorageCacheData* data, GetKeyValuesRequest req)
++data->counters.getRangeQueries; ++data->counters.getRangeQueries;
++data->counters.allQueries; ++data->counters.allQueries;
// printf("\nSCGetKeyValues\n"); // printf("\nSCGetKeyValues\n");
//++data->readQueueSizeMetric;
// data->maxQueryQueue = std::max<int>( data->maxQueryQueue, data->counters.allQueries.getValue() - // data->maxQueryQueue = std::max<int>( data->maxQueryQueue, data->counters.allQueries.getValue() -
// data->counters.finishedQueries.getValue()); // data->counters.finishedQueries.getValue());

15
fdbserver/storageserver.actor.cpp

@ -838,8 +838,6 @@ public:
AsyncVar<bool> noRecentUpdates; AsyncVar<bool> noRecentUpdates;
double lastUpdate; double lastUpdate;
Int64MetricHandle readQueueSizeMetric;
std::string folder; std::string folder;
// defined only during splitMutations()/addMutation() // defined only during splitMutations()/addMutation()
@ -1055,8 +1053,7 @@ public:
primaryLocality(tagLocalityInvalid), knownCommittedVersion(0), versionLag(0), logProtocol(0), primaryLocality(tagLocalityInvalid), knownCommittedVersion(0), versionLag(0), logProtocol(0),
thisServerID(ssi.id()), tssInQuarantine(false), db(db), actors(false), thisServerID(ssi.id()), tssInQuarantine(false), db(db), actors(false),
byteSampleClears(false, LiteralStringRef("\xff\xff\xff")), durableInProgress(Void()), watchBytes(0), byteSampleClears(false, LiteralStringRef("\xff\xff\xff")), durableInProgress(Void()), watchBytes(0),
numWatches(0), noRecentUpdates(false), lastUpdate(now()), numWatches(0), noRecentUpdates(false), lastUpdate(now()), updateEagerReads(nullptr),
readQueueSizeMetric(LiteralStringRef("StorageServer.ReadQueueSize")), updateEagerReads(nullptr),
fetchKeysParallelismLock(SERVER_KNOBS->FETCH_KEYS_PARALLELISM), fetchKeysParallelismLock(SERVER_KNOBS->FETCH_KEYS_PARALLELISM),
fetchChangeFeedParallelismLock(SERVER_KNOBS->FETCH_KEYS_PARALLELISM), fetchChangeFeedParallelismLock(SERVER_KNOBS->FETCH_KEYS_PARALLELISM),
fetchKeysBytesBudget(SERVER_KNOBS->STORAGE_FETCH_BYTES), fetchKeysBudgetUsed(false), fetchKeysBytesBudget(SERVER_KNOBS->STORAGE_FETCH_BYTES), fetchKeysBudgetUsed(false),
@ -1560,7 +1557,6 @@ ACTOR Future<Void> getValueQ(StorageServer* data, GetValueRequest req) {
try { try {
++data->counters.getValueQueries; ++data->counters.getValueQueries;
++data->counters.allQueries; ++data->counters.allQueries;
++data->readQueueSizeMetric;
data->maxQueryQueue = std::max<int>( data->maxQueryQueue = std::max<int>(
data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue()); data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue());
@ -1668,7 +1664,6 @@ ACTOR Future<Void> getValueQ(StorageServer* data, GetValueRequest req) {
data->transactionTagCounter.addRequest(req.tags, resultSize); data->transactionTagCounter.addRequest(req.tags, resultSize);
++data->counters.finishedQueries; ++data->counters.finishedQueries;
--data->readQueueSizeMetric;
double duration = g_network->timer() - req.requestTime(); double duration = g_network->timer() - req.requestTime();
data->counters.readLatencySample.addMeasurement(duration); data->counters.readLatencySample.addMeasurement(duration);
@ -3374,7 +3369,6 @@ ACTOR Future<Void> getKeyValuesQ(StorageServer* data, GetKeyValuesRequest req)
++data->counters.getRangeQueries; ++data->counters.getRangeQueries;
++data->counters.allQueries; ++data->counters.allQueries;
++data->readQueueSizeMetric;
data->maxQueryQueue = std::max<int>( data->maxQueryQueue = std::max<int>(
data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue()); data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue());
@ -3529,7 +3523,6 @@ ACTOR Future<Void> getKeyValuesQ(StorageServer* data, GetKeyValuesRequest req)
data->transactionTagCounter.addRequest(req.tags, resultSize); data->transactionTagCounter.addRequest(req.tags, resultSize);
++data->counters.finishedQueries; ++data->counters.finishedQueries;
--data->readQueueSizeMetric;
double duration = g_network->timer() - req.requestTime(); double duration = g_network->timer() - req.requestTime();
data->counters.readLatencySample.addMeasurement(duration); data->counters.readLatencySample.addMeasurement(duration);
@ -4094,7 +4087,6 @@ ACTOR Future<Void> getMappedKeyValuesQ(StorageServer* data, GetMappedKeyValuesRe
++data->counters.getMappedRangeQueries; ++data->counters.getMappedRangeQueries;
++data->counters.allQueries; ++data->counters.allQueries;
++data->readQueueSizeMetric;
data->maxQueryQueue = std::max<int>( data->maxQueryQueue = std::max<int>(
data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue()); data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue());
@ -4267,7 +4259,6 @@ ACTOR Future<Void> getMappedKeyValuesQ(StorageServer* data, GetMappedKeyValuesRe
data->transactionTagCounter.addRequest(req.tags, resultSize); data->transactionTagCounter.addRequest(req.tags, resultSize);
++data->counters.finishedQueries; ++data->counters.finishedQueries;
--data->readQueueSizeMetric;
double duration = g_network->timer() - req.requestTime(); double duration = g_network->timer() - req.requestTime();
data->counters.readLatencySample.addMeasurement(duration); data->counters.readLatencySample.addMeasurement(duration);
@ -4301,7 +4292,6 @@ ACTOR Future<Void> getKeyValuesStreamQ(StorageServer* data, GetKeyValuesStreamRe
req.reply.setByteLimit(SERVER_KNOBS->RANGESTREAM_LIMIT_BYTES); req.reply.setByteLimit(SERVER_KNOBS->RANGESTREAM_LIMIT_BYTES);
++data->counters.getRangeStreamQueries; ++data->counters.getRangeStreamQueries;
++data->counters.allQueries; ++data->counters.allQueries;
++data->readQueueSizeMetric;
data->maxQueryQueue = std::max<int>( data->maxQueryQueue = std::max<int>(
data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue()); data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue());
@ -4487,7 +4477,6 @@ ACTOR Future<Void> getKeyValuesStreamQ(StorageServer* data, GetKeyValuesStreamRe
data->transactionTagCounter.addRequest(req.tags, resultSize); data->transactionTagCounter.addRequest(req.tags, resultSize);
++data->counters.finishedQueries; ++data->counters.finishedQueries;
--data->readQueueSizeMetric;
return Void(); return Void();
} }
@ -4502,7 +4491,6 @@ ACTOR Future<Void> getKeyQ(StorageServer* data, GetKeyRequest req) {
++data->counters.getKeyQueries; ++data->counters.getKeyQueries;
++data->counters.allQueries; ++data->counters.allQueries;
++data->readQueueSizeMetric;
data->maxQueryQueue = std::max<int>( data->maxQueryQueue = std::max<int>(
data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue()); data->maxQueryQueue, data->counters.allQueries.getValue() - data->counters.finishedQueries.getValue());
@ -4574,7 +4562,6 @@ ACTOR Future<Void> getKeyQ(StorageServer* data, GetKeyRequest req) {
data->transactionTagCounter.addRequest(req.tags, resultSize); data->transactionTagCounter.addRequest(req.tags, resultSize);
++data->counters.finishedQueries; ++data->counters.finishedQueries;
--data->readQueueSizeMetric;
double duration = g_network->timer() - req.requestTime(); double duration = g_network->timer() - req.requestTime();
data->counters.readLatencySample.addMeasurement(duration); data->counters.readLatencySample.addMeasurement(duration);