apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-24 08:09:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

DiskQueue: use explicitly sized int32_t instead of int in on-disk format.

Browse Source 
It was assumed that the payloadSize field in the page header was 32 bits.
This was checked by a static_assert on the size of the PageHeader struct.

This change makes that field size explicit, rather than assuming that
sizeof(int) == sizeof(int32_t).
This commit is contained in:
Dan Adkins 2022-11-02 09:56:26 -07:00
parent e098428ebb
commit f99277f45c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fdbserver/DiskQueue.actor.cpp
View File

@ -1066,7 +1066,7 @@ private:
}; };
uint64_t seq; // seq is the index of the virtually infinite disk queue file. Its unit is bytes. uint64_t seq; // seq is the index of the virtually infinite disk queue file. Its unit is bytes.
uint64_t popped; uint64_t popped;
int payloadSize; int32_t payloadSize;
}; };
// The on disk format depends on the size of PageHeader. // The on disk format depends on the size of PageHeader.
static_assert(sizeof(PageHeader) == 36, "PageHeader must be 36 bytes"); static_assert(sizeof(PageHeader) == 36, "PageHeader must be 36 bytes");
@ -1703,4 +1703,4 @@ TEST_CASE("performance/fdbserver/DiskQueue") {
queue->dispose(); queue->dispose();
wait(queue->onClosed()); wait(queue->onClosed());
return Void(); return Void();
} }