From f17c00c13fe0a927be3616c4666d439ede0267a4 Mon Sep 17 00:00:00 2001
From: Steve Atherton <steve.atherton@snowflake.com>
Date: Mon, 7 Nov 2022 15:17:19 -0800
Subject: [PATCH] Disable taking the ss read lock due to a 5% read perf
 regression in 100% cached read, CPU-bound scenario.

---
 fdbserver/storageserver.actor.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fdbserver/storageserver.actor.cpp b/fdbserver/storageserver.actor.cpp
index 48d845e061..b2cd944f35 100644
--- a/fdbserver/storageserver.actor.cpp
+++ b/fdbserver/storageserver.actor.cpp
@@ -1113,9 +1113,11 @@ public:
 	std::vector<int> readPriorityRanks;
 
 	Future<PriorityMultiLock::Lock> getReadLock(const Optional<ReadOptions>& options) {
-		int readType = (int)(options.present() ? options.get().type : ReadType::NORMAL);
-		readType = std::clamp<int>(readType, 0, readPriorityRanks.size() - 1);
-		return ssLock.lock(readPriorityRanks[readType]);
+		// TODO:  Fix perf regression in 100% cache read case where taking this lock adds too much overhead
+		return PriorityMultiLock::Lock();
+		// int readType = (int)(options.present() ? options.get().type : ReadType::NORMAL);
+		// readType = std::clamp<int>(readType, 0, readPriorityRanks.size() - 1);
+		// return ssLock.lock(readPriorityRanks[readType]);
 	}
 
 	FlowLock serveAuditStorageParallelismLock;