From ea2edebbeba9e14a0a18a54a97c832cfc049ff4b Mon Sep 17 00:00:00 2001
From: Xiaoxi Wang <xiaoxi.wang@snowflake.com>
Date: Mon, 13 Jun 2022 13:36:19 -0700
Subject: [PATCH] comment out store tuple

---
 flow/genericactors.actor.cpp | 2 ++
 flow/genericactors.actor.h   | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/flow/genericactors.actor.cpp b/flow/genericactors.actor.cpp
index 7c054e1401..523e5d8027 100644
--- a/flow/genericactors.actor.cpp
+++ b/flow/genericactors.actor.cpp
@@ -181,6 +181,7 @@ TEST_CASE("/flow/genericactors/AsyncListener") {
 	return Void();
 }
 
+#if false
 TEST_CASE("/flow/genericactors/generic/storeTuple") {
 	state std::vector<UID> resA;
 	state int resB;
@@ -197,3 +198,4 @@ TEST_CASE("/flow/genericactors/generic/storeTuple") {
 	ASSERT(resC == 2.0);
 	return Void();
 }
+#endif
diff --git a/flow/genericactors.actor.h b/flow/genericactors.actor.h
index 777a888871..4955fb6212 100644
--- a/flow/genericactors.actor.h
+++ b/flow/genericactors.actor.h
@@ -300,6 +300,10 @@ Future<Void> store(T& out, Future<T> what) {
 	});
 }
 
+#if false
+// NOTE: Think twice whether create a new struct for a complex return type is better before using tuple.
+// If we just use the return type once, is it worth to create a new struct?
+// And enable the unit test in genericactors.actor.cpp
 template <class A, class... Bs>
 Future<Void> storeTuple(Future<std::tuple<A, Bs...>> what, A& a, Bs&... b) {
 	return map(what, [&](std::tuple<A, Bs...> const& v) {
@@ -307,6 +311,7 @@ Future<Void> storeTuple(Future<std::tuple<A, Bs...>> what, A& a, Bs&... b) {
 		return Void();
 	});
 }
+#endif
 
 template <class T>
 Future<Void> storeOrThrow(T& out, Future<Optional<T>> what, Error e = key_not_found()) {