diff --git a/flow/genericactors.actor.cpp b/flow/genericactors.actor.cpp index 7c054e1401..523e5d8027 100644 --- a/flow/genericactors.actor.cpp +++ b/flow/genericactors.actor.cpp @@ -181,6 +181,7 @@ TEST_CASE("/flow/genericactors/AsyncListener") { return Void(); } +#if false TEST_CASE("/flow/genericactors/generic/storeTuple") { state std::vector resA; state int resB; @@ -197,3 +198,4 @@ TEST_CASE("/flow/genericactors/generic/storeTuple") { ASSERT(resC == 2.0); return Void(); } +#endif diff --git a/flow/genericactors.actor.h b/flow/genericactors.actor.h index 777a888871..4955fb6212 100644 --- a/flow/genericactors.actor.h +++ b/flow/genericactors.actor.h @@ -300,6 +300,10 @@ Future store(T& out, Future what) { }); } +#if false +// NOTE: Think twice whether create a new struct for a complex return type is better before using tuple. +// If we just use the return type once, is it worth to create a new struct? +// And enable the unit test in genericactors.actor.cpp template Future storeTuple(Future> what, A& a, Bs&... b) { return map(what, [&](std::tuple const& v) { @@ -307,6 +311,7 @@ Future storeTuple(Future> what, A& a, Bs&... b) { return Void(); }); } +#endif template Future storeOrThrow(T& out, Future> what, Error e = key_not_found()) {