apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-24 16:20:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded Arena in Requests/Replies

Browse Source 
If the Request/Reply doesn't have *Ref types, we typically don't need to have
an Arena.
This commit is contained in:
Jingyu Zhou 2022-01-07 14:26:13 -08:00
parent 95c72bfc1b
commit db436fb494
2 changed files with 6 additions and 12 deletions

15
fdbserver/TLogInterface.h

@ -193,7 +193,6 @@ struct TLogPeekReply {
struct TLogPeekRequest {
constexpr static FileIdentifier file_identifier = 11001131;
Arena arena;
Version begin;
Tag tag;
bool returnIfBlocked;
@ -211,7 +210,7 @@ struct TLogPeekRequest {
template <class Ar>
void serialize(Ar& ar) {
serializer(ar, arena, begin, tag, returnIfBlocked, onlySpilled, sequence, reply);
serializer(ar, begin, tag, returnIfBlocked, onlySpilled, sequence, reply);
}
};
@ -232,7 +231,6 @@ struct TLogPeekStreamReply : public ReplyPromiseStreamReply {
struct TLogPeekStreamRequest {
constexpr static FileIdentifier file_identifier = 10072821;
Arena arena;
Version begin;
Tag tag;
bool returnIfBlocked;
@ -245,13 +243,12 @@ struct TLogPeekStreamRequest {
template <class Ar>
void serialize(Ar& ar) {
serializer(ar, arena, begin, tag, returnIfBlocked, limitBytes, reply);
serializer(ar, begin, tag, returnIfBlocked, limitBytes, reply);
}
};
struct TLogPopRequest {
constexpr static FileIdentifier file_identifier = 5556423;
Arena arena;
Version to;
Version durableKnownCommittedVersion;
Tag tag;
@ -263,7 +260,7 @@ struct TLogPopRequest {
template <class Ar>
void serialize(Ar& ar) {
serializer(ar, arena, to, durableKnownCommittedVersion, tag, reply);
serializer(ar, to, durableKnownCommittedVersion, tag, reply);
}
};
@ -359,7 +356,6 @@ struct TLogQueuingMetricsRequest {
struct TLogDisablePopRequest {
constexpr static FileIdentifier file_identifier = 4022806;
Arena arena;
UID snapUID;
ReplyPromise<Void> reply;
Optional<UID> debugID;
@ -369,13 +365,12 @@ struct TLogDisablePopRequest {
template <class Ar>
void serialize(Ar& ar) {
serializer(ar, snapUID, reply, arena, debugID);
serializer(ar, snapUID, reply, debugID);
}
};
struct TLogEnablePopRequest {
constexpr static FileIdentifier file_identifier = 4022809;
Arena arena;
UID snapUID;
ReplyPromise<Void> reply;
Optional<UID> debugID;
@ -385,7 +380,7 @@ struct TLogEnablePopRequest {
template <class Ar>
void serialize(Ar& ar) {
serializer(ar, snapUID, reply, arena, debugID);
serializer(ar, snapUID, reply, debugID);
}
};

3
fdbserver/WorkerInterface.actor.h

@ -647,7 +647,6 @@ struct InitializeBackupRequest {
// FIXME: Rename to InitializeMasterRequest, etc
struct RecruitMasterRequest {
constexpr static FileIdentifier file_identifier = 12684574;
Arena arena;
LifetimeToken lifetime;
bool forceRecovery;
ReplyPromise<struct MasterInterface> reply;
@ -657,7 +656,7 @@ struct RecruitMasterRequest {
if constexpr (!is_fb_function<Ar>) {
ASSERT(ar.protocolVersion().isValid());
}
serializer(ar, lifetime, forceRecovery, reply, arena);
serializer(ar, lifetime, forceRecovery, reply);
}
};