apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-03 03:41:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Simplifying CF gap validation to ignore SS CF fetches

Browse Source
This commit is contained in:
Josh Slocum 2022-03-10 11:56:22 -06:00
parent 4b254d259c
commit d7367dad99
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fdbserver/storageserver.actor.cpp
View File

@ -2032,6 +2032,13 @@ ACTOR Future<std::pair<ChangeFeedStreamReply, bool>> getChangeFeedMutations(Stor
// gap validation
while (memoryVerifyIdx < memoryReply.mutations.size() &&
version > memoryReply.mutations[memoryVerifyIdx].version) {
if (req.canReadPopped) {
// There are weird cases where SS fetching mixed with SS durability and popping can mean there are
// gaps before the popped version temporarily
memoryVerifyIdx++;
continue;
}
// There is a case where this can happen - if we wait on a fetching change feed, and the feed is
// popped while we wait, we could have copied the memory mutations into memoryReply before the
// pop, but they may or may not have been skipped writing to disk

7
fdbserver/workloads/BlobGranuleVerifier.actor.cpp
View File

@ -534,9 +534,10 @@ struct BlobGranuleVerifierWorkload : TestWorkload {
clients.push_back(timeout(findGranules(cx, this), testDuration, Void()));
for (int i = 0; i < threads; i++) {
clients.push_back(
timeout(reportErrors(verifyGranules(
cx, this, clientId == 0 && i == 0 && deterministicRandom()->random01() < 0.5),
"BlobGranuleVerifier"),
timeout(reportErrors(
verifyGranules(
cx, this, false /*clientId == 0 && i == 0 && deterministicRandom()->random01() < 0.5*/),
"BlobGranuleVerifier"),
testDuration,
Void()));
}