From d20ce99774c7d41c2687e807c0f2eba9a858a8c0 Mon Sep 17 00:00:00 2001 From: Xin Dong Date: Thu, 16 Jan 2020 17:39:23 -0800 Subject: [PATCH] Resolved the review comment and renamed the functions --- bindings/c/fdb_c.cpp | 4 ++-- bindings/c/foundationdb/fdb_c.h | 2 +- bindings/flow/fdb_flow.actor.cpp | 6 +++--- bindings/flow/fdb_flow.h | 2 +- bindings/go/src/fdb/snapshot.go | 4 ++-- bindings/go/src/fdb/transaction.go | 12 ++++++------ bindings/java/fdbJNI.cpp | 4 ++-- .../main/com/apple/foundationdb/FDBTransaction.java | 10 +++++----- .../main/com/apple/foundationdb/ReadTransaction.java | 4 ++-- bindings/python/fdb/impl.py | 8 ++++---- bindings/ruby/lib/fdbimpl.rb | 6 +++--- fdbclient/IClientApi.h | 2 +- fdbclient/MultiVersionTransaction.actor.cpp | 12 ++++++------ fdbclient/MultiVersionTransaction.h | 6 +++--- fdbclient/ReadYourWrites.actor.cpp | 2 +- fdbclient/ReadYourWrites.h | 2 +- fdbclient/ThreadSafeTransaction.actor.cpp | 4 ++-- fdbclient/ThreadSafeTransaction.h | 2 +- 18 files changed, 46 insertions(+), 46 deletions(-) diff --git a/bindings/c/fdb_c.cpp b/bindings/c/fdb_c.cpp index 4f934e6a8f..b89c43af47 100644 --- a/bindings/c/fdb_c.cpp +++ b/bindings/c/fdb_c.cpp @@ -628,10 +628,10 @@ fdb_error_t fdb_transaction_add_conflict_range( FDBTransaction*tr, uint8_t const } extern "C" DLLEXPORT -FDBFuture* fdb_transaction_get_storage_byte_sample( FDBTransaction* tr, uint8_t const* begin_key_name, +FDBFuture* fdb_transaction_get_estimated_range_size_bytes( FDBTransaction* tr, uint8_t const* begin_key_name, int begin_key_name_length, uint8_t const* end_key_name, int end_key_name_length ) { KeyRangeRef range(KeyRef(begin_key_name, begin_key_name_length), KeyRef(end_key_name, end_key_name_length)); - return (FDBFuture*)(TXN(tr)->getStorageByteSample(range).extractPtr()); + return (FDBFuture*)(TXN(tr)->getEstimatedRangeSizeBytes(range).extractPtr()); } #include "fdb_c_function_pointers.g.h" diff --git a/bindings/c/foundationdb/fdb_c.h b/bindings/c/foundationdb/fdb_c.h index e69977da04..b5dfa63d13 100644 --- a/bindings/c/foundationdb/fdb_c.h +++ b/bindings/c/foundationdb/fdb_c.h @@ -257,7 +257,7 @@ extern "C" { FDBConflictRangeType type); DLLEXPORT WARN_UNUSED_RESULT FDBFuture* - fdb_transaction_get_storage_byte_sample( FDBTransaction* tr, uint8_t const* begin_key_name, + fdb_transaction_get_estimated_range_size_bytes( FDBTransaction* tr, uint8_t const* begin_key_name, int begin_key_name_length, uint8_t const* end_key_name, int end_key_name_length); #define FDB_KEYSEL_LAST_LESS_THAN(k, l) k, l, 0, 0 diff --git a/bindings/flow/fdb_flow.actor.cpp b/bindings/flow/fdb_flow.actor.cpp index 85caf8ac75..132b1bd4d9 100644 --- a/bindings/flow/fdb_flow.actor.cpp +++ b/bindings/flow/fdb_flow.actor.cpp @@ -132,7 +132,7 @@ namespace FDB { bool reverse = false, FDBStreamingMode streamingMode = FDB_STREAMING_MODE_SERIAL) override; - Future getStorageByteSample(const KeyRange& keys) override; + Future getEstimatedRangeSizeBytes(const KeyRange& keys) override; void addReadConflictRange(KeyRangeRef const& keys) override; void addReadConflictKey(KeyRef const& key) override; @@ -347,8 +347,8 @@ namespace FDB { } ); } - Future TransactionImpl::getStorageByteSample(const KeyRange& keys) { - return backToFuture(fdb_transaction_get_storage_byte_sample(tr, keys.begin.begin(), keys.begin.size(), keys.end.begin(), keys.end.size()), [](Reference f) { + Future TransactionImpl::getEstimatedRangeSizeBytes(const KeyRange& keys) { + return backToFuture(fdb_transaction_get_estimated_range_size_bytes(tr, keys.begin.begin(), keys.begin.size(), keys.end.begin(), keys.end.size()), [](Reference f) { int64_t bytes; throw_on_error(fdb_future_get_int64(f->f, &bytes)); return bytes; diff --git a/bindings/flow/fdb_flow.h b/bindings/flow/fdb_flow.h index 9bb6b4071f..66049cae0c 100644 --- a/bindings/flow/fdb_flow.h +++ b/bindings/flow/fdb_flow.h @@ -89,7 +89,7 @@ namespace FDB { streamingMode); } - virtual Future getStorageByteSample(const KeyRange& keys) = 0; + virtual Future getEstimatedRangeSizeBytes(const KeyRange& keys) = 0; virtual void addReadConflictRange(KeyRangeRef const& keys) = 0; virtual void addReadConflictKey(KeyRef const& key) = 0; diff --git a/bindings/go/src/fdb/snapshot.go b/bindings/go/src/fdb/snapshot.go index b69f02abe5..c5734f1809 100644 --- a/bindings/go/src/fdb/snapshot.go +++ b/bindings/go/src/fdb/snapshot.go @@ -87,9 +87,9 @@ func (s Snapshot) GetDatabase() Database { return s.transaction.db } -func (s Snapshot) GetStorageByteSample(r Range) FutureInt64 { +func (s Snapshot) GetEstimatedRangeSizeBytes(r Range) FutureInt64 { begin, end := r.FDBRangeKeySelectors() - return s.getStorageByteSample( + return s.getEstimatedRangeSizeBytes( begin.FDBKeySelector().Key.FDBKey(), end.FDBKeySelector().Key.FDBKey(), ) diff --git a/bindings/go/src/fdb/transaction.go b/bindings/go/src/fdb/transaction.go index e4608ca3d8..2443cac13b 100644 --- a/bindings/go/src/fdb/transaction.go +++ b/bindings/go/src/fdb/transaction.go @@ -39,7 +39,7 @@ type ReadTransaction interface { GetReadVersion() FutureInt64 GetDatabase() Database Snapshot() Snapshot - GetStorageByteSample(r Range) FutureInt64 + GetEstimatedRangeSizeBytes(r Range) FutureInt64 ReadTransactor } @@ -306,9 +306,9 @@ func (t Transaction) GetRange(r Range, options RangeOptions) RangeResult { return t.getRange(r, options, false) } -func (t *transaction) getStorageByteSample(beginKey Key, endKey Key) FutureInt64 { +func (t *transaction) getEstimatedRangeSizeBytes(beginKey Key, endKey Key) FutureInt64 { return &futureInt64{ - future: newFuture(C.fdb_transaction_get_storage_byte_sample( + future: newFuture(C.fdb_transaction_get_estimated_range_size_bytes( t.ptr, byteSliceToPtr(beginKey), C.int(len(beginKey)), @@ -318,11 +318,11 @@ func (t *transaction) getStorageByteSample(beginKey Key, endKey Key) FutureInt64 } } -// GetStorageByteSample will get the byte size of the key range based on the +// GetEstimatedRangeSizeBytes will get the byte size of the key range based on the // byte sample collected by FDB -func (t Transaction) GetStorageByteSample(r Range) FutureInt64 { +func (t Transaction) GetEstimatedRangeSizeBytes(r Range) FutureInt64 { begin, end := r.FDBRangeKeySelectors() - return t.getStorageByteSample( + return t.getEstimatedRangeSizeBytes( begin.FDBKeySelector().Key.FDBKey(), end.FDBKeySelector().Key.FDBKey(), ) diff --git a/bindings/java/fdbJNI.cpp b/bindings/java/fdbJNI.cpp index bb63784994..232e8392fe 100644 --- a/bindings/java/fdbJNI.cpp +++ b/bindings/java/fdbJNI.cpp @@ -646,7 +646,7 @@ JNIEXPORT jlong JNICALL Java_com_apple_foundationdb_FDBTransaction_Transaction_1 return (jlong)f; } -JNIEXPORT jlong JNICALL Java_com_apple_foundationdb_FDBTransaction_Transaction_1getStorageByteSample(JNIEnv *jenv, jobject, jlong tPtr, +JNIEXPORT jlong JNICALL Java_com_apple_foundationdb_FDBTransaction_Transaction_1getEstimatedRangeSizeBytes(JNIEnv *jenv, jobject, jlong tPtr, jbyteArray beginKeyBytes, jbyteArray endKeyBytes) { if( !tPtr || !beginKeyBytes || !endKeyBytes) { throwParamNotNull(jenv); @@ -669,7 +669,7 @@ JNIEXPORT jlong JNICALL Java_com_apple_foundationdb_FDBTransaction_Transaction_1 return 0; } - FDBFuture *f = fdb_transaction_get_storage_byte_sample( tr, startKey, jenv->GetArrayLength( beginKeyBytes ), endKey, jenv->GetArrayLength( endKeyBytes ) ); + FDBFuture *f = fdb_transaction_get_estimated_range_size_bytes( tr, startKey, jenv->GetArrayLength( beginKeyBytes ), endKey, jenv->GetArrayLength( endKeyBytes ) ); jenv->ReleaseByteArrayElements( beginKeyBytes, (jbyte *)startKey, JNI_ABORT ); jenv->ReleaseByteArrayElements( endKeyBytes, (jbyte *)endKey, JNI_ABORT ); return (jlong)f; diff --git a/bindings/java/src/main/com/apple/foundationdb/FDBTransaction.java b/bindings/java/src/main/com/apple/foundationdb/FDBTransaction.java index 4564de41ad..06380197d2 100644 --- a/bindings/java/src/main/com/apple/foundationdb/FDBTransaction.java +++ b/bindings/java/src/main/com/apple/foundationdb/FDBTransaction.java @@ -71,10 +71,10 @@ class FDBTransaction extends NativeObjectWrapper implements Transaction, OptionC } @Override - public CompletableFuture getStorageByteSample(byte[] begin, byte[] end) { + public CompletableFuture getEstimatedRangeSizeBytes(byte[] begin, byte[] end) { pointerReadLock.lock(); try { - return new FutureInt64(Transaction_getStorageByteSample(getPtr(), begin, end), executor); + return new FutureInt64(Transaction_getEstimatedRangeSizeBytes(getPtr(), begin, end), executor); } finally { pointerReadLock.unlock(); } @@ -268,10 +268,10 @@ class FDBTransaction extends NativeObjectWrapper implements Transaction, OptionC } @Override - public CompletableFuture getStorageByteSample(byte[] begin, byte[] end) { + public CompletableFuture getEstimatedRangeSizeBytes(byte[] begin, byte[] end) { pointerReadLock.lock(); try { - return new FutureInt64(Transaction_getStorageByteSample(getPtr(), begin, end), executor); + return new FutureInt64(Transaction_getEstimatedRangeSizeBytes(getPtr(), begin, end), executor); } finally { pointerReadLock.unlock(); } @@ -679,5 +679,5 @@ class FDBTransaction extends NativeObjectWrapper implements Transaction, OptionC private native long Transaction_watch(long ptr, byte[] key) throws FDBException; private native void Transaction_cancel(long cPtr); private native long Transaction_getKeyLocations(long cPtr, byte[] key); - private native long Transaction_getStorageByteSample(long cPtr, byte[] keyBegin, byte[] keyEnd); + private native long Transaction_getEstimatedRangeSizeBytes(long cPtr, byte[] keyBegin, byte[] keyEnd); } diff --git a/bindings/java/src/main/com/apple/foundationdb/ReadTransaction.java b/bindings/java/src/main/com/apple/foundationdb/ReadTransaction.java index 17d11f4941..8451f51716 100644 --- a/bindings/java/src/main/com/apple/foundationdb/ReadTransaction.java +++ b/bindings/java/src/main/com/apple/foundationdb/ReadTransaction.java @@ -414,14 +414,14 @@ public interface ReadTransaction extends ReadTransactionContext { /** - * Gets the sample byte size for the given key range. + * Gets the estimated byte size for the given key range based on the byte sample collcted. * * @param begin the beginning of the range (inclusive) * @param end the end of the range (exclusive) * * @return a handle to access the results of the asynchronous call */ - CompletableFuture getStorageByteSample(byte[] begin, byte[] end); + CompletableFuture getEstimatedRangeSizeBytes(byte[] begin, byte[] end); /** * Returns a set of options that can be set on a {@code Transaction} diff --git a/bindings/python/fdb/impl.py b/bindings/python/fdb/impl.py index ef049d8430..742c399192 100644 --- a/bindings/python/fdb/impl.py +++ b/bindings/python/fdb/impl.py @@ -450,12 +450,12 @@ class TransactionRead(_FDBBase): return self.get_range(key.start, key.stop, reverse=(key.step == -1)) return self.get(key) - def get_storage_byte_sample(self, beginKey, endKey): + def get_estimated_range_size_bytes(self, beginKey, endKey): if begin is None: begin = b'' if end is None: end = b'\xff' - return FutureInt64(self.capi.fdb_transaction_get_storage_byte_sample( + return FutureInt64(self.capi.fdb_transaction_get_estimated_range_size_bytes( self.tpointer, beginKey, len(beginKey), endKey, len(endKey) @@ -1435,8 +1435,8 @@ def init_c_api(): ctypes.c_int, ctypes.c_int] _capi.fdb_transaction_get_range.restype = ctypes.c_void_p - _capi.fdb_transaction_get_storage_byte_sample.argtypes = [ctypes.c_void_p, ctypes.c_void_p, ctypes.c_int, ctypes.c_void_p, ctypes.c_int] - _capi.fdb_transaction_get_range.restype = ctypes.c_void_p + _capi.fdb_transaction_get_estimated_range_size_bytes.argtypes = [ctypes.c_void_p, ctypes.c_void_p, ctypes.c_int, ctypes.c_void_p, ctypes.c_int] + _capi.fdb_transaction_get_estimated_range_size_bytes.restype = ctypes.c_void_p _capi.fdb_transaction_add_conflict_range.argtypes = [ctypes.c_void_p, ctypes.c_void_p, ctypes.c_int, ctypes.c_void_p, ctypes.c_int, ctypes.c_int] _capi.fdb_transaction_add_conflict_range.restype = ctypes.c_int diff --git a/bindings/ruby/lib/fdbimpl.rb b/bindings/ruby/lib/fdbimpl.rb index 3682572783..e5e5266197 100644 --- a/bindings/ruby/lib/fdbimpl.rb +++ b/bindings/ruby/lib/fdbimpl.rb @@ -108,7 +108,7 @@ module FDB attach_function :fdb_transaction_get, [ :pointer, :pointer, :int, :int ], :pointer attach_function :fdb_transaction_get_key, [ :pointer, :pointer, :int, :int, :int, :int ], :pointer attach_function :fdb_transaction_get_range, [ :pointer, :pointer, :int, :int, :int, :pointer, :int, :int, :int, :int, :int, :int, :int, :int, :int ], :pointer - attach_function :fdb_transaction_get_storage_byte_sample, [ :pointer, :pointer, :int, :pointer, :int ], :pointer + attach_function :fdb_transaction_get_estimated_range_size_bytes, [ :pointer, :pointer, :int, :pointer, :int ], :pointer attach_function :fdb_transaction_set, [ :pointer, :pointer, :int, :pointer, :int ], :void attach_function :fdb_transaction_clear, [ :pointer, :pointer, :int ], :void attach_function :fdb_transaction_clear_range, [ :pointer, :pointer, :int, :pointer, :int ], :void @@ -819,10 +819,10 @@ module FDB get_range(prefix, FDB.strinc(prefix), options, &block) end - def get_storage_byte_sample(beginKey, endKey) + def get_estimated_range_size_bytes(beginKey, endKey) bkey = FDB.key_to_bytes(beginKey) ekey = FDB.key_to_bytes(endKey) - Int64Future.new(FDBC.fdb_transaction_get_storage_byte_sample(@tpointer, bkey, bkey.bytesize, ekey, ekey.bytesize)) + Int64Future.new(FDBC.fdb_transaction_get_estimated_range_size_bytes(@tpointer, bkey, bkey.bytesize, ekey, ekey.bytesize)) end end diff --git a/fdbclient/IClientApi.h b/fdbclient/IClientApi.h index 4353196a7c..154ac9723f 100644 --- a/fdbclient/IClientApi.h +++ b/fdbclient/IClientApi.h @@ -48,7 +48,7 @@ public: virtual ThreadFuture> getVersionstamp() = 0; virtual void addReadConflictRange(const KeyRangeRef& keys) = 0; - virtual ThreadFuture getStorageByteSample(const KeyRangeRef& keys) = 0; + virtual ThreadFuture getEstimatedRangeSizeBytes(const KeyRangeRef& keys) = 0; virtual void atomicOp(const KeyRef& key, const ValueRef& value, uint32_t operationType) = 0; virtual void set(const KeyRef& key, const ValueRef& value) = 0; diff --git a/fdbclient/MultiVersionTransaction.actor.cpp b/fdbclient/MultiVersionTransaction.actor.cpp index 49e5d5611c..40c8616d12 100644 --- a/fdbclient/MultiVersionTransaction.actor.cpp +++ b/fdbclient/MultiVersionTransaction.actor.cpp @@ -145,11 +145,11 @@ ThreadFuture> DLTransaction::getVersionstamp() { }); } -ThreadFuture DLTransaction::getStorageByteSample(const KeyRangeRef& keys) { - if (!api->transactionGetStorageByteSample) { +ThreadFuture DLTransaction::getEstimatedRangeSizeBytes(const KeyRangeRef& keys) { + if (!api->transactionGetEstimatedRangeSizeBytes) { return unsupported_operation(); } - FdbCApi::FDBFuture *f = api->transactionGetStorageByteSample(tr, keys.begin.begin(), keys.begin.size(), keys.end.begin(), keys.end.size()); + FdbCApi::FDBFuture *f = api->transactionGetEstimatedRangeSizeBytes(tr, keys.begin.begin(), keys.begin.size(), keys.end.begin(), keys.end.size()); return toThreadFuture(api, f, [](FdbCApi::FDBFuture *f, FdbCApi *api) { int64_t sampledSize; @@ -321,7 +321,7 @@ void DLApi::init() { loadClientFunction(&api->transactionReset, lib, fdbCPath, "fdb_transaction_reset"); loadClientFunction(&api->transactionCancel, lib, fdbCPath, "fdb_transaction_cancel"); loadClientFunction(&api->transactionAddConflictRange, lib, fdbCPath, "fdb_transaction_add_conflict_range"); - loadClientFunction(&api->transactionGetStorageByteSample, lib, fdbCPath, "fdb_transaction_get_storage_byte_sample", headerVersion >= 700); + loadClientFunction(&api->transactionGetEstimatedRangeSizeBytes, lib, fdbCPath, "fdb_transaction_get_estimated_range_size_bytes", headerVersion >= 700); loadClientFunction(&api->futureGetInt64, lib, fdbCPath, headerVersion >= 620 ? "fdb_future_get_int64" : "fdb_future_get_version"); loadClientFunction(&api->futureGetError, lib, fdbCPath, "fdb_future_get_error"); @@ -562,9 +562,9 @@ void MultiVersionTransaction::addReadConflictRange(const KeyRangeRef& keys) { } } -ThreadFuture MultiVersionTransaction::getStorageByteSample(const KeyRangeRef& keys) { +ThreadFuture MultiVersionTransaction::getEstimatedRangeSizeBytes(const KeyRangeRef& keys) { auto tr = getTransaction(); - auto f = tr.transaction ? tr.transaction->getStorageByteSample(keys) : ThreadFuture(Never()); + auto f = tr.transaction ? tr.transaction->getEstimatedRangeSizeBytes(keys) : ThreadFuture(Never()); return abortableFuture(f, tr.onChange); } diff --git a/fdbclient/MultiVersionTransaction.h b/fdbclient/MultiVersionTransaction.h index 0bcaa6ae79..a657f49cbb 100644 --- a/fdbclient/MultiVersionTransaction.h +++ b/fdbclient/MultiVersionTransaction.h @@ -82,7 +82,7 @@ struct FdbCApi : public ThreadSafeReferenceCounted { void (*transactionClearRange)(FDBTransaction *tr, uint8_t const *beginKeyName, int beginKeyNameLength, uint8_t const *endKeyName, int endKeyNameLength); void (*transactionAtomicOp)(FDBTransaction *tr, uint8_t const *keyName, int keyNameLength, uint8_t const *param, int paramLength, FDBMutationTypes::Option operationType); - FDBFuture* (*transactionGetStorageByteSample)(FDBTransaction* tr, uint8_t const* begin_key_name, + FDBFuture* (*transactionGetEstimatedRangeSizeBytes)(FDBTransaction* tr, uint8_t const* begin_key_name, int begin_key_name_length, uint8_t const* end_key_name, int end_key_name_length); FDBFuture* (*transactionCommit)(FDBTransaction *tr); @@ -132,7 +132,7 @@ public: ThreadFuture> getRange( const KeyRangeRef& keys, GetRangeLimits limits, bool snapshot=false, bool reverse=false) override; ThreadFuture>> getAddressesForKey(const KeyRef& key) override; ThreadFuture> getVersionstamp() override; - ThreadFuture getStorageByteSample(const KeyRangeRef& keys) override; + ThreadFuture getEstimatedRangeSizeBytes(const KeyRangeRef& keys) override; void addReadConflictRange(const KeyRangeRef& keys) override; @@ -232,7 +232,7 @@ public: ThreadFuture> getVersionstamp() override; void addReadConflictRange(const KeyRangeRef& keys) override; - ThreadFuture getStorageByteSample(const KeyRangeRef& keys) override; + ThreadFuture getEstimatedRangeSizeBytes(const KeyRangeRef& keys) override; void atomicOp(const KeyRef& key, const ValueRef& value, uint32_t operationType) override; void set(const KeyRef& key, const ValueRef& value) override; diff --git a/fdbclient/ReadYourWrites.actor.cpp b/fdbclient/ReadYourWrites.actor.cpp index c0aee7cebf..12fcbd23a1 100644 --- a/fdbclient/ReadYourWrites.actor.cpp +++ b/fdbclient/ReadYourWrites.actor.cpp @@ -1343,7 +1343,7 @@ Future< Standalone >> ReadYourWritesTransaction::getAddre return result; } -Future ReadYourWritesTransaction::getStorageByteSample(const KeyRangeRef& keys) { +Future ReadYourWritesTransaction::getEstimatedRangeSizeBytes(const KeyRangeRef& keys) { if(checkUsedDuringCommit()) { throw used_during_commit(); } diff --git a/fdbclient/ReadYourWrites.h b/fdbclient/ReadYourWrites.h index 48a742f26b..f4ebd92e4b 100644 --- a/fdbclient/ReadYourWrites.h +++ b/fdbclient/ReadYourWrites.h @@ -84,7 +84,7 @@ public: } [[nodiscard]] Future>> getAddressesForKey(const Key& key); - Future getStorageByteSample( const KeyRangeRef& keys ); + Future getEstimatedRangeSizeBytes( const KeyRangeRef& keys ); void addReadConflictRange( KeyRangeRef const& keys ); void makeSelfConflicting() { tr.makeSelfConflicting(); } diff --git a/fdbclient/ThreadSafeTransaction.actor.cpp b/fdbclient/ThreadSafeTransaction.actor.cpp index 9ddb33fe33..96e8246ab7 100644 --- a/fdbclient/ThreadSafeTransaction.actor.cpp +++ b/fdbclient/ThreadSafeTransaction.actor.cpp @@ -157,12 +157,12 @@ ThreadFuture< Key > ThreadSafeTransaction::getKey( const KeySelectorRef& key, bo } ); } -ThreadFuture ThreadSafeTransaction::getStorageByteSample( const KeyRangeRef& keys ) { +ThreadFuture ThreadSafeTransaction::getEstimatedRangeSizeBytes( const KeyRangeRef& keys ) { KeyRange r = keys; ReadYourWritesTransaction *tr = this->tr; return onMainThread( [tr, r]() -> Future { - return tr->getStorageByteSample(r); + return tr->getEstimatedRangeSizeBytes(r); } ); } diff --git a/fdbclient/ThreadSafeTransaction.h b/fdbclient/ThreadSafeTransaction.h index 98fe6f3e0f..61b64aa4b4 100644 --- a/fdbclient/ThreadSafeTransaction.h +++ b/fdbclient/ThreadSafeTransaction.h @@ -71,7 +71,7 @@ public: } ThreadFuture>> getAddressesForKey(const KeyRef& key) override; ThreadFuture> getVersionstamp() override; - ThreadFuture getStorageByteSample(const KeyRangeRef& keys) override; + ThreadFuture getEstimatedRangeSizeBytes(const KeyRangeRef& keys) override; void addReadConflictRange( const KeyRangeRef& keys ) override; void makeSelfConflicting();