Enable mismatched-tags clang warning

cmake/ConfigureCompiler.cmake

@@ -285,7 +285,6 @@ else()
       -Wno-comment
       -Wno-delete-non-virtual-dtor
       -Wno-format
-      -Wno-mismatched-tags
       -Wno-sign-compare
       -Wno-tautological-pointer-compare
       -Wno-undefined-var-template

fdbclient/ActorLineageProfiler.h

@@ -96,7 +96,7 @@ struct ConfigError {
 class ProfilerConfigT {
 private: // private types
 	using Lock = std::unique_lock<std::mutex>;
-	friend class crossbow::create_static<ProfilerConfigT>;
+	friend struct crossbow::create_static<ProfilerConfigT>;
 
 private: // members
 	std::shared_ptr<SampleIngestor> ingestor = std::make_shared<NoneIngestor>();

fdbclient/ConfigTransactionInterface.h

@@ -188,11 +188,11 @@ struct ConfigTransactionInterface {
 
 public:
 	static constexpr FileIdentifier file_identifier = 982485;
-	struct RequestStream<ConfigTransactionGetGenerationRequest> getGeneration;
+	class RequestStream<ConfigTransactionGetGenerationRequest> getGeneration;
-	struct RequestStream<ConfigTransactionGetRequest> get;
+	class RequestStream<ConfigTransactionGetRequest> get;
-	struct RequestStream<ConfigTransactionGetConfigClassesRequest> getClasses;
+	class RequestStream<ConfigTransactionGetConfigClassesRequest> getClasses;
-	struct RequestStream<ConfigTransactionGetKnobsRequest> getKnobs;
+	class RequestStream<ConfigTransactionGetKnobsRequest> getKnobs;
-	struct RequestStream<ConfigTransactionCommitRequest> commit;
+	class RequestStream<ConfigTransactionCommitRequest> commit;
 
 	ConfigTransactionInterface();
 	void setupWellKnownEndpoints();

fdbrpc/FlowTransport.h

@@ -134,7 +134,7 @@ public:
 	}
 };
 
-struct TransportData;
+class TransportData;
 
 struct Peer : public ReferenceCounted<Peer> {
 	TransportData* transport;

fdbserver/DataDistribution.actor.cpp

@@ -47,7 +47,7 @@
 #include "flow/serialize.h"
 
 class TCTeamInfo;
-struct TCMachineInfo;
+class TCMachineInfo;
 class TCMachineTeamInfo;
 
 namespace {

fdbserver/DeltaTree.h

@@ -349,7 +349,7 @@ public:
 		}
 	};
 
-	struct Cursor;
+	class Cursor;
 
 	// A Mirror is an accessor for a DeltaTree which allows insertion and reading.  Both operations are done
 	// using cursors which point to and share nodes in an tree that is built on-demand and mirrors the compressed
@@ -515,7 +515,8 @@ public:
 
 	// Cursor provides a way to seek into a DeltaTree and iterate over its contents
 	// All Cursors from a Mirror share the same decoded node 'cache' (tree of DecodedNodes)
-	struct Cursor {
+	class Cursor {
+	public:
 		Cursor() : mirror(nullptr), node(nullptr) {}
 
 		Cursor(Mirror* r) : mirror(r), node(mirror->root) {}

flow/Trace.h

@@ -588,8 +588,8 @@ void removeTraceRole(std::string const& role);
 void retrieveTraceLogIssues(std::set<std::string>& out);
 void setTraceLogGroup(const std::string& role);
 template <class T>
-struct Future;
+class Future;
-struct Void;
+class Void;
 Future<Void> pingTraceLogWriterThread();
 
 enum trace_clock_t { TRACE_CLOCK_NOW, TRACE_CLOCK_REALTIME };

flow/flow.h

@@ -445,7 +445,8 @@ struct LineageProperties : LineagePropertiesBase {
 	}
 };
 
-struct ActorLineage : ThreadSafeReferenceCounted<ActorLineage> {
+class ActorLineage : public ThreadSafeReferenceCounted<ActorLineage> {
+public:
 	friend class LineageReference;
 
 	struct Property {

flow/network.h

@@ -407,7 +407,7 @@ public:
 };
 
 // forward declare SendBuffer, declared in serialize.h
-struct SendBuffer;
+class SendBuffer;
 
 class IConnection {
 public:

flow/serialize.h

@@ -851,7 +851,8 @@ struct ISerializeSource {
 };
 
 template <class T, class V>
-struct MakeSerializeSource : ISerializeSource {
+class MakeSerializeSource : public ISerializeSource {
+public:
 	using value_type = V;
 	void serializePacketWriter(PacketWriter& w) const override {
 		ObjectWriter writer([&](size_t size) { return w.writeBytes(size); }, AssumeVersion(w.protocolVersion()));