apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-14 01:42:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the bug where use the pointer after it's cleaned

Browse Source
This commit is contained in:
Chaoguang Lin 2022-04-04 10:46:02 -07:00
parent 6b69c439f0
commit c8455237ea
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/RemoteIKeyValueStore.actor.h
View File

@ -454,6 +454,7 @@ struct RemoteIKeyValueStore : public IKeyValueStore {
}
state Future<Void> connectionCheckingDelay = delay(FLOW_KNOBS->FAILURE_DETECTION_DELAY);
state Future<ErrorOr<Void>> storeError = errorOr(self->interf.getError.getReply(IKVSGetErrorRequest{}));
state NetworkAddress childAddr = self->interf.getError.getEndpoint().getPrimaryAddress();
loop choose {
when(ErrorOr<Void> e = wait(storeError)) {
TraceEvent(SevDebug, "RemoteIKVSGetError")
@ -474,9 +475,7 @@ struct RemoteIKeyValueStore : public IKeyValueStore {
when(wait(connectionCheckingDelay)) {
// for the corner case where the child process stuck and waitpid also does not give update on it
// In this scenario, we need to manually reboot the storage engine process
if (IFailureMonitor::failureMonitor()
.getState(self->interf.getError.getEndpoint().getPrimaryAddress())
.isFailed()) {
if (IFailureMonitor::failureMonitor().getState(childAddr).isFailed()) {
TraceEvent(SevError, "RemoteKVStoreConnectionStuck").log();
throw please_reboot_remote_kv_store(); // this will reboot the worker
}