apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-15 18:32:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disabling update/clear post-stop for now in change feed ops

Browse Source
This commit is contained in:
Josh Slocum 2022-08-01 17:42:32 -05:00
parent ddad5b189e
commit c5c423f2b7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fdbserver/workloads/ChangeFeedOperations.actor.cpp
View File

@ -694,6 +694,14 @@ struct ChangeFeedOperationsWorkload : TestWorkload {
state Transaction tr(cx); state Transaction tr(cx);
state Optional<Value> updateValue; state Optional<Value> updateValue;
// FIXME: right now there is technically a bug in the change feed contract (mutations can appear in the stream
// at a higher version than the stop version) But because stopping a feed is sort of just an optimization, and
// no current user of change feeds currently relies on the stop version for correctness, it's fine to not test
// this for now
if (feedData->stopVersion.present()) {
return Void();
}
// if value is already not set, don't do a clear, otherwise pick either // if value is already not set, don't do a clear, otherwise pick either
if (feedData->lastCleared || deterministicRandom()->random01() > self->clearFrequency) { if (feedData->lastCleared || deterministicRandom()->random01() > self->clearFrequency) {
updateValue = feedData->nextValue(); updateValue = feedData->nextValue();