From aca44c8644d5fc815fcceeb62313827818c5e4d4 Mon Sep 17 00:00:00 2001 From: "Bharadwaj V.R" Date: Fri, 8 Jul 2022 14:45:44 -0700 Subject: [PATCH] Increase frequency of RelocateShardStartSplit traces for better observability of splits (#7503) --- fdbserver/DataDistributionTracker.actor.cpp | 25 ++++++++++----------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/fdbserver/DataDistributionTracker.actor.cpp b/fdbserver/DataDistributionTracker.actor.cpp index b4c30fba1f..3976c76674 100644 --- a/fdbserver/DataDistributionTracker.actor.cpp +++ b/fdbserver/DataDistributionTracker.actor.cpp @@ -498,19 +498,18 @@ ACTOR Future shardSplitter(DataDistributionTracker* self, //} int numShards = splitKeys.size() - 1; - if (deterministicRandom()->random01() < 0.01) { - TraceEvent("RelocateShardStartSplitx100", self->distributorId) - .detail("Begin", keys.begin) - .detail("End", keys.end) - .detail("MaxBytes", shardBounds.max.bytes) - .detail("MetricsBytes", metrics.bytes) - .detail("Bandwidth", - bandwidthStatus == BandwidthStatusHigh ? "High" - : bandwidthStatus == BandwidthStatusNormal ? "Normal" - : "Low") - .detail("BytesPerKSec", metrics.bytesPerKSecond) - .detail("NumShards", numShards); - } + TraceEvent("RelocateShardStartSplit", self->distributorId) + .suppressFor(1.0) + .detail("Begin", keys.begin) + .detail("End", keys.end) + .detail("MaxBytes", shardBounds.max.bytes) + .detail("MetricsBytes", metrics.bytes) + .detail("Bandwidth", + bandwidthStatus == BandwidthStatusHigh ? "High" + : bandwidthStatus == BandwidthStatusNormal ? "Normal" + : "Low") + .detail("BytesPerKSec", metrics.bytesPerKSecond) + .detail("NumShards", numShards); if (numShards > 1) { int skipRange = deterministicRandom()->randomInt(0, numShards);