apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-02 19:25:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Compute known committed version correctly when version vector unicast is enabled (#11511)

Browse Source 
* - Compute known committed version correctly when version vector unicast
is enabled.

* - Set ProxyCommitData::minKnownCommittedVersion only if the commit
version is above ProxyCommitData::committedVersion.
This commit is contained in:
Sreenath Bodagala 2024-07-19 00:11:40 +05:30 committed by GitHub
parent c630fa2296
commit aacf2e29db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fdbserver/CommitProxyServer.actor.cpp
View File

@ -2503,7 +2503,10 @@ ACTOR Future<Void> transactionLogging(CommitBatchContext* self) {
try {
choose {
when(Version ver = wait(self->loggingComplete)) {
pProxyCommitData->minKnownCommittedVersion = std::max(pProxyCommitData->minKnownCommittedVersion, ver);
if (!SERVER_KNOBS->ENABLE_VERSION_VECTOR_TLOG_UNICAST) {
pProxyCommitData->minKnownCommittedVersion =
std::max(pProxyCommitData->minKnownCommittedVersion, ver);
}
}
when(wait(pProxyCommitData->committedVersion.whenAtLeast(self->commitVersion + 1))) {}
}
@ -2591,6 +2594,11 @@ ACTOR Future<Void> reply(CommitBatchContext* self) {
pProxyCommitData->locked = self->lockedAfter;
pProxyCommitData->metadataVersion = self->metadataVersionAfter;
pProxyCommitData->committedVersion.set(self->commitVersion);
if (SERVER_KNOBS->ENABLE_VERSION_VECTOR_TLOG_UNICAST) {
ASSERT(self->loggingComplete.isReady());
pProxyCommitData->minKnownCommittedVersion =
std::max(pProxyCommitData->minKnownCommittedVersion, self->loggingComplete.get());
}
}
if (self->forceRecovery) {