mirror of
https://github.com/apple/foundationdb.git
synced 2025-05-14 01:42:37 +08:00
Merge pull request #5243 from sfc-gh-mpilman/bugfixes/macos-literal-string
remove unnecessary compile guards
This commit is contained in:
commit
a7f71c5a18
@ -19,9 +19,7 @@
|
||||
*/
|
||||
|
||||
#include "fdbclient/BackupContainerAzureBlobStore.h"
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
#include "fdbrpc/AsyncFileEncrypted.h"
|
||||
#emdif
|
||||
|
||||
#include "flow/actorcompiler.h" // This must be the last #include.
|
||||
|
||||
@ -250,9 +248,7 @@ BackupContainerAzureBlobStore::BackupContainerAzureBlobStore(const NetworkAddres
|
||||
const std::string& containerName,
|
||||
const Optional<std::string>& encryptionKeyFileName)
|
||||
: containerName(containerName) {
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
setEncryptionKey(encryptionKeyFileName);
|
||||
#endif
|
||||
std::string accountKey = std::getenv("AZURE_KEY");
|
||||
auto credential = std::make_shared<azure::storage_lite::shared_key_credential>(accountName, accountKey);
|
||||
auto storageAccount = std::make_shared<azure::storage_lite::storage_account>(
|
||||
|
@ -23,9 +23,7 @@
|
||||
#include "fdbclient/BackupContainerFileSystem.h"
|
||||
#include "fdbclient/BackupContainerLocalDirectory.h"
|
||||
#include "fdbclient/JsonBuilder.h"
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
#include "flow/StreamCipher.h"
|
||||
#endif
|
||||
#include "flow/UnitTest.h"
|
||||
|
||||
#include <algorithm>
|
||||
@ -1481,7 +1479,6 @@ Future<Void> BackupContainerFileSystem::encryptionSetupComplete() const {
|
||||
return encryptionSetupFuture;
|
||||
}
|
||||
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
void BackupContainerFileSystem::setEncryptionKey(Optional<std::string> const& encryptionKeyFileName) {
|
||||
if (encryptionKeyFileName.present()) {
|
||||
#if ENCRYPTION_ENABLED
|
||||
@ -1498,11 +1495,6 @@ Future<Void> BackupContainerFileSystem::createTestEncryptionKeyFile(std::string
|
||||
return Void();
|
||||
#endif
|
||||
}
|
||||
#else
|
||||
Future<Void> BackupContainerFileSystem::createTestEncryptionKeyFile(std::string const& filename) {
|
||||
return Void();
|
||||
}
|
||||
#endif
|
||||
|
||||
namespace backup_test {
|
||||
|
||||
|
@ -156,9 +156,7 @@ public:
|
||||
|
||||
protected:
|
||||
bool usesEncryption() const;
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
void setEncryptionKey(Optional<std::string> const& encryptionKeyFileName);
|
||||
#endif
|
||||
Future<Void> encryptionSetupComplete() const;
|
||||
|
||||
private:
|
||||
|
@ -133,9 +133,7 @@ std::string BackupContainerLocalDirectory::getURLFormat() {
|
||||
|
||||
BackupContainerLocalDirectory::BackupContainerLocalDirectory(const std::string& url,
|
||||
const Optional<std::string>& encryptionKeyFileName) {
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
setEncryptionKey(encryptionKeyFileName);
|
||||
#endif
|
||||
|
||||
std::string path;
|
||||
if (url.find("file://") != 0) {
|
||||
|
@ -147,9 +147,7 @@ BackupContainerS3BlobStore::BackupContainerS3BlobStore(Reference<S3BlobStoreEndp
|
||||
const S3BlobStoreEndpoint::ParametersT& params,
|
||||
const Optional<std::string>& encryptionKeyFileName)
|
||||
: m_bstore(bstore), m_name(name), m_bucket("FDB_BACKUPS_V2") {
|
||||
#if (!defined(TLS_DISABLED) && !defined(_WIN32))
|
||||
setEncryptionKey(encryptionKeyFileName);
|
||||
#endif
|
||||
// Currently only one parameter is supported, "bucket"
|
||||
for (const auto& [name, value] : params) {
|
||||
if (name == "bucket") {
|
||||
|
Loading…
x
Reference in New Issue
Block a user