apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-15 18:32:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Clean up RocksDB error logging

Browse Source
This commit is contained in:
Daniel Smith 2021-11-12 12:14:12 -05:00
parent 80d6debe14
commit 9dccb0131e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/KeyValueStoreRocksDB.actor.cpp
View File

@ -206,7 +206,8 @@ ACTOR Future<Void> rocksDBMetricLogger(std::shared_ptr<rocksdb::Statistics> stat
} }
void logRocksDBError(const rocksdb::Status& status, const std::string& method) { void logRocksDBError(const rocksdb::Status& status, const std::string& method) {
TraceEvent e(SevError, "RocksDBError"); auto level = status.IsTimedOut() ? SevWarn : SevError;
TraceEvent e(level, "RocksDBError");
e.detail("Error", status.ToString()).detail("Method", method).detail("RocksDBSeverity", status.severity()); e.detail("Error", status.ToString()).detail("Method", method).detail("RocksDBSeverity", status.severity());
if (status.IsIOError()) { if (status.IsIOError()) {
e.detail("SubCode", status.subcode()); e.detail("SubCode", status.subcode());
@ -414,7 +415,7 @@ struct RocksDBKeyValueStore : IKeyValueStore {
} else if (s.IsNotFound()) { } else if (s.IsNotFound()) {
a.result.send(Optional<Value>()); a.result.send(Optional<Value>());
} else { } else {
TraceEvent(SevError, "RocksDBError").detail("Error", s.ToString()).detail("Method", "ReadValue"); logRocksDBError(s, "ReadValue");
a.result.sendError(statusToError(s)); a.result.sendError(statusToError(s));
} }
} }