apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-02 11:15:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Bug fix: Redwood shutdown would wait for pending IO success so if any of them failed the shutdown would never complete.

Browse Source
This commit is contained in:
Steve Atherton 2022-05-02 19:26:44 -07:00
parent 90dae38d04
commit 9a279c24ae
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fdbserver/VersionedBTree.actor.cpp
View File

@ -2108,7 +2108,9 @@ public:
return !reading() && !writing();
}
Future<Void> onEvictable() const { return ready(readFuture) && writeFuture; }
// Entry is evictable when its write and read futures are ready, even if they are
// errors, so any buffers they hold are no longer needed by the underlying file actors
Future<Void> onEvictable() const { return ready(readFuture) && ready(writeFuture); }
};
typedef ObjectCache<LogicalPageID, PageCacheEntry> PageCacheT;
@ -3761,7 +3763,9 @@ public:
// Must wait for pending operations to complete, canceling them can cause a crash because the underlying
// operations may be uncancellable and depend on memory from calling scope's page reference
debug_printf("DWALPager(%s) shutdown wait for operations\n", self->filename.c_str());
wait(waitForAll(self->operations));
// Pending ops must be all ready, errors are okay
wait(waitForAllReady(self->operations));
self->operations.clear();
debug_printf("DWALPager(%s) shutdown destroy page cache\n", self->filename.c_str());