apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-15 18:32:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove WAL mutations during rollback

Browse Source
This commit is contained in:
Lukas Joswiak 2021-08-26 13:37:50 -07:00
parent 9c561f49d9
commit 782f13c25e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fdbserver/ConfigNode.actor.cpp
View File

@ -332,6 +332,7 @@ class ConfigNodeImpl {
latestVersion = mutation.version; latestVersion = mutation.version;
index = 0; index = 0;
} }
// TODO: This ASSERT might be unnecessary since compaction destroys annotations
ASSERT(annotations.find(mutation.version) != annotations.end()); ASSERT(annotations.find(mutation.version) != annotations.end());
Key key = versionedMutationKey(mutation.version, index++); Key key = versionedMutationKey(mutation.version, index++);
Value value = ObjectWriter::toValue(mutation.mutation, IncludeVersion()); Value value = ObjectWriter::toValue(mutation.mutation, IncludeVersion());
@ -472,11 +473,18 @@ class ConfigNodeImpl {
} }
ACTOR static Future<Void> rollback(ConfigNodeImpl* self, ConfigFollowerRollbackRequest req) { ACTOR static Future<Void> rollback(ConfigNodeImpl* self, ConfigFollowerRollbackRequest req) {
// TODO: Actually delete mutations from kvstore (similar to compact)
state ConfigGeneration generation = wait(getGeneration(self)); state ConfigGeneration generation = wait(getGeneration(self));
if (req.version < generation.committedVersion) { if (req.version < generation.committedVersion) {
Standalone<VectorRef<VersionedConfigMutationRef>> versionedMutations =
wait(getMutations(self, req.version + 1, generation.committedVersion));
self->kvStore->clear(KeyRangeRef(versionedMutationKey(req.version + 1, 0),
versionedMutationKey(generation.committedVersion + 1, 0)));
self->kvStore->clear(KeyRangeRef(versionedAnnotationKey(req.version + 1),
versionedAnnotationKey(generation.committedVersion + 1)));
generation.committedVersion = req.version; generation.committedVersion = req.version;
self->kvStore->set(KeyValueRef(currentGenerationKey, BinaryWriter::toValue(generation, IncludeVersion()))); self->kvStore->set(KeyValueRef(currentGenerationKey, BinaryWriter::toValue(generation, IncludeVersion())));
wait(self->kvStore->commit());
} }
req.reply.send(Void()); req.reply.send(Void());
return Void(); return Void();