apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-02 03:12:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

included stricter checks when adding coordinator to the workload's kill set

Browse Source
This commit is contained in:
Jon Fu 2019-10-08 13:32:57 -07:00
parent ff563c1672
commit 6fc3ef17fb
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fdbserver/workloads/RemoveServersSafely.actor.cpp
View File

@ -403,12 +403,20 @@ struct RemoveServersSafelyWorkload : TestWorkload {
state std::vector<AddressExclusion> toKillArray;
state std::vector<AddressExclusion> toKillMarkFailedArray;
state AddressExclusion coordExcl;
// Exclude a coordinator under buggify, but only if fault tolerance is > 0
if (BUGGIFY && g_simulator.desiredCoordinators > 1) {
// Exclude a coordinator under buggify, but only if fault tolerance is > 0 and kill set is non-empty already
if (BUGGIFY && toKill.size()) {
std::vector<NetworkAddress> coordinators = wait(getCoordinators(cx));
auto& randomCoordinator = deterministicRandom()->randomChoice(coordinators);
coordExcl = AddressExclusion(randomCoordinator.ip, randomCoordinator.port);
toKill.insert(coordExcl);
if (coordinators.size() > 2) {
auto removeServer = toKill.begin();
auto randomCoordinator = deterministicRandom()->randomChoice(coordinators);
coordExcl = AddressExclusion(randomCoordinator.ip, randomCoordinator.port);
TraceEvent("RemoveAndKill", functionId)
.detail("Step", "ReplaceKillSet")
.detail("Removing", removeServer->toString())
.detail("Adding", coordExcl.toString());
toKill.erase(removeServer);
toKill.insert(coordExcl);
}
}
std::copy(toKill.begin(), toKill.end(), std::back_inserter(toKillArray));
killProcArray = self->getProcesses(toKill);