apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-14 01:42:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make Tuple::pack return a Standalone<StringRef> (#7764)

Browse Source 
This makes it less error-prone and more like other similar functions
like BinaryWriter::toValue

Closes #7748
This commit is contained in:
Andrew Noyes 2022-08-02 12:45:56 -07:00 committed by GitHub
parent 48e46cbc81
commit 5dbb6f1dd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bindings/flow/Tuple.h
View File

@ -63,7 +63,9 @@ struct Tuple {
Tuple& appendNull();
Tuple& appendVersionstamp(Versionstamp const&);
StringRef pack() const { return StringRef(data.begin(), data.size()); }
Standalone<StringRef> pack() const {
return Standalone<StringRef>(StringRef(data.begin(), data.size()), data.arena());
}
template <typename T>
Tuple& operator<<(T const& t) {

4
fdbclient/include/fdbclient/Tuple.h
View File

@ -56,7 +56,9 @@ struct Tuple {
Tuple& appendNull();
Tuple& append(Versionstamp const&);
StringRef pack() const { return StringRef(data.begin(), data.size()); }
Standalone<StringRef> pack() const {
return Standalone<StringRef>(StringRef(data.begin(), data.size()), data.arena());
}
template <typename T>
Tuple& operator<<(T const& t) {