apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-02 03:12:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

swallowing errors in redwood dispose

Browse Source
This commit is contained in:
Josh Slocum 2023-03-10 17:48:48 -06:00
parent 31aa6af783
commit 4a0ceca75e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/VersionedBTree.actor.cpp
View File

@ -3666,7 +3666,10 @@ public:
if (dispose) {
if (!self->memoryOnly) {
debug_printf("DWALPager(%s) shutdown deleting file\n", self->filename.c_str());
wait(IAsyncFileSystem::filesystem()->incrementalDeleteFile(self->filename, true));
// We wrap this with ready() because we don't care if incrementalDeleteFile throws an error because:
// - if the file was unlinked, the file will be cleaned up by the filesystem after the process exits
// - if the file was not unlinked, the worker will restart and pick it up and it'll be removed later
wait(ready(IAsyncFileSystem::filesystem()->incrementalDeleteFile(self->filename, true)));
}
}