From 45c466e26993c9cbd76c3dd292009dd308a409bc Mon Sep 17 00:00:00 2001 From: Alex Miller Date: Mon, 1 Apr 2019 17:25:08 -0700 Subject: [PATCH] Open incrementalDelete files with OPEN_UNBUFFERED This fixes crashes from AsyncFileWinASIO refusing to open a file that didn't have OPEN_UNBUFFERED. --- fdbrpc/IAsyncFile.actor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdbrpc/IAsyncFile.actor.cpp b/fdbrpc/IAsyncFile.actor.cpp index 64b88bc14c..7a4854e89d 100644 --- a/fdbrpc/IAsyncFile.actor.cpp +++ b/fdbrpc/IAsyncFile.actor.cpp @@ -88,7 +88,7 @@ ACTOR static Future incrementalDeleteHelper( std::string filename, bool mu state bool exists = fileExists(filename); if(exists) { - Reference f = wait(IAsyncFileSystem::filesystem()->open(filename, IAsyncFile::OPEN_READWRITE | IAsyncFile::OPEN_UNCACHED, 0)); + Reference f = wait(IAsyncFileSystem::filesystem()->open(filename, IAsyncFile::OPEN_READWRITE | IAsyncFile::OPEN_UNCACHED | IAsyncFile::OPEN_UNBUFFERED, 0)); file = f; int64_t fileSize = wait(file->size());