From 355208026696d35985fc6eb4cb3cd52ae6bc8903 Mon Sep 17 00:00:00 2001 From: Chaoguang Lin Date: Thu, 15 Jul 2021 16:38:04 +0000 Subject: [PATCH] Update some comments of the change --- bindings/python/CMakeLists.txt | 2 +- bindings/python/tests/fdbcli_tests.py | 2 +- tests/TestRunner/local_cluster.py | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/bindings/python/CMakeLists.txt b/bindings/python/CMakeLists.txt index d50df8e5e6..2fe304a0dc 100644 --- a/bindings/python/CMakeLists.txt +++ b/bindings/python/CMakeLists.txt @@ -86,7 +86,7 @@ if (NOT WIN32 AND NOT OPEN_FOR_IDE) add_fdbclient_test( NAME multi_process_fdbcli_tests PROCESS_NUMBER 5 - TEST_TIMEOUT 120 + TEST_TIMEOUT 120 # The test can take near to 1 minutes sometime, set timeout to 2 minutes to be safe COMMAND ${CMAKE_SOURCE_DIR}/bindings/python/tests/fdbcli_tests.py ${CMAKE_BINARY_DIR}/bin/fdbcli @CLUSTER_FILE@ diff --git a/bindings/python/tests/fdbcli_tests.py b/bindings/python/tests/fdbcli_tests.py index 9747598878..810257be64 100755 --- a/bindings/python/tests/fdbcli_tests.py +++ b/bindings/python/tests/fdbcli_tests.py @@ -396,7 +396,7 @@ def exclude(logger): if __name__ == '__main__': # fdbcli_tests.py - assert len(sys.argv) == 4, "Please pass arguments: " + assert len(sys.argv) == 4, "Please pass arguments: " # shell command template command_template = [sys.argv[1], '-C', sys.argv[2], '--exec'] # tests for fdbcli commands diff --git a/tests/TestRunner/local_cluster.py b/tests/TestRunner/local_cluster.py index 35a83281ef..11c6c7b7e7 100644 --- a/tests/TestRunner/local_cluster.py +++ b/tests/TestRunner/local_cluster.py @@ -99,6 +99,7 @@ logdir = {logdir} # If a port number is given and process_number > 1, we will use subsequent numbers # E.g., port = 4000, process_number = 5 # Then 4000,4001,4002,4003,4004 will be used as ports + # If port number is not given, we will randomly pick free ports for index, _ in enumerate(range(process_number)): f.write('[fdbserver.{server_port}]\n'.format(server_port=self.port)) self.port = get_free_port() if port is None else str(int(self.port) + 1)