apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-14 18:02:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

address review comments

Browse Source
This commit is contained in:
Markus Pilman 2021-03-11 16:53:08 -07:00
parent bb53f49aa2
commit 3342d9438e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fdbrpc/FlowTransport.actor.cpp
View File

@ -171,7 +171,7 @@ TaskPriority EndpointMap::getPriority(Endpoint::Token const& token) {
// we don't allow this priority to be "misused" for other stuff as we won't even
// attempt to find an endpoint if UnknownEndpoint is returned here
ASSERT(res != TaskPriority::UnknownEndpoint);
return static_cast<TaskPriority>(data[index].token().second());
return res;
}
return TaskPriority::UnknownEndpoint;
}
@ -1070,7 +1070,9 @@ static void scanPackets(TransportData* transport,
// we ignore packets to unknown endpoints if they're not going to a stream anyways, so we can just
// return here. The main place where this seems to happen is if a ReplyPromise is not waited on
// long enough.
// It would be slightly more elegant to put this if-block
// It would be slightly more elegant/readable to put this if-block into the deliver actor, but if
// we have many messages to UnknownEndpoint we want to optimize earlier. As deliver is an actor it
// will allocate some state on the heap and this prevents it from doing that.
if (priority != TaskPriority::UnknownEndpoint || (token.first() & TOKEN_STREAM_FLAG) == 0) {
deliver(transport, Endpoint({ peerAddress }, token), priority, std::move(reader), true);
}