apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-06-01 10:45:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix hashCode() and equals() for MappedKeyValue (#10170)

Browse Source
This commit is contained in:
Hao Fu 2023-05-08 16:54:11 -07:00 committed by GitHub
parent 53e68065e7
commit 3158f8b033
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bindings/java/src/main/com/apple/foundationdb/MappedKeyValue.java
View File

@ -22,8 +22,6 @@ package com.apple.foundationdb;
import com.apple.foundationdb.tuple.ByteArrayUtil; import com.apple.foundationdb.tuple.ByteArrayUtil;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
@ -102,20 +100,24 @@ public class MappedKeyValue extends KeyValue {
return false; return false;
MappedKeyValue rhs = (MappedKeyValue) obj; MappedKeyValue rhs = (MappedKeyValue) obj;
return Arrays.equals(rangeBegin, rhs.rangeBegin) && Arrays.equals(rangeEnd, rhs.rangeEnd) && return Arrays.equals(getKey(), rhs.getKey()) && Arrays.equals(getValue(), rhs.getValue())
Objects.equals(rangeResult, rhs.rangeResult); && Arrays.equals(rangeBegin, rhs.rangeBegin) && Arrays.equals(rangeEnd, rhs.rangeEnd)
&& Objects.equals(rangeResult, rhs.rangeResult);
} }
@Override @Override
public int hashCode() { public int hashCode() {
int hashForResult = rangeResult == null ? 0 : rangeResult.hashCode(); int hashForResult = rangeResult == null ? 0 : rangeResult.hashCode();
return 17 + (29 * hashForResult + 37 * Arrays.hashCode(rangeBegin) + Arrays.hashCode(rangeEnd)); return 17 + (13 * Arrays.hashCode(getKey()) + 11 * Arrays.hashCode(getValue())
+ 29 * hashForResult + 37 * Arrays.hashCode(rangeBegin) + Arrays.hashCode(rangeEnd));
} }
@Override @Override
public String toString() { public String toString() {
final StringBuilder sb = new StringBuilder("MappedKeyValue{"); final StringBuilder sb = new StringBuilder("MappedKeyValue{");
sb.append("rangeBegin=").append(ByteArrayUtil.printable(rangeBegin)); sb.append("key=").append(ByteArrayUtil.printable(getKey()));
sb.append(", value=").append(ByteArrayUtil.printable(getValue()));
sb.append(", rangeBegin=").append(ByteArrayUtil.printable(rangeBegin));
sb.append(", rangeEnd=").append(ByteArrayUtil.printable(rangeEnd)); sb.append(", rangeEnd=").append(ByteArrayUtil.printable(rangeEnd));
sb.append(", rangeResult=").append(rangeResult); sb.append(", rangeResult=").append(rangeResult);
sb.append('}'); sb.append('}');