From 3108102f26637e3fdd22bd0acd923d0e06cc8f7c Mon Sep 17 00:00:00 2001 From: Jingyu Zhou Date: Sun, 31 May 2020 14:15:12 -0700 Subject: [PATCH] Fix a backup progress true-up bug Sometimes, the true-up has to go backup multiple epochs for saved versions, because a tag's progress can be missing in an epoch. In other words, we need to check progress for all tags. --- fdbserver/BackupProgress.actor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdbserver/BackupProgress.actor.cpp b/fdbserver/BackupProgress.actor.cpp index 898ce31b70..037c0bb6e3 100644 --- a/fdbserver/BackupProgress.actor.cpp +++ b/fdbserver/BackupProgress.actor.cpp @@ -115,7 +115,7 @@ std::map, std::map> BackupProgr // ASSERT(info.logRouterTags == epochTags[rit->first]); updateTagVersions(&tagVersions, &tags, rit->second, info.epochEnd, adjustedBeginVersion, epoch); - break; + if (tags.empty()) break; } rit++; }