diff --git a/fdbclient/CommitProxyInterface.h b/fdbclient/CommitProxyInterface.h index a0d396694c..7e670ed08a 100644 --- a/fdbclient/CommitProxyInterface.h +++ b/fdbclient/CommitProxyInterface.h @@ -203,7 +203,7 @@ struct GetReadVersionReply : public BasicLoadBalancedReply { TransactionTagMap tagThrottleInfo; - GetReadVersionReply() : version(invalidVersion), locked(false), rkThrottled(false) {} + GetReadVersionReply() : version(invalidVersion), locked(false) {} template void serialize(Ar& ar) { diff --git a/fdbclient/NativeAPI.actor.cpp b/fdbclient/NativeAPI.actor.cpp index 4c8947d81f..4d05bf2974 100644 --- a/fdbclient/NativeAPI.actor.cpp +++ b/fdbclient/NativeAPI.actor.cpp @@ -1066,8 +1066,10 @@ ACTOR static Future backgroundGrvUpdater(DatabaseContext* cx) { wait(tr.onError(e)); } } else { - wait(delay(0.001 + std::min(CLIENT_KNOBS->MAX_PROXY_CONTACT_LAG - (curTime - lastProxyTime), - (CLIENT_KNOBS->MAX_VERSION_CACHE_LAG - grvDelay) - (curTime - lastTime)))); + wait( + delay(std::max(0.001, + std::min(CLIENT_KNOBS->MAX_PROXY_CONTACT_LAG - (curTime - lastProxyTime), + (CLIENT_KNOBS->MAX_VERSION_CACHE_LAG - grvDelay) - (curTime - lastTime))))); } } } catch (Error& e) { diff --git a/fdbclient/ReadYourWrites.h b/fdbclient/ReadYourWrites.h index 147cc75499..b8ccd23e54 100644 --- a/fdbclient/ReadYourWrites.h +++ b/fdbclient/ReadYourWrites.h @@ -44,8 +44,6 @@ struct ReadYourWritesTransactionOptions { int maxRetries; int snapshotRywEnabled; bool bypassUnreadable : 1; - bool useGrvCache : 1; - bool skipGrvCache : 1; ReadYourWritesTransactionOptions() {} explicit ReadYourWritesTransactionOptions(Transaction const& tr); diff --git a/fdbclient/vexillographer/fdb.options b/fdbclient/vexillographer/fdb.options index 3e91511bf7..c4845ae8bd 100644 --- a/fdbclient/vexillographer/fdb.options +++ b/fdbclient/vexillographer/fdb.options @@ -295,7 +295,8 @@ description is not currently required but encouraged.