Alan Agius ae73e44b2a feat(@schematics/angular): don't generate special package.json and no-any when using --strict
Following feedback from the community, which showed a high number of users found it hard to work with the `no-any` lint rule and also the `sideEffects` package.json file. With DevRel we decided to remove both features when generating a strict workspace and/or application.
2020-09-30 20:56:04 +02:00

94 lines
3.7 KiB
TypeScript

/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import { JsonParseMode, parseJson } from '@angular-devkit/core';
import { SchematicTestRunner } from '@angular-devkit/schematics/testing';
import { latestVersions } from '../utility/latest-versions';
import { Schema as WorkspaceOptions } from './schema';
describe('Workspace Schematic', () => {
const schematicRunner = new SchematicTestRunner(
'@schematics/angular',
require.resolve('../collection.json'),
);
const defaultOptions: WorkspaceOptions = {
name: 'foo',
version: '6.0.0',
};
it('should create all files of a workspace', async () => {
const options = { ...defaultOptions };
const tree = await schematicRunner.runSchematicAsync('workspace', options).toPromise();
const files = tree.files;
expect(files).toEqual(jasmine.arrayContaining([
'/.editorconfig',
'/angular.json',
'/.gitignore',
'/package.json',
'/README.md',
'/tsconfig.json',
'/tslint.json',
]));
});
it('should set the name in package.json', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', defaultOptions).toPromise();
const pkg = JSON.parse(tree.readContent('/package.json'));
expect(pkg.name).toEqual('foo');
});
it('should set the CLI version in package.json', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', defaultOptions).toPromise();
const pkg = JSON.parse(tree.readContent('/package.json'));
expect(pkg.devDependencies['@angular/cli']).toMatch('6.0.0');
});
it('should use the latest known versions in package.json', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', defaultOptions).toPromise();
const pkg = JSON.parse(tree.readContent('/package.json'));
expect(pkg.dependencies['@angular/core']).toEqual(latestVersions.Angular);
expect(pkg.dependencies['rxjs']).toEqual(latestVersions.RxJs);
expect(pkg.dependencies['zone.js']).toEqual(latestVersions.ZoneJs);
expect(pkg.devDependencies['typescript']).toEqual(latestVersions.TypeScript);
});
it('should create correct files when using minimal', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', { ...defaultOptions, minimal: true }).toPromise();
const files = tree.files;
expect(files).toEqual(jasmine.arrayContaining([
'/angular.json',
'/.gitignore',
'/package.json',
'/README.md',
'/tsconfig.json',
]));
expect(files).not.toContain('/tslint.json');
expect(files).not.toContain('/.editorconfig');
});
it('should not add strict compiler options when false', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', { ...defaultOptions, strict: false }).toPromise();
const { compilerOptions, angularCompilerOptions } =
// tslint:disable-next-line: no-any
parseJson(tree.readContent('tsconfig.json').toString(), JsonParseMode.Loose) as any;
expect(compilerOptions.strict).toBeUndefined();
expect(angularCompilerOptions).toBeUndefined();
});
it('should add strict compiler options when true', async () => {
const tree = await schematicRunner.runSchematicAsync('workspace', { ...defaultOptions, strict: true }).toPromise();
const { compilerOptions, angularCompilerOptions } =
// tslint:disable-next-line: no-any
parseJson(tree.readContent('tsconfig.json').toString(), JsonParseMode.Loose) as any;
expect(compilerOptions.strict).toBe(true);
expect(angularCompilerOptions.strictTemplates).toBe(true);
});
});