mirror of
https://github.com/angular/angular-cli.git
synced 2025-05-17 02:54:21 +08:00
9dd3f0344f
* build: disconnect `@npm` workspace from main project This will speed up significantly as we don't need to fetch all dependencies again just for the `@npm` repository that is at this point only leveraged by the `ng_package` rule for some of its dependencies. This commit allows us to drop the `yarn.lock` and Aspect lock files, and allows us to independently migrate `ng_package` to `rules_js`. It also allows us to drop the `_rjs` TS interop layer in follow-up commits. * build: drop `_rjs` suffix from `ts_project` targets We don't need the `ts_project` interop in principle at this point. We only have one remaining instance left for the SSR `ng_package` integration. This commit cleans up all usages. * build: remove yarn * build: avoid duplicated dependencies at top-level `rules_js` seems to be sensitive if there are similar versions of the same package installed, but with differently matched peer dependencies. This is fine because we can (and should long-term) move those dependencies to their package-local `package.json` files. This commit unblocks the migration and highlights how we can move deps to the individual packages in the future. * build: update checkout github action This will allow us to use pnpm. * build: update node to avoid strict-engines error caused by `npm` Avoids: ``` Lockfile is up to date, resolution step is skipped ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version) Your Node version is incompatible with "npm@11.2.0". Expected version: ^20.17.0 || >=22.9.0 Got: v20.11.1 ``` Note that we won't update the WORKSPACE test version as that would mean we need to update the Node engines for shipped packages; and we can't do this right now without introducing a breaking change. * build: fix missing dependency for spec bundling The beasties JS sources weren't available for bundling in the `bazel-bin`, and this surfaced in RBE. This commit fixes this.
55 lines
2.0 KiB
JavaScript
55 lines
2.0 KiB
JavaScript
const {exec} = require('shelljs');
|
|
const {Parser: parser} = require('yargs/helpers');
|
|
|
|
// Remove all command line flags from the arguments.
|
|
const argv = parser(process.argv.slice(2));
|
|
// The command the user would like to run, either 'accept' or 'test'
|
|
const USER_COMMAND = argv._[0];
|
|
// The shell command to query for all Public API guard tests.
|
|
const BAZEL_PUBLIC_API_TARGET_QUERY_CMD =
|
|
`pnpm -s bazel query --output label 'kind(nodejs_test, ...) intersect attr("tags", "api_guard", ...)'`
|
|
// Bazel targets for testing Public API goldens
|
|
process.stdout.write('Gathering all Public API targets');
|
|
const ALL_PUBLIC_API_TESTS = exec(BAZEL_PUBLIC_API_TARGET_QUERY_CMD, {silent: true})
|
|
.trim()
|
|
.split('\n')
|
|
.map(test => test.trim());
|
|
process.stdout.clearLine();
|
|
process.stdout.cursorTo(0);
|
|
// Bazel targets for generating Public API goldens
|
|
const ALL_PUBLIC_API_ACCEPTS = ALL_PUBLIC_API_TESTS.map(test => `${test}.accept`);
|
|
|
|
/**
|
|
* Run the provided bazel commands on each provided target individually.
|
|
*/
|
|
function runBazelCommandOnTargets(command, targets, present) {
|
|
for (const target of targets) {
|
|
process.stdout.write(`${present}: ${target}`);
|
|
const commandResult = exec(`pnpm -s bazel ${command} ${target}`, {silent: true});
|
|
process.stdout.clearLine();
|
|
process.stdout.cursorTo(0);
|
|
if (commandResult.code) {
|
|
console.error(`Failed ${command}: ${target}`);
|
|
console.group();
|
|
console.error(commandResult.stdout || commandResult.stderr);
|
|
console.groupEnd();
|
|
} else {
|
|
console.log(`Successful ${command}: ${target}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
switch (USER_COMMAND) {
|
|
case 'accept':
|
|
runBazelCommandOnTargets('run', ALL_PUBLIC_API_ACCEPTS, 'Running');
|
|
break;
|
|
case 'test':
|
|
runBazelCommandOnTargets('test', ALL_PUBLIC_API_TESTS, 'Testing');
|
|
break;
|
|
default:
|
|
console.warn('Invalid command provided.');
|
|
console.warn();
|
|
console.warn(`Run this script with either "accept" and "test"`);
|
|
break;
|
|
}
|