mirror of
https://github.com/angular/angular-cli.git
synced 2025-05-14 17:43:52 +08:00
5fd1cb56ab
As part of go/ng:windows-dev-future, we are changing how our infrastructure supports Windows build & testing. Clearly: - we will still support contributors on Windows, and we believe we will be improving and streamlining the experience here - we will continue testing the Angular CLI for our Windows users. We are aware of the many Windows users using the `ng` CLI. What is changing? We are no longer actively working towards a Bazel infrastructure that supports native Windows building and testing. There are currently two ways to contribute to Angular on Windows. That is via WSL, or via e.g. native Windows cmd.exe, with Git Bash on top. We acknowledge that the latter worked sometimes, but we also realize it very often breaks as nobody on our team uses, verifies it, and it introduces extra complexity because Bazel on Windows is quite disconnected from Linux/Mac (e.g. no sandboxing). Going forward, to improve our team's effectiveness, and improve our stability guarantees for Windows (and Windows contributors), we are actively discouraging the use of Git Bash for contributing to Angular; but instead ask for WSL to be used. I can speak as one of the few long-term team members that have worked on Windows (without WSL) most of my time, that WSL is great and the contributing experience is much smoother and also easier to "guide". It's a positive change because we won't be suggesting "two ways to contribute on Windows", where in reality one is very brittle and can break at any time! --- For testing of the Angular CLI: We will continue to maintain the capability to cross-compile via Bazel with Windows as the target platform. This allows us to build the e2e tests for Windows, and run them natively outside WSL to ensure native Windows `ng` CLI testing! This is what this change mostly does. Notably, two things are missing here and will be followed up: - caching of the e2e tests on Windows is not properly functioning yet. - caching of the WSL node modules + nvm is not working properly yet. Other than that, we are seeing very similar timing and results of the Windows tests, so this change unblocks our `rules_js` migration.
52 lines
1.1 KiB
Python
52 lines
1.1 KiB
Python
load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
|
|
load("//tools:defaults2.bzl", "js_binary")
|
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
platform(
|
|
name = "windows_x64",
|
|
constraint_values = [
|
|
"@platforms//os:windows",
|
|
"@platforms//cpu:x86_64",
|
|
],
|
|
)
|
|
|
|
exports_files([
|
|
"package_json_release_filter.jq",
|
|
])
|
|
|
|
js_binary(
|
|
name = "ng_cli_schema",
|
|
data = [
|
|
"ng_cli_schema_generator.js",
|
|
],
|
|
entry_point = "ng_cli_schema_generator.js",
|
|
)
|
|
|
|
js_binary(
|
|
name = "quicktype_runner",
|
|
data = [
|
|
"quicktype_runner.js",
|
|
"//:node_modules/quicktype-core",
|
|
],
|
|
entry_point = "quicktype_runner.js",
|
|
)
|
|
|
|
# TODO(devversion): Improve this by potentially sharing this common block.
|
|
copy_file(
|
|
name = "copy_worker_js",
|
|
src = "@tsc_worker//file",
|
|
out = "ts_worker.mjs",
|
|
)
|
|
|
|
js_binary(
|
|
name = "vanilla_ts_worker",
|
|
data = [
|
|
":copy_worker_js",
|
|
"//:node_modules/@angular/compiler-cli",
|
|
"//:node_modules/typescript",
|
|
],
|
|
entry_point = ":copy_worker_js",
|
|
fixed_args = ["--vanilla-ts"],
|
|
)
|