mirror of
https://github.com/angular/angular-cli.git
synced 2025-05-17 19:13:34 +08:00
3c8b33ab3a
This commits adds a base href value in the karma context iframe used to run unit tests. It solves a very old issue in Angular https://github.com/angular/angular/issues/12295 where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document. even if the application is fine. This is because the `index.html` from Angular CLI contains a base href value, but not the Karma context iframe. So when adding a unit test with a testing module that imports a NgModule, for example `AppModule`, which itself imports `RouterModule`, the unit test used to throw an error (regression appeared in router 3.1). That could be solved by either adding `RouterTestingModule` to the testing module, or by adding a provider `{ provide: APP_BASE_HREF, useValue: '/' }`, but required to understand the issue (see how many thumbs up there are on the original issue). This solves the issue in a transparent way: developers won't even encounter the problem anymore.
Angular Webpack Build Facade
WIP