Charles Lyding 23cc337aa3 fix(@schematics/angular): keep deployUrl option when migrating to application builder
The `deployUrl` option is now supported with the new build system
when using the `application` builder. The migration schematic
no longer needs to remove the option if present.
2024-04-24 07:09:11 -04:00

344 lines
11 KiB
TypeScript

/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {
DirEntry,
Rule,
SchematicContext,
SchematicsException,
Tree,
chain,
externalSchematic,
} from '@angular-devkit/schematics';
import { basename, dirname, extname, join } from 'node:path/posix';
import { JSONFile } from '../../utility/json-file';
import { TargetDefinition, allTargetOptions, updateWorkspace } from '../../utility/workspace';
import { Builders, ProjectType } from '../../utility/workspace-models';
import { findImports } from './css-import-lexer';
function* updateBuildTarget(
projectName: string,
buildTarget: TargetDefinition,
serverTarget: TargetDefinition | undefined,
tree: Tree,
context: SchematicContext,
): Iterable<Rule> {
// Update builder target and options
buildTarget.builder = Builders.Application;
for (const [, options] of allTargetOptions(buildTarget, false)) {
if (options['index'] === '') {
options['index'] = false;
}
// Rename and transform options
options['browser'] = options['main'];
if (serverTarget && typeof options['browser'] === 'string') {
options['server'] = dirname(options['browser']) + '/main.server.ts';
}
options['serviceWorker'] = options['ngswConfigPath'] ?? options['serviceWorker'];
if (typeof options['polyfills'] === 'string') {
options['polyfills'] = [options['polyfills']];
}
let outputPath = options['outputPath'];
if (typeof outputPath === 'string') {
if (!/\/browser\/?$/.test(outputPath)) {
// TODO: add prompt.
context.logger.warn(
`The output location of the browser build has been updated from "${outputPath}" to ` +
`"${join(outputPath, 'browser')}". ` +
'You might need to adjust your deployment pipeline or, as an alternative, ' +
'set outputPath.browser to "" in order to maintain the previous functionality.',
);
} else {
outputPath = outputPath.replace(/\/browser\/?$/, '');
}
options['outputPath'] = {
base: outputPath,
};
if (typeof options['resourcesOutputPath'] === 'string') {
const media = options['resourcesOutputPath'].replaceAll('/', '');
if (media && media !== 'media') {
options['outputPath'] = {
base: outputPath,
media,
};
}
}
}
// Delete removed options
delete options['vendorChunk'];
delete options['commonChunk'];
delete options['resourcesOutputPath'];
delete options['buildOptimizer'];
delete options['main'];
delete options['ngswConfigPath'];
}
// Merge browser and server tsconfig
if (serverTarget) {
const browserTsConfig = buildTarget.options?.tsConfig;
const serverTsConfig = serverTarget.options?.tsConfig;
if (typeof browserTsConfig !== 'string') {
throw new SchematicsException(
`Cannot update project "${projectName}" to use the application builder` +
` as the browser tsconfig cannot be located.`,
);
}
if (typeof serverTsConfig !== 'string') {
throw new SchematicsException(
`Cannot update project "${projectName}" to use the application builder` +
` as the server tsconfig cannot be located.`,
);
}
const browserJson = new JSONFile(tree, browserTsConfig);
const serverJson = new JSONFile(tree, serverTsConfig);
const filesPath = ['files'];
const files = new Set([
...((browserJson.get(filesPath) as string[] | undefined) ?? []),
...((serverJson.get(filesPath) as string[] | undefined) ?? []),
]);
// Server file will be added later by the means of the ssr schematic.
files.delete('server.ts');
browserJson.modify(filesPath, Array.from(files));
const typesPath = ['compilerOptions', 'types'];
browserJson.modify(
typesPath,
Array.from(
new Set([
...((browserJson.get(typesPath) as string[] | undefined) ?? []),
...((serverJson.get(typesPath) as string[] | undefined) ?? []),
]),
),
);
// Delete server tsconfig
yield deleteFile(serverTsConfig);
}
// Update server file
const ssrMainFile = serverTarget?.options?.['main'];
if (typeof ssrMainFile === 'string') {
yield deleteFile(ssrMainFile);
yield externalSchematic('@schematics/angular', 'ssr', {
project: projectName,
skipInstall: true,
});
}
}
function updateProjects(tree: Tree, context: SchematicContext) {
return updateWorkspace((workspace) => {
const rules: Rule[] = [];
for (const [name, project] of workspace.projects) {
if (project.extensions.projectType !== ProjectType.Application) {
// Only interested in application projects since these changes only effects application builders
continue;
}
const buildTarget = project.targets.get('build');
if (!buildTarget || buildTarget.builder === Builders.Application) {
continue;
}
if (
buildTarget.builder !== Builders.BrowserEsbuild &&
buildTarget.builder !== Builders.Browser
) {
context.logger.error(
`Cannot update project "${name}" to use the application builder.` +
` Only "${Builders.BrowserEsbuild}" and "${Builders.Browser}" can be automatically migrated.`,
);
continue;
}
const serverTarget = project.targets.get('server');
rules.push(...updateBuildTarget(name, buildTarget, serverTarget, tree, context));
// Delete all redundant targets
for (const [key, target] of project.targets) {
switch (target.builder) {
case Builders.Server:
case Builders.Prerender:
case Builders.AppShell:
case Builders.SsrDevServer:
project.targets.delete(key);
break;
}
}
// Update CSS/Sass import specifiers
const projectSourceRoot = join(project.root, project.sourceRoot ?? 'src');
updateStyleImports(tree, projectSourceRoot, buildTarget);
}
return chain(rules);
});
}
function* visit(
directory: DirEntry,
): IterableIterator<[fileName: string, contents: string, sass: boolean]> {
for (const path of directory.subfiles) {
const sass = path.endsWith('.scss');
if (path.endsWith('.css') || sass) {
const entry = directory.file(path);
if (entry) {
const content = entry.content;
yield [entry.path, content.toString(), sass];
}
}
}
for (const path of directory.subdirs) {
if (path === 'node_modules' || path.startsWith('.')) {
continue;
}
yield* visit(directory.dir(path));
}
}
// Based on https://github.com/sass/dart-sass/blob/44d6bb6ac72fe6b93f5bfec371a1fffb18e6b76d/lib/src/importer/utils.dart
function* potentialSassImports(
specifier: string,
base: string,
fromImport: boolean,
): Iterable<string> {
const directory = join(base, dirname(specifier));
const extension = extname(specifier);
const hasStyleExtension = extension === '.scss' || extension === '.sass' || extension === '.css';
// Remove the style extension if present to allow adding the `.import` suffix
const filename = basename(specifier, hasStyleExtension ? extension : undefined);
if (hasStyleExtension) {
if (fromImport) {
yield join(directory, filename + '.import' + extension);
yield join(directory, '_' + filename + '.import' + extension);
}
yield join(directory, filename + extension);
yield join(directory, '_' + filename + extension);
} else {
if (fromImport) {
yield join(directory, filename + '.import.scss');
yield join(directory, filename + '.import.sass');
yield join(directory, filename + '.import.css');
yield join(directory, '_' + filename + '.import.scss');
yield join(directory, '_' + filename + '.import.sass');
yield join(directory, '_' + filename + '.import.css');
}
yield join(directory, filename + '.scss');
yield join(directory, filename + '.sass');
yield join(directory, filename + '.css');
yield join(directory, '_' + filename + '.scss');
yield join(directory, '_' + filename + '.sass');
yield join(directory, '_' + filename + '.css');
}
}
function updateStyleImports(tree: Tree, projectSourceRoot: string, buildTarget: TargetDefinition) {
const external = new Set<string>();
let needWorkspaceIncludePath = false;
for (const file of visit(tree.getDir(projectSourceRoot))) {
const [path, content, sass] = file;
const relativeBase = dirname(path);
let updater;
for (const { start, specifier, fromUse } of findImports(content, sass)) {
if (specifier[0] === '~') {
updater ??= tree.beginUpdate(path);
// start position includes the opening quote
updater.remove(start + 1, 1);
} else if (specifier[0] === '^') {
updater ??= tree.beginUpdate(path);
// start position includes the opening quote
updater.remove(start + 1, 1);
// Add to externalDependencies
external.add(specifier.slice(1));
} else if (
sass &&
[...potentialSassImports(specifier, relativeBase, !fromUse)].every(
(v) => !tree.exists(v),
) &&
[...potentialSassImports(specifier, '/', !fromUse)].some((v) => tree.exists(v))
) {
needWorkspaceIncludePath = true;
}
}
if (updater) {
tree.commitUpdate(updater);
}
}
if (needWorkspaceIncludePath) {
buildTarget.options ??= {};
buildTarget.options['stylePreprocessorOptions'] ??= {};
((buildTarget.options['stylePreprocessorOptions'] as { includePaths?: string[] })[
'includePaths'
] ??= []).push('.');
}
if (external.size > 0) {
buildTarget.options ??= {};
((buildTarget.options['externalDependencies'] as string[] | undefined) ??= []).push(
...external,
);
}
}
function deleteFile(path: string): Rule {
return (tree) => {
tree.delete(path);
};
}
function updateJsonFile(path: string, updater: (json: JSONFile) => void): Rule {
return (tree) => {
updater(new JSONFile(tree, path));
};
}
/**
* Migration main entrypoint
*/
export default function (): Rule {
return chain([
updateProjects,
// Delete package.json helper scripts
updateJsonFile('package.json', (pkgJson) =>
['build:ssr', 'dev:ssr', 'serve:ssr', 'prerender'].forEach((s) =>
pkgJson.remove(['scripts', s]),
),
),
// Update main tsconfig
updateJsonFile('tsconfig.json', (rootJson) => {
rootJson.modify(['compilerOptions', 'esModuleInterop'], true);
rootJson.modify(['compilerOptions', 'downlevelIteration'], undefined);
rootJson.modify(['compilerOptions', 'allowSyntheticDefaultImports'], undefined);
}),
]);
}