Alan Agius 17ba2bc450 fix(@schematics/angular): set optimization and sourceMap in universal production config
- When using Universal sourceMaps should not be enabled or at least `styles` sourceMaps should be disabled as these will otherwise be inlined and will be set as apart of the server side rendered page.

- While there is no benefit to optimize the scripts at server level, styles should always be minified so that the server side rendered page is smaller.

Fixes #12541 and Fixes #12940
2018-12-14 10:54:30 -08:00

248 lines
8.3 KiB
TypeScript

/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {
Path,
basename,
experimental,
join,
normalize,
parseJson,
strings,
} from '@angular-devkit/core';
import {
Rule,
SchematicContext,
SchematicsException,
Tree,
apply,
chain,
mergeWith,
move,
template,
url,
} from '@angular-devkit/schematics';
import {
NodePackageInstallTask,
} from '@angular-devkit/schematics/tasks';
import * as ts from 'typescript';
import { findNode, getDecoratorMetadata } from '../utility/ast-utils';
import { InsertChange } from '../utility/change';
import { getWorkspace, updateWorkspace } from '../utility/config';
import { addPackageJsonDependency, getPackageJsonDependency } from '../utility/dependencies';
import { findBootstrapModuleCall, findBootstrapModulePath } from '../utility/ng-ast-utils';
import { getProject } from '../utility/project';
import { getProjectTargets, targetBuildNotFoundError } from '../utility/project-targets';
import { Builders, WorkspaceTargets } from '../utility/workspace-models';
import { Schema as UniversalOptions } from './schema';
function getFileReplacements(target: WorkspaceTargets) {
const fileReplacements =
target.build &&
target.build.configurations &&
target.build.configurations.production &&
target.build.configurations.production.fileReplacements;
return fileReplacements || [];
}
function updateConfigFile(options: UniversalOptions, tsConfigDirectory: Path): Rule {
return (host: Tree) => {
const workspace = getWorkspace(host);
const clientProject = getProject(workspace, options.clientProject);
const projectTargets = getProjectTargets(clientProject);
projectTargets.server = {
builder: Builders.Server,
options: {
outputPath: `dist/${options.clientProject}-server`,
main: `${clientProject.root}src/main.server.ts`,
tsConfig: join(tsConfigDirectory, `${options.tsconfigFileName}.json`),
},
configurations: {
production: {
fileReplacements: getFileReplacements(projectTargets),
sourceMap: false,
optimization: {
scripts: false,
styles: true,
},
},
},
};
return updateWorkspace(workspace);
};
}
function findBrowserModuleImport(host: Tree, modulePath: string): ts.Node {
const moduleBuffer = host.read(modulePath);
if (!moduleBuffer) {
throw new SchematicsException(`Module file (${modulePath}) not found`);
}
const moduleFileText = moduleBuffer.toString('utf-8');
const source = ts.createSourceFile(modulePath, moduleFileText, ts.ScriptTarget.Latest, true);
const decoratorMetadata = getDecoratorMetadata(source, 'NgModule', '@angular/core')[0];
const browserModuleNode = findNode(decoratorMetadata, ts.SyntaxKind.Identifier, 'BrowserModule');
if (browserModuleNode === null) {
throw new SchematicsException(`Cannot find BrowserModule import in ${modulePath}`);
}
return browserModuleNode;
}
function wrapBootstrapCall(options: UniversalOptions): Rule {
return (host: Tree) => {
const clientTargets = getProjectTargets(host, options.clientProject);
if (!clientTargets.build) {
throw targetBuildNotFoundError();
}
const mainPath = normalize('/' + clientTargets.build.options.main);
let bootstrapCall: ts.Node | null = findBootstrapModuleCall(host, mainPath);
if (bootstrapCall === null) {
throw new SchematicsException('Bootstrap module not found.');
}
let bootstrapCallExpression: ts.Node | null = null;
let currentCall = bootstrapCall;
while (bootstrapCallExpression === null && currentCall.parent) {
currentCall = currentCall.parent;
if (currentCall.kind === ts.SyntaxKind.ExpressionStatement) {
bootstrapCallExpression = currentCall;
}
}
bootstrapCall = currentCall;
const recorder = host.beginUpdate(mainPath);
const beforeText = `document.addEventListener('DOMContentLoaded', () => {\n `;
const afterText = `\n});`;
recorder.insertLeft(bootstrapCall.getStart(), beforeText);
recorder.insertRight(bootstrapCall.getEnd(), afterText);
host.commitUpdate(recorder);
};
}
function addServerTransition(options: UniversalOptions): Rule {
return (host: Tree) => {
const clientProject = getProject(host, options.clientProject);
const clientTargets = getProjectTargets(clientProject);
if (!clientTargets.build) {
throw targetBuildNotFoundError();
}
const mainPath = normalize('/' + clientTargets.build.options.main);
const bootstrapModuleRelativePath = findBootstrapModulePath(host, mainPath);
const bootstrapModulePath = normalize(
`/${clientProject.root}/src/${bootstrapModuleRelativePath}.ts`);
const browserModuleImport = findBrowserModuleImport(host, bootstrapModulePath);
const appId = options.appId;
const transitionCall = `.withServerTransition({ appId: '${appId}' })`;
const position = browserModuleImport.pos + browserModuleImport.getFullText().length;
const transitionCallChange = new InsertChange(
bootstrapModulePath, position, transitionCall);
const transitionCallRecorder = host.beginUpdate(bootstrapModulePath);
transitionCallRecorder.insertLeft(transitionCallChange.pos, transitionCallChange.toAdd);
host.commitUpdate(transitionCallRecorder);
};
}
function addDependencies(): Rule {
return (host: Tree) => {
const coreDep = getPackageJsonDependency(host, '@angular/core');
if (coreDep === null) {
throw new SchematicsException('Could not find version.');
}
const platformServerDep = {
...coreDep,
name: '@angular/platform-server',
};
const httpDep = {
...coreDep,
name: '@angular/http',
};
addPackageJsonDependency(host, platformServerDep);
addPackageJsonDependency(host, httpDep);
return host;
};
}
function getTsConfigOutDir(host: Tree, targets: experimental.workspace.WorkspaceTool): string {
const tsConfigPath = targets.build.options.tsConfig;
const tsConfigBuffer = host.read(tsConfigPath);
if (!tsConfigBuffer) {
throw new SchematicsException(`Could not read ${tsConfigPath}`);
}
const tsConfigContent = tsConfigBuffer.toString();
const tsConfig = parseJson(tsConfigContent);
if (tsConfig === null || typeof tsConfig !== 'object' || Array.isArray(tsConfig) ||
tsConfig.compilerOptions === null || typeof tsConfig.compilerOptions !== 'object' ||
Array.isArray(tsConfig.compilerOptions)) {
throw new SchematicsException(`Invalid tsconfig - ${tsConfigPath}`);
}
const outDir = tsConfig.compilerOptions.outDir;
return outDir as string;
}
export default function (options: UniversalOptions): Rule {
return (host: Tree, context: SchematicContext) => {
const clientProject = getProject(host, options.clientProject);
if (clientProject.projectType !== 'application') {
throw new SchematicsException(`Universal requires a project type of "application".`);
}
const clientTargets = getProjectTargets(clientProject);
const outDir = getTsConfigOutDir(host, clientTargets);
if (!clientTargets.build) {
throw targetBuildNotFoundError();
}
const tsConfigExtends = basename(normalize(clientTargets.build.options.tsConfig));
const rootInSrc = clientProject.root === '';
const tsConfigDirectory = join(normalize(clientProject.root), rootInSrc ? 'src' : '');
if (!options.skipInstall) {
context.addTask(new NodePackageInstallTask());
}
const templateSource = apply(url('./files/src'), [
template({
...strings,
...options as object,
stripTsExtension: (s: string) => s.replace(/\.ts$/, ''),
}),
move(join(normalize(clientProject.root), 'src')),
]);
const rootSource = apply(url('./files/root'), [
template({
...strings,
...options as object,
stripTsExtension: (s: string) => s.replace(/\.ts$/, ''),
outDir,
tsConfigExtends,
rootInSrc,
}),
move(tsConfigDirectory),
]);
return chain([
mergeWith(templateSource),
mergeWith(rootSource),
addDependencies(),
updateConfigFile(options, tsConfigDirectory),
wrapBootstrapCall(options),
addServerTransition(options),
]);
};
}