19 Commits

Author SHA1 Message Date
Charles Lyding
cfbd6e81fb refactor(@schematics/angular): use type guard based narrowing in ast-utils
By leveraging TypeScript's AST type guards, function parameter assumptions and casting can be removed.  Many of these cases caused errors when enabling TypeScript's strict option. This is preliminary work to support enabling full TypeScript strict mode within the project.
2020-06-13 20:08:59 +02:00
Artur Androsovych
545847788d fix(@schematics/angular): handle aliased or existing environment import (#16377)
Closes: #16226
2019-12-20 16:33:31 -08:00
timdeschryver
3784859d13 fix(@schematics/angular): add new route before wildcard route 2019-11-18 10:55:19 -08:00
Alan Agius
aad8fa1fab refactor(@schematics/angular): deprecate component entryComponents
Since version 9.0.0 with Ivy, entryComponents is no longer necessary
2019-11-05 16:36:16 -08:00
Alan Agius
ae0f790ee7 fix(@schematics/angular): change findNodes to stop recursive lookup for child nodes of kind
Curtrently, when a node of kind is found, we recursivly continue to look up it's child nodes until the end of the AST. This ends up returing other nodes which we were not looking for as typically we are looking for the first level of children of the specified kind.

By default now, we stop recursivly looking for child nodes of kind when we encounter one.

Closes #15117
2019-07-24 19:06:47 -07:00
Alan
2c71af1465 fix(@schematics/angular): ignore nested arrays in route declarations
`findNodes` will continue looking for arrays recursively unless we specify that we specify that we want only the first array.

Routes array can contain nested arrays such as when specifying guards.

Fixes #15016
2019-07-10 04:18:23 +08:00
Alan
70a4cbe306 style: enable no-debugger and no-console tslint rules 2019-06-27 09:28:35 -07:00
hawkgs
fdcd1f7546 feat(@schematics/angular): lazy routing module generator
Introduces the lazy routing module generator as part of the existing
module generator.

Feature document:
https://docs.google.com/document/d/1NAJEWTG54cu4kW7XBp0gVadmz-gqJouW2XDs4c9PPJM/edit#heading=h.xgjl2srtytjt
2019-06-26 11:15:58 -07:00
Alan
22d77285e1 fix(@schematics/angular): handle newline after @ of a decorator
Fixes #14490
2019-05-23 19:14:58 +02:00
hawkgs
c402903a3d refactor(@schematics/angular): optimize insertAfterLastOccurrence AST util 2019-05-17 11:26:53 -07:00
hawkgs
52e9819232 fix(@schematics/angular): allow insertion when there are no occurrences 2019-05-09 10:06:09 -07:00
Alex Eagle
bf1c069f73 refactor(@schematics/angular): drop dependency on TypeScript package
instead, vendor in the two files we actually need.
This reduces our install footprint by 5MB
2019-03-06 11:27:48 -08:00
赵正阳
822d6a0b9b fix(@schematics/angular): add providers into providers metadata but not inner Object with ut. (#13081) 2018-11-30 14:08:49 -08:00
Alan Agius
8f0d03b6c2 fix(@schematics/angular): addSymbolToNgModuleMetadata metadata without indent
At the moment, at least a single whitespace is required as otherwise the following error `Cannot read property '0' of null ` will be thrown

Fixes #12950
2018-11-14 12:42:48 -08:00
vikerman
e3f56ebc71
fix(@schematics/angular): ast utils - handle NgModule with no newlines (#12521)
Exposed in Google where the formatting is different. Check for null before using a regex match result.
2018-10-09 06:37:50 -07:00
Charles Lyding
d202480a17 build: update/cleanup tslint rules & fix errors 2018-08-23 11:35:34 -07:00
Hans Larsen
548616eda3 feat(@schematics/angular): use STDERR to report warnings 2018-08-21 09:57:34 -07:00
Hans Larsen
483cbe2665 refactor: add tslint-sonarts and a lot of tslint rules
This should clean up the code a bit.

Note: at first I added the no-useless-cast rule, but after getting frustrated
with it (as it has many false positive), I decided to remove the rule but some
useless casts were removed so I let those in the PR.
2018-07-10 15:07:36 -07:00
Hans Larsen
44086c60ff build: move devkit repo back to angular-cli 2018-06-05 18:50:06 -07:00